Browse Source

Fix-up remaining things

Signed-off-by: Mario Danic <mario@lovelyhq.com>
Mario Danic 5 years ago
parent
commit
0e6779616b

+ 10 - 9
app/src/main/java/com/nextcloud/talk/adapters/messages/MagicIncomingTextMessageViewHolder.java

@@ -122,20 +122,21 @@ public class MagicIncomingTextMessageViewHolder
                 messageUserAvatarView.getHierarchy().setPlaceholderImage(drawable);
                 messageUserAvatarView.getHierarchy().setPlaceholderImage(drawable);
             }
             }
         } else {
         } else {
-            Resources resources = context.getResources();
-
-            int bg_bubble_color = DisplayUtils.isDarkModeActive(context) ?
-                                resources.getColor(R.color.bg_message_list_incoming_bubble_dark2) :
-                                resources.getColor(R.color.bg_message_list_incoming_bubble);
 
 
             messageUserAvatarView.setVisibility(View.INVISIBLE);
             messageUserAvatarView.setVisibility(View.INVISIBLE);
-            Drawable bubbleDrawable = DisplayUtils.getMessageSelector(bg_bubble_color,
-                    resources.getColor(R.color.transparent),
-                    bg_bubble_color, R.drawable.shape_grouped_incoming_message);
-            ViewCompat.setBackground(bubble, bubbleDrawable);
             messageAuthor.setVisibility(View.GONE);
             messageAuthor.setVisibility(View.GONE);
         }
         }
 
 
+        Resources resources = context.getResources();
+        int bg_bubble_color = DisplayUtils.isDarkModeActive(context) ?
+                resources.getColor(R.color.bg_message_list_incoming_bubble_dark2) :
+                resources.getColor(R.color.bg_message_list_incoming_bubble);
+
+        Drawable bubbleDrawable = DisplayUtils.getMessageSelector(bg_bubble_color,
+                resources.getColor(R.color.transparent),
+                bg_bubble_color, R.drawable.shape_grouped_incoming_message);
+        ViewCompat.setBackground(bubble, bubbleDrawable);
+
         HashMap<String, HashMap<String, String>> messageParameters = message.getMessageParameters();
         HashMap<String, HashMap<String, String>> messageParameters = message.getMessageParameters();
 
 
         Context context = NextcloudTalkApplication.getSharedApplication().getApplicationContext();
         Context context = NextcloudTalkApplication.getSharedApplication().getApplicationContext();

+ 1 - 2
app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.java

@@ -28,7 +28,6 @@ import android.content.res.Configuration;
 import android.content.res.Resources;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.Bitmap;
 import android.graphics.Canvas;
 import android.graphics.Canvas;
-import android.graphics.Paint;
 import android.graphics.Typeface;
 import android.graphics.Typeface;
 import android.graphics.drawable.Animatable;
 import android.graphics.drawable.Animatable;
 import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.BitmapDrawable;
@@ -250,7 +249,7 @@ public class DisplayUtils {
 
 
         if (!isCall) {
         if (!isCall) {
             if (chipResource == R.xml.chip_outgoing_others || chipResource == R.xml.chip_accent_background) {
             if (chipResource == R.xml.chip_outgoing_others || chipResource == R.xml.chip_accent_background) {
-                drawable = R.drawable.white_circle;
+                drawable = R.drawable.mention_chip;
             } else {
             } else {
                 drawable = R.drawable.accent_circle;
                 drawable = R.drawable.accent_circle;
             }
             }

+ 1 - 1
app/src/main/res/drawable/white_circle.xml → app/src/main/res/drawable/mention_chip.xml

@@ -22,5 +22,5 @@
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
     android:shape="oval">
     android:shape="oval">
     <solid
     <solid
-        android:color="@color/bg_default"/>
+        android:color="@color/bg_dark_mention_chips"/>
 </shape>
 </shape>

+ 1 - 1
app/src/main/res/drawable/shape_grouped_incoming_message.xml

@@ -28,6 +28,6 @@
         android:bottomLeftRadius="@dimen/message_bubble_corners_radius"
         android:bottomLeftRadius="@dimen/message_bubble_corners_radius"
         android:topRightRadius="@dimen/message_bubble_corners_radius" />
         android:topRightRadius="@dimen/message_bubble_corners_radius" />
 
 
-    <solid android:color="@color/white" />
+    <solid android:color="@color/bg_default" />
 
 
 </shape>
 </shape>

+ 1 - 1
app/src/main/res/drawable/shape_grouped_outcoming_message.xml

@@ -28,6 +28,6 @@
         android:topLeftRadius="@dimen/message_bubble_corners_radius"
         android:topLeftRadius="@dimen/message_bubble_corners_radius"
         android:bottomRightRadius="@dimen/message_bubble_corners_radius" />
         android:bottomRightRadius="@dimen/message_bubble_corners_radius" />
 
 
-    <solid android:color="@color/white" />
+    <solid android:color="@color/bg_default" />
 
 
 </shape>
 </shape>

+ 1 - 1
app/src/main/res/drawable/shape_outcoming_message.xml

@@ -28,6 +28,6 @@
         android:topLeftRadius="@dimen/message_bubble_corners_radius"
         android:topLeftRadius="@dimen/message_bubble_corners_radius"
         android:bottomRightRadius="@dimen/message_bubble_corners_radius" />
         android:bottomRightRadius="@dimen/message_bubble_corners_radius" />
 
 
-    <solid android:color="@color/white" />
+    <solid android:color="@color/bg_default" />
 
 
 </shape>
 </shape>

+ 1 - 0
app/src/main/res/values/colors.xml

@@ -64,6 +64,7 @@
     <color name="bg_default">#FFFFFF</color>
     <color name="bg_default">#FFFFFF</color>
     <color name="bg_alt">@color/white60</color>
     <color name="bg_alt">@color/white60</color>
     <color name="bg_system_bubble_dark">#444444</color>
     <color name="bg_system_bubble_dark">#444444</color>
+    <color name="bg_dark_mention_chips">#333333</color>
     <color name="bg_message_list_incoming_bubble">#EFEFEF</color>
     <color name="bg_message_list_incoming_bubble">#EFEFEF</color>
     <color name="bg_message_list_incoming_bubble_dark2">#444444</color>
     <color name="bg_message_list_incoming_bubble_dark2">#444444</color>
     <color name="bg_bottom_sheet">#46ffffff</color>
     <color name="bg_bottom_sheet">#46ffffff</color>

+ 1 - 1
app/src/main/res/values/styles.xml

@@ -44,7 +44,7 @@
     </style>
     </style>
 
 
     <style name="ChipOutgoingTextAppearance" parent="TextAppearance.MaterialComponents.Chip">
     <style name="ChipOutgoingTextAppearance" parent="TextAppearance.MaterialComponents.Chip">
-        <item name="android:textColor">@color/nc_outcoming_text_default</item>
+        <item name="android:textColor">@color/nc_incoming_text_default</item>
     </style>
     </style>
 
 
     <style name="ChipMentionTextAppearance" parent="TextAppearance.MaterialComponents.Chip">
     <style name="ChipMentionTextAppearance" parent="TextAppearance.MaterialComponents.Chip">

+ 1 - 1
app/src/main/res/xml/chip_outgoing_others.xml

@@ -22,7 +22,7 @@
 <chip xmlns:android="http://schemas.android.com/apk/res/android"
 <chip xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:textAppearance="@style/ChipOutgoingTextAppearance"
     android:textAppearance="@style/ChipOutgoingTextAppearance"
-    app:chipStrokeColor="@color/white"
+    app:chipStrokeColor="@color/bg_default"
     app:chipBackgroundColor="@color/transparent"
     app:chipBackgroundColor="@color/transparent"
     app:chipStrokeWidth="1dp"
     app:chipStrokeWidth="1dp"
     app:closeIconEnabled="false" />
     app:closeIconEnabled="false" />