Browse Source

use fixed strings where possible to limit lint score bump

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Andy Scherzinger 3 years ago
parent
commit
34f8bb5ab7

+ 2 - 2
app/src/main/java/com/nextcloud/talk/utils/preferences/AppPreferences.java

@@ -282,11 +282,11 @@ public interface AppPreferences {
     @UnregisterChangeListenerMethod
     void unregisterThemeChangeListener(OnPreferenceValueChangedListener<String> listener);
 
-    @KeyByResource(R.string.nc_settings_db_cypher_v4_upgrade_key)
+    @KeyByString("db_cypher_v4_upgrade")
     @DefaultValue(R.bool.value_true)
     boolean getIsDbCypherToUpgrade();
 
-    @KeyByResource(R.string.nc_settings_db_cypher_v4_upgrade_key)
+    @KeyByString("db_cypher_v4_upgrade")
     void setIsDbCypherToUpgrade(boolean value);
     
     @KeyByResource(R.string.nc_settings_phone_book_integration_key)

+ 0 - 2
app/src/main/res/values/strings.xml

@@ -533,6 +533,4 @@
     <string name="send_without_notification">Send without notification</string>
     <string name="call_without_notification">Call without notification</string>
 
-    <string name="nc_settings_db_cypher_v4_upgrade_key" translatable="false">db_cypher_v4_upgrade</string>
-
 </resources>

+ 1 - 1
scripts/analysis/lint-results.txt

@@ -1,2 +1,2 @@
 DO NOT TOUCH; GENERATED BY DRONE
-      <span class="mdl-layout-title">Lint Report: 2 errors and 122 warnings</span>
+      <span class="mdl-layout-title">Lint Report: 2 errors and 123 warnings</span>