work on codacy warnings

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>

app/src/main/java/com/nextcloud/talk/contacts/MyApplication.kt → app/src/main/java/com/nextcloud/talk/contacts/ContactsApplication.kt

@@ -13,18 +13,19 @@ import coil.ImageLoaderFactory
 import coil.disk.DiskCache
 import coil.memory.MemoryCache
 import coil.util.DebugLogger
+import com.nextcloud.talk.utils.ContactUtils
 
-class MyApplication : Application(), ImageLoaderFactory {
+class ContactsApplication : Application(), ImageLoaderFactory {
     override fun newImageLoader(): ImageLoader {
         val imageLoader = ImageLoader.Builder(this)
             .memoryCache {
                 MemoryCache.Builder(this)
-                    .maxSizePercent(0.1)
+                    .maxSizePercent(ContactUtils.CACHE_MEMORY_SIZE_PERCENTAGE)
                     .build()
             }
             .diskCache {
                 DiskCache.Builder()
-                    .maxSizePercent(0.02)
+                    .maxSizePercent(ContactUtils.CACHE_DISK_SIZE_PERCENTAGE)
                     .directory(cacheDir)
                     .build()
             }

app/src/main/java/com/nextcloud/talk/utils/ContactUtils.kt

@@ -12,6 +12,8 @@ import android.provider.ContactsContract
 object ContactUtils {
 
     const val MAX_CONTACT_LIMIT = 50
+    const val CACHE_MEMORY_SIZE_PERCENTAGE = 0.1
+    const val CACHE_DISK_SIZE_PERCENTAGE = 0.02
 
     fun getDisplayNameFromDeviceContact(context: Context, id: String?): String? {
         var displayName: String? = null

app/src/test/java/com/nextcloud/talk/contacts/repository/FakeRepositoryError.kt

@@ -11,7 +11,7 @@ import com.nextcloud.talk.contacts.ContactsRepository
 import com.nextcloud.talk.models.json.autocomplete.AutocompleteOverall
 import com.nextcloud.talk.models.json.conversations.RoomOverall
 
-class FakeRepositoryError() : ContactsRepository {
+class FakeRepositoryError : ContactsRepository {
     override suspend fun getContacts(searchQuery: String?, shareTypes: List<String>): AutocompleteOverall {
         throw Exception("unable to fetch contacts")
     }

app/src/test/java/com/nextcloud/talk/contacts/repository/FakeRepositorySuccess.kt

@@ -12,7 +12,7 @@ import com.nextcloud.talk.contacts.apiService.FakeItem
 import com.nextcloud.talk.models.json.autocomplete.AutocompleteOverall
 import com.nextcloud.talk.models.json.conversations.RoomOverall
 
-class FakeRepositorySuccess() : ContactsRepository {
+class FakeRepositorySuccess : ContactsRepository {
     override suspend fun getContacts(searchQuery: String?, shareTypes: List<String>): AutocompleteOverall {
         return FakeItem.contactsOverall
     }