Merge pull request #1865 from nextcloud/bugfix/1861/search-bar-in-chat

Conversation view shows search bar when opened from notification

app/src/main/java/com/nextcloud/talk/activities/MainActivity.kt

@@ -349,7 +349,7 @@ class MainActivity : BaseActivity(), ActionBarProvider {
             } else {
                 remapChatController(
                     router!!, intent.getParcelableExtra<UserEntity>(KEY_USER_ENTITY)!!.id,
-                    intent.getStringExtra(KEY_ROOM_TOKEN)!!, intent.extras!!, false
+                    intent.getStringExtra(KEY_ROOM_TOKEN)!!, intent.extras!!, false, true
                 )
             }
         }

app/src/main/java/com/nextcloud/talk/utils/ConductorRemapping.kt

@@ -24,15 +24,28 @@ import android.os.Bundle
 import com.bluelinelabs.conductor.Router
 import com.bluelinelabs.conductor.RouterTransaction
 import com.bluelinelabs.conductor.changehandler.HorizontalChangeHandler
+import com.bluelinelabs.conductor.changehandler.SimpleSwapChangeHandler
 import com.nextcloud.talk.controllers.ChatController
 
 object ConductorRemapping {
+
     fun remapChatController(
         router: Router,
         internalUserId: Long,
         roomTokenOrId: String,
         bundle: Bundle,
         replaceTop: Boolean
+    ) {
+        remapChatController(router, internalUserId, roomTokenOrId, bundle, replaceTop, false)
+    }
+
+    fun remapChatController(
+        router: Router,
+        internalUserId: Long,
+        roomTokenOrId: String,
+        bundle: Bundle,
+        replaceTop: Boolean,
+        pushImmediately: Boolean
     ) {
         val tag = "$internalUserId@$roomTokenOrId"
         if (router.getControllerWithTag(tag) != null) {
@@ -49,16 +62,21 @@ object ConductorRemapping {
             backstack.add(routerTransaction)
             router.setBackstack(backstack, HorizontalChangeHandler())
         } else {
+            val pushChangeHandler = if (pushImmediately) {
+                SimpleSwapChangeHandler()
+            } else {
+                HorizontalChangeHandler()
+            }
             if (!replaceTop) {
                 router.pushController(
                     RouterTransaction.with(ChatController(bundle))
-                        .pushChangeHandler(HorizontalChangeHandler())
+                        .pushChangeHandler(pushChangeHandler)
                         .popChangeHandler(HorizontalChangeHandler()).tag(tag)
                 )
             } else {
                 router.replaceTopController(
                     RouterTransaction.with(ChatController(bundle))
-                        .pushChangeHandler(HorizontalChangeHandler())
+                        .pushChangeHandler(pushChangeHandler)
                         .popChangeHandler(HorizontalChangeHandler()).tag(tag)
                 )
             }

detekt.yml

@@ -1,5 +1,5 @@
 build:
-  maxIssues: 149
+  maxIssues: 150
   weights:
     # complexity: 2
     # LongParameterList: 1