Prechádzať zdrojové kódy

Avoid to fetchSignalingSettings in onMicrophoneClick

this led to duplicated call of fetchSignalingSettings.
because it's already called from checkDevicePermissions().
From my pov it shouldn't be triggered in onMicrophoneClick() again, at least i can not think of any scenario and while testing everything worked as expected.

The duplicated call was there since ever(?), but after implementing #3216 this also caused the call duration timer to be run twice.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Marcel Hibbe 1 rok pred
rodič
commit
75c154acf3

+ 0 - 3
app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt

@@ -1050,9 +1050,6 @@ class CallActivity : CallBaseActivity() {
             binding!!.microphoneButton.setImageResource(R.drawable.ic_mic_off_white_24px)
             toggleMedia(false, false)
         }
-        if (isVoiceOnlyCall && !isConnectionEstablished) {
-            fetchSignalingSettings()
-        }
         if (!canPublishAudioStream) {
             // In the case no audio stream will be published it's not needed to check microphone permissions
             return