Forráskód Böngészése

Resolve FindBugs Collection Naming Confusion

From the FindBugs documentation:

> CNC_COLLECTION_NAMING_CONFUSION: Collection variable is named with a different
> type of collection in the name
>
> This class defines a field or local collection variable with a name that
> contains a different type of collection in its name. An example would be a Set
> called userList. This is confusing to the reader, and likely caused by a
> previous refactor of type, without changing the name. This detector is
> obviously only checking for English names.

Signed-off-by: Tim Krüger <t@timkrueger.me>
Tim Krüger 3 éve
szülő
commit
85785c287e

+ 26 - 26
app/src/main/java/com/nextcloud/talk/components/filebrowser/webdav/DavUtils.java

@@ -68,32 +68,32 @@ public class DavUtils {
     public static final String PROPERTY_QUOTA_AVAILABLE_BYTES = "quota-available-bytes";
 
     static Property.Name[] getAllPropSet() {
-        List<Property.Name> propSet = new ArrayList<>();
-
-        propSet.add(DisplayName.NAME);
-        propSet.add(GetContentType.NAME);
-        propSet.add(GetContentLength.NAME);
-        propSet.add(GetContentType.NAME);
-        propSet.add(GetContentLength.NAME);
-        propSet.add(GetLastModified.NAME);
-        propSet.add(CreationDate.NAME);
-        propSet.add(GetETag.NAME);
-        propSet.add(ResourceType.NAME);
-
-        propSet.add(NCPermission.NAME);
-        propSet.add(OCId.NAME);
-        propSet.add(OCSize.NAME);
-        propSet.add(OCFavorite.NAME);
-        propSet.add(new Property.Name(OC_NAMESPACE, EXTENDED_PROPERTY_OWNER_ID));
-        propSet.add(new Property.Name(OC_NAMESPACE, EXTENDED_PROPERTY_OWNER_DISPLAY_NAME));
-        propSet.add(new Property.Name(OC_NAMESPACE, EXTENDED_PROPERTY_UNREAD_COMMENTS));
-
-        propSet.add(NCEncrypted.NAME);
-        propSet.add(new Property.Name(NC_NAMESPACE, EXTENDED_PROPERTY_MOUNT_TYPE));
-        propSet.add(NCPreview.NAME);
-        propSet.add(new Property.Name(NC_NAMESPACE, EXTENDED_PROPERTY_NOTE));
-
-        return propSet.toArray(new Property.Name[0]);
+        List<Property.Name> props = new ArrayList<>();
+
+        props.add(DisplayName.NAME);
+        props.add(GetContentType.NAME);
+        props.add(GetContentLength.NAME);
+        props.add(GetContentType.NAME);
+        props.add(GetContentLength.NAME);
+        props.add(GetLastModified.NAME);
+        props.add(CreationDate.NAME);
+        props.add(GetETag.NAME);
+        props.add(ResourceType.NAME);
+
+        props.add(NCPermission.NAME);
+        props.add(OCId.NAME);
+        props.add(OCSize.NAME);
+        props.add(OCFavorite.NAME);
+        props.add(new Property.Name(OC_NAMESPACE, EXTENDED_PROPERTY_OWNER_ID));
+        props.add(new Property.Name(OC_NAMESPACE, EXTENDED_PROPERTY_OWNER_DISPLAY_NAME));
+        props.add(new Property.Name(OC_NAMESPACE, EXTENDED_PROPERTY_UNREAD_COMMENTS));
+
+        props.add(NCEncrypted.NAME);
+        props.add(new Property.Name(NC_NAMESPACE, EXTENDED_PROPERTY_MOUNT_TYPE));
+        props.add(NCPreview.NAME);
+        props.add(new Property.Name(NC_NAMESPACE, EXTENDED_PROPERTY_NOTE));
+
+        return props.toArray(new Property.Name[0]);
     }
 
     public static void registerCustomFactories() {