Pārlūkot izejas kodu

Spotbugs: don't doubleCheck Map contains value, just check for null

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Andy Scherzinger 2 gadi atpakaļ
vecāks
revīzija
9ae722659f

+ 6 - 4
app/src/main/java/com/nextcloud/talk/webrtc/WebSocketConnectionHelper.java

@@ -60,11 +60,13 @@ public class WebSocketConnectionHelper {
 
     @SuppressLint("LongLogTag")
     public static synchronized MagicWebSocketInstance getMagicWebSocketInstanceForUserId(long userId) {
-        if (userId != -1 && magicWebSocketInstanceMap.containsKey(userId)) {
-            return magicWebSocketInstanceMap.get(userId);
+        MagicWebSocketInstance webSocketInstance = magicWebSocketInstanceMap.get(userId);
+
+        if (webSocketInstance == null) {
+            Log.d(TAG, "No magicWebSocketInstance found for user " + userId);
         }
-        Log.d(TAG, "no magicWebSocketInstance found");
-        return null;
+
+        return webSocketInstance;
     }
 
     public static synchronized MagicWebSocketInstance getExternalSignalingInstanceForServer(String url,