Browse Source

Use comparison operator rather than equals for enums in Dagger modules

Fixes SPP_EQUALS_ON_ENUM issue from SpotBugs.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Daniel Calviño Sánchez 2 years ago
parent
commit
9e967bdd4d

+ 1 - 1
app/src/main/java/com/nextcloud/talk/dagger/modules/RestModule.java

@@ -299,7 +299,7 @@ public class RestModule {
 
 
         @Override
         @Override
         public void run() {
         public void run() {
-            if (Proxy.Type.SOCKS.equals(Proxy.Type.valueOf(appPreferences.getProxyType()))) {
+            if (Proxy.Type.valueOf(appPreferences.getProxyType()) == Proxy.Type.SOCKS) {
                 proxy = new Proxy(Proxy.Type.valueOf(appPreferences.getProxyType()),
                 proxy = new Proxy(Proxy.Type.valueOf(appPreferences.getProxyType()),
                         InetSocketAddress.createUnresolved(appPreferences.getProxyHost(), Integer.parseInt(
                         InetSocketAddress.createUnresolved(appPreferences.getProxyHost(), Integer.parseInt(
                                 appPreferences.getProxyPort())));
                                 appPreferences.getProxyPort())));