Эх сурвалжийг харах

add disposable

however i was not able to see onDestroy being executed.

anyway, disposables won't be necessary when coroutine is used.

also: remove a useless outdated log line

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Marcel Hibbe 5 сар өмнө
parent
commit
acd964869d

+ 2 - 2
app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt

@@ -2448,7 +2448,7 @@ class ChatActivity :
         currentlyPlayedVoiceMessage?.let { stopMediaPlayer(it) } // FIXME, mediaplayer can sometimes be null here
 
         adapter = null
-        Log.d(TAG, "inConversation was set to false!")
+        disposables.dispose()
     }
 
     private fun joinRoomWithPassword() {
@@ -2513,7 +2513,7 @@ class ChatActivity :
                 ?.observeOn(AndroidSchedulers.mainThread())
                 ?.subscribe(object : Observer<SignalingSettingsOverall> {
                     override fun onSubscribe(d: Disposable) {
-                        // unused atm
+                        disposables.add(d)
                     }
 
                     override fun onNext(signalingSettingsOverall: SignalingSettingsOverall) {