Pārlūkot izejas kodu

Merge pull request #2573 from nextcloud/fix-string-comparison-using-operator-rather-than-equals

Fix String comparison using operator rather than "equals()"
Andy Scherzinger 2 gadi atpakaļ
vecāks
revīzija
b328e68c7a

+ 2 - 2
app/src/main/java/com/nextcloud/talk/activities/CallActivity.java

@@ -2167,7 +2167,7 @@ public class CallActivity extends CallBaseActivity {
 
 
         if (peerConnectionEvent.getPeerConnectionEventType() ==
         if (peerConnectionEvent.getPeerConnectionEventType() ==
             PeerConnectionEvent.PeerConnectionEventType.PEER_CONNECTED) {
             PeerConnectionEvent.PeerConnectionEventType.PEER_CONNECTED) {
-            if (webSocketClient != null && webSocketClient.getSessionId() == sessionId) {
+            if (webSocketClient != null && webSocketClient.getSessionId() != null && webSocketClient.getSessionId().equals(sessionId)) {
                 updateSelfVideoViewConnected(true);
                 updateSelfVideoViewConnected(true);
             } else if (participantDisplayItems.get(sessionId) != null) {
             } else if (participantDisplayItems.get(sessionId) != null) {
                 participantDisplayItems.get(sessionId).setConnected(true);
                 participantDisplayItems.get(sessionId).setConnected(true);
@@ -2175,7 +2175,7 @@ public class CallActivity extends CallBaseActivity {
             }
             }
         } else if (peerConnectionEvent.getPeerConnectionEventType() ==
         } else if (peerConnectionEvent.getPeerConnectionEventType() ==
             PeerConnectionEvent.PeerConnectionEventType.PEER_DISCONNECTED) {
             PeerConnectionEvent.PeerConnectionEventType.PEER_DISCONNECTED) {
-            if (webSocketClient != null && webSocketClient.getSessionId() == sessionId) {
+            if (webSocketClient != null && webSocketClient.getSessionId() != null && webSocketClient.getSessionId().equals(sessionId)) {
                 updateSelfVideoViewConnected(false);
                 updateSelfVideoViewConnected(false);
             } else if (participantDisplayItems.get(sessionId) != null) {
             } else if (participantDisplayItems.get(sessionId) != null) {
                 participantDisplayItems.get(sessionId).setConnected(false);
                 participantDisplayItems.get(sessionId).setConnected(false);