Эх сурвалжийг харах

check if location of cached file makes sense

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Marcel Hibbe 2 жил өмнө
parent
commit
bd23edc9a5

+ 3 - 1
app/src/main/java/com/nextcloud/talk/jobs/UploadAndShareFilesWorker.kt

@@ -126,7 +126,9 @@ class UploadAndShareFilesWorker(val context: Context, workerParameters: WorkerPa
 
             initNotificationSetup()
 
-            if (file != null && file.length() > CHUNK_UPLOAD_THRESHOLD_SIZE) {
+            if (file == null) {
+                uploadSuccess = false
+            } else if (file.length() > CHUNK_UPLOAD_THRESHOLD_SIZE) {
                 Log.d(TAG, "starting chunked upload because size is " + file.length())
 
                 initNotificationWithPercentage()

+ 7 - 1
app/src/main/java/com/nextcloud/talk/utils/FileUtils.kt

@@ -112,9 +112,15 @@ object FileUtils {
     }
 
     @Suppress("NestedBlockDepth")
-    fun copyFileToCache(context: Context, sourceFileUri: Uri, filename: String): File {
+    fun copyFileToCache(context: Context, sourceFileUri: Uri, filename: String): File? {
         val cachedFile = File(context.cacheDir, filename)
 
+        if (!cachedFile.canonicalPath.startsWith(context.cacheDir.canonicalPath, true)) {
+            Log.w(TAG, "cachedFile was not created in cacheDir. Aborting for security reasons.")
+            cachedFile.delete()
+            return null
+        }
+
         if (cachedFile.exists()) {
             Log.d(TAG, "file is already in cache")
         } else {