Explorar o código

Fix some lint issues

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Álvaro Brey %!s(int64=2) %!d(string=hai) anos
pai
achega
c10c45630c

+ 1 - 2
app/src/main/AndroidManifest.xml

@@ -174,8 +174,7 @@
 
         <activity
             android:name=".messagesearch.MessageSearchActivity"
-            android:theme="@style/AppTheme"
-            android:exported="false" />
+            android:theme="@style/AppTheme" />
 
         <receiver android:name=".receivers.PackageReplacedReceiver">
             <intent-filter>

+ 3 - 3
app/src/main/java/com/nextcloud/talk/messagesearch/MessageSearchActivity.kt

@@ -193,14 +193,14 @@ class MessageSearchActivity : BaseActivity() {
     private fun showInitial() {
         displayLoading(false)
         binding.messageSearchRecycler.visibility = View.GONE
-        binding.emptyContainer.emptyListViewHeadline.text = "Start typing to search..."
+        binding.emptyContainer.emptyListViewHeadline.text = getString(R.string.message_search_begin_typing)
         binding.emptyContainer.emptyListView.visibility = View.VISIBLE
     }
 
     private fun showEmpty() {
         displayLoading(false)
         binding.messageSearchRecycler.visibility = View.GONE
-        binding.emptyContainer.emptyListViewHeadline.text = "No search results"
+        binding.emptyContainer.emptyListViewHeadline.text = getString(R.string.message_search_begin_empty)
         binding.emptyContainer.emptyListView.visibility = View.VISIBLE
     }
 
@@ -229,7 +229,7 @@ class MessageSearchActivity : BaseActivity() {
     }
 
     private fun setupSearchView() {
-        searchView.queryHint = getString(R.string.nc_search_hint)
+        searchView.queryHint = getString(R.string.message_search_hint)
         searchViewDisposable = observeSearchView(searchView)
             .debounce { query ->
                 when {

+ 1 - 0
app/src/main/res/layout/activity_message_search.xml

@@ -24,6 +24,7 @@
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:background="@color/bg_default"
+    tools:ignore="Overdraw"
     tools:context=".messagesearch.MessageSearchActivity">
 
     <com.google.android.material.appbar.AppBarLayout

+ 7 - 3
app/src/main/res/values/strings.xml

@@ -518,13 +518,17 @@
     <string name="shared_items_voice">Voice</string>
     <string name="shared_items_other">Other</string>
 
+    <!-- Message search -->
+    <string name="messages">Messages</string>
+    <string name="load_more_results">Load more results</string>
+    <string name="message_search_hint">Search…</string>
+    <string name="message_search_begin_typing">Start typing to search…</string>
+    <string name="message_search_begin_empty">No search results</string>
+
     <string name="title_attachments">Attachments</string>
 
     <string name="reactions_tab_all">All</string>
     <string name="send_without_notification">Send without notification</string>
     <string name="call_without_notification">Call without notification</string>
-    <string name="messages">Messages</string>
-    <string name="load_more_results">Load more results</string>
-    <string name="nc_search_hint">Search…</string>
 
 </resources>