Browse Source

raise sizes to minimal hit-area of 48dp and tint icons at 60%/87% alpha (like active/inactive states)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Andy Scherzinger 4 years ago
parent
commit
f118cc7dd3

+ 2 - 2
app/src/main/java/com/nextcloud/talk/controllers/ProfileController.java

@@ -809,7 +809,7 @@ public class ProfileController extends BaseController {
                             this,
                             this,
                             item.field,
                             item.field,
                             holder.getAdapterPosition()).show());
                             holder.getAdapterPosition()).show());
-                    holder.scope.setAlpha(1.0f);
+                    holder.scope.setAlpha(0.87f); // active - high emphasis
                 } else {
                 } else {
                     holder.text.setEnabled(false);
                     holder.text.setEnabled(false);
                     holder.text.setFocusableInTouchMode(false);
                     holder.text.setFocusableInTouchMode(false);
@@ -817,7 +817,7 @@ public class ProfileController extends BaseController {
                     holder.text.setCursorVisible(false);
                     holder.text.setCursorVisible(false);
                     holder.text.setBackgroundTintList(ColorStateList.valueOf(Color.TRANSPARENT));
                     holder.text.setBackgroundTintList(ColorStateList.valueOf(Color.TRANSPARENT));
                     holder.scope.setOnClickListener(null);
                     holder.scope.setOnClickListener(null);
-                    holder.scope.setAlpha(0.4f);
+                    holder.scope.setAlpha(0.6f); // incative - medium emphasis
                 }
                 }
             } else {
             } else {
                 holder.container.setVisibility(View.GONE);
                 holder.container.setVisibility(View.GONE);

+ 5 - 4
app/src/main/res/layout/user_info_details_table_item.xml

@@ -39,7 +39,7 @@
     <EditText
     <EditText
         android:id="@+id/user_info_edit_text"
         android:id="@+id/user_info_edit_text"
         android:layout_width="0dp"
         android:layout_width="0dp"
-        android:layout_height="wrap_content"
+        android:layout_height="48dp"
         android:layout_marginStart="@dimen/standard_double_margin"
         android:layout_marginStart="@dimen/standard_double_margin"
         android:layout_marginEnd="@dimen/standard_margin"
         android:layout_marginEnd="@dimen/standard_margin"
         android:autofillHints="none"
         android:autofillHints="none"
@@ -56,9 +56,10 @@
 
 
     <ImageView
     <ImageView
         android:id="@+id/scope"
         android:id="@+id/scope"
-        android:layout_width="@dimen/iconized_single_line_item_icon_size"
-        android:layout_height="@dimen/iconized_single_line_item_icon_size"
-        android:layout_marginEnd="@dimen/standard_margin"
+        android:layout_width="48dp"
+        android:layout_height="48dp"
+        android:padding="12dp"
+        android:layout_marginEnd="4dp"
         android:contentDescription="@string/scope_toggle"
         android:contentDescription="@string/scope_toggle"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintEnd_toEndOf="parent"