Merge pull request #9104 from nextcloud/exportFalse

Explicitly specify exported="true/false" for all

scripts/analysis/lint-results.txt

@@ -1,2 +1,2 @@
 DO NOT TOUCH; GENERATED BY DRONE
-      <span class="mdl-layout-title">Lint Report: 1 error and 117 warnings</span>
+      <span class="mdl-layout-title">Lint Report: 1 error and 112 warnings</span>

src/main/AndroidManifest.xml

@@ -1,5 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!--
+<?xml version="1.0" encoding="utf-8"?><!--
   Nextcloud Android client application
 
   Copyright (C) 2012  Bartek Przybylski
@@ -29,25 +28,23 @@
         owned by the app, our use case.
         See note in http://developer.android.com/intl/es/reference/android/Manifest.permission.html#GET_ACCOUNTS -->
     <uses-permission
-        android:maxSdkVersion="22"
-        android:name="android.permission.GET_ACCOUNTS" />
+        android:name="android.permission.GET_ACCOUNTS"
+        android:maxSdkVersion="22" />
 
-    <uses-permission
-        android:name="android.permission.READ_CONTACTS" />
-    <uses-permission
-        android:name="android.permission.WRITE_CONTACTS" />
+    <uses-permission android:name="android.permission.READ_CONTACTS" />
+    <uses-permission android:name="android.permission.WRITE_CONTACTS" />
 
     <!-- USE_CREDENTIALS, MANAGE_ACCOUNTS and AUTHENTICATE_ACCOUNTS are needed for API <= 22.
         In API >= 23 they do not exist anymore -->
     <uses-permission
-        android:maxSdkVersion="22"
-        android:name="android.permission.USE_CREDENTIALS" />
+        android:name="android.permission.USE_CREDENTIALS"
+        android:maxSdkVersion="22" />
     <uses-permission
-        android:maxSdkVersion="22"
-        android:name="android.permission.MANAGE_ACCOUNTS" />
+        android:name="android.permission.MANAGE_ACCOUNTS"
+        android:maxSdkVersion="22" />
     <uses-permission
-        android:maxSdkVersion="22"
-        android:name="android.permission.AUTHENTICATE_ACCOUNTS" />
+        android:name="android.permission.AUTHENTICATE_ACCOUNTS"
+        android:maxSdkVersion="22" />
 
     <!-- WRITE_EXTERNAL_STORAGE may be enabled or disabled by the user after installation in
         API >= 23; the app needs to handle this -->
@@ -69,7 +66,7 @@
 
     <!-- Apps that target Android 9 (API level 28) or higher and use foreground services
     must request the FOREGROUND_SERVICE permission -->
-    <uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>
+    <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
 
     <!-- Some Chromebooks don't support touch. Although not essential,
          it's a good idea to explicitly include this declaration. -->
@@ -83,17 +80,17 @@
 
     <application
         android:name=".MainApp"
+        android:fullBackupContent="@xml/backup_config"
         android:icon="@mipmap/ic_launcher"
-        android:roundIcon="@mipmap/ic_launcher"
+        android:installLocation="internalOnly"
         android:label="@string/app_name"
-        android:fullBackupContent="@xml/backup_config"
-        android:theme="@style/Theme.ownCloud.Toolbar"
+        android:manageSpaceActivity="com.owncloud.android.ui.activity.ManageSpaceActivity"
         android:networkSecurityConfig="@xml/network_security_config"
+        android:requestLegacyExternalStorage="true"
+        android:roundIcon="@mipmap/ic_launcher"
         android:supportsRtl="true"
-        android:installLocation="internalOnly"
-        android:manageSpaceActivity="com.owncloud.android.ui.activity.ManageSpaceActivity"
+        android:theme="@style/Theme.ownCloud.Toolbar"
         android:usesCleartextTraffic="true"
-        android:requestLegacyExternalStorage="true"
         tools:ignore="UnusedAttribute">
 
         <uses-library
@@ -102,9 +99,10 @@
 
         <activity
             android:name=".ui.activity.FileDisplayActivity"
-            android:launchMode="singleTop"
-            android:label="@string/app_name"
             android:configChanges="orientation|screenSize"
+            android:exported="true"
+            android:label="@string/app_name"
+            android:launchMode="singleTop"
             android:theme="@style/Theme.ownCloud.Launcher">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
@@ -116,8 +114,10 @@
             </intent-filter>
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
+
                 <category android:name="android.intent.category.DEFAULT" />
                 <category android:name="android.intent.category.BROWSABLE" />
+
                 <data android:scheme="http" />
                 <data android:scheme="https" />
                 <data android:host="*" />
@@ -126,34 +126,63 @@
                 <data android:pathPattern="/..*/..*/f/..*" />
                 <data android:pathPattern="/..*/..*/..*/f/..*" />
             </intent-filter>
-            <meta-data android:name="android.app.searchable"
-                android:resource="@xml/users_and_groups_searchable"/>
+
+            <meta-data
+                android:name="android.app.searchable"
+                android:resource="@xml/users_and_groups_searchable" />
         </activity>
-        <activity android:name=".ui.activity.ManageAccountsActivity" />
-        <activity android:name=".ui.activity.UserInfoActivity" />
-        <activity android:name=".ui.activity.NotificationsActivity"/>
-        <activity android:name=".ui.activity.CommunityActivity" />
-        <activity android:name=".ui.activities.ActivitiesActivity"
-            android:configChanges="orientation|screenSize|keyboardHidden" />
-        <activity android:name=".ui.activity.SyncedFoldersActivity"/>
-        <receiver android:name="com.nextcloud.client.jobs.MediaFoldersDetectionWork$NotificationReceiver" />
-        <receiver android:name="com.nextcloud.client.jobs.NotificationWork$NotificationReceiver" />
-        <activity android:name=".ui.activity.UploadFilesActivity" />
-        <activity android:name=".ui.activity.ExternalSiteWebView"
-                  android:configChanges="orientation|screenSize|keyboardHidden" />
+        <activity
+            android:name=".ui.activity.ManageAccountsActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.activity.UserInfoActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.activity.NotificationsActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.activity.CommunityActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.activities.ActivitiesActivity"
+            android:configChanges="orientation|screenSize|keyboardHidden"
+            android:exported="false" />
+        <activity
+            android:name=".ui.activity.SyncedFoldersActivity"
+            android:exported="false" />
+
+        <receiver
+            android:name="com.nextcloud.client.jobs.MediaFoldersDetectionWork$NotificationReceiver"
+            android:exported="false" />
+        <receiver
+            android:name="com.nextcloud.client.jobs.NotificationWork$NotificationReceiver"
+            android:exported="false" />
+
+        <activity
+            android:name=".ui.activity.UploadFilesActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.activity.ExternalSiteWebView"
+            android:configChanges="orientation|screenSize|keyboardHidden"
+            android:exported="false" />
         <activity
             android:name=".ui.activity.RichDocumentsEditorWebView"
-            android:configChanges="orientation|screenSize|keyboardHidden" />
+            android:configChanges="orientation|screenSize|keyboardHidden"
+            android:exported="false" />
         <activity
             android:name=".ui.activity.TextEditorWebView"
-            android:configChanges="orientation|screenSize|keyboardHidden"/>
-        <activity android:name=".ui.activity.ContactsPreferenceActivity"
-            android:launchMode="singleInstance"/>
-        <activity android:name=".ui.activity.ReceiveExternalFilesActivity"
-
-                  android:taskAffinity=""
-                  android:excludeFromRecents="true"
-                  android:theme="@style/Theme.ownCloud.NoActionBar">
+            android:configChanges="orientation|screenSize|keyboardHidden"
+            android:exported="false" />
+        <activity
+            android:name=".ui.activity.ContactsPreferenceActivity"
+            android:exported="false"
+            android:launchMode="singleInstance" />
+        <activity
+            android:name=".ui.activity.ReceiveExternalFilesActivity"
+            android:excludeFromRecents="true"
+            android:exported="true"
+            android:taskAffinity=""
+            android:theme="@style/Theme.ownCloud.NoActionBar">
             <intent-filter>
                 <action android:name="android.intent.action.SEND" />
                 <category android:name="android.intent.category.DEFAULT" />
@@ -167,20 +196,22 @@
         </activity>
         <activity
             android:name=".ui.activity.SettingsActivity"
-            android:theme="@style/Theme.ownCloud" >
-        </activity>
+            android:exported="false"
+            android:theme="@style/Theme.ownCloud" />
         <activity
             android:name=".ui.preview.PreviewImageActivity"
+            android:exported="false"
             android:theme="@style/Theme.ownCloud.Overlay" />
         <activity
             android:name=".ui.preview.PreviewVideoActivity"
+            android:exported="false"
             android:label="@string/app_name"
             android:theme="@style/Theme.ownCloud.Fullscreen" />
 
         <service
             android:name=".authentication.AccountAuthenticatorService"
-            android:exported="true" >
-            <intent-filter android:priority="100" >
+            android:exported="false">
+            <intent-filter android:priority="100">
                 <action android:name="android.accounts.AccountAuthenticator" />
             </intent-filter>
 
@@ -191,7 +222,7 @@
 
         <service
             android:name=".syncadapter.FileSyncService"
-            android:exported="true" >
+            android:exported="true">
             <intent-filter>
                 <action android:name="android.content.SyncAdapter" />
             </intent-filter>
@@ -252,10 +283,10 @@
         <provider
             android:name=".providers.DocumentsStorageProvider"
             android:authorities="@string/document_provider_authority"
+            android:enabled="true"
             android:exported="true"
             android:grantUriPermissions="true"
-            android:permission="android.permission.MANAGE_DOCUMENTS"
-            android:enabled="true">
+            android:permission="android.permission.MANAGE_DOCUMENTS">
             <intent-filter>
                 <action android:name="android.content.action.DOCUMENTS_PROVIDER" />
             </intent-filter>
@@ -265,8 +296,8 @@
         <provider
             android:name="androidx.core.content.FileProvider"
             android:authorities="@string/file_provider_authority"
-            android:grantUriPermissions="true"
-            android:exported="false">
+            android:exported="false"
+            android:grantUriPermissions="true">
             <meta-data
                 android:name="android.support.FILE_PROVIDER_PATHS"
                 android:resource="@xml/exposed_filepaths" />
@@ -275,10 +306,9 @@
         <provider
             android:name=".providers.DiskLruImageCacheFileProvider"
             android:authorities="@string/image_cache_provider_authority"
+            android:exported="true"
             android:grantUriPermissions="true"
-            android:readPermission="android.permission.MANAGE_DOCUMENTS"
-            android:exported="true">
-        </provider>
+            android:readPermission="android.permission.MANAGE_DOCUMENTS" />
 
         <!-- Disable WorkManager initialization. Whoever designed this, should pay closer attention -->
         <!-- to "best before" dates in his fridge. -->
@@ -290,9 +320,9 @@
 
         <activity
             android:name=".authentication.AuthenticatorActivity"
+            android:configChanges="orientation|screenSize|keyboardHidden"
             android:exported="true"
             android:launchMode="singleTask"
-            android:configChanges="orientation|screenSize|keyboardHidden"
             android:theme="@style/Theme.ownCloud.noActionBar.Login">
             <intent-filter>
                 <action android:name="com.owncloud.android.workaround.accounts.CREATE" />
@@ -303,10 +333,10 @@
 
         <activity
             android:name=".authentication.DeepLinkLoginActivity"
+            android:clearTaskOnLaunch="true"
             android:configChanges="orientation|screenSize|keyboardHidden"
             android:exported="true"
             android:launchMode="singleTask"
-            android:clearTaskOnLaunch="true"
             android:theme="@style/Theme.ownCloud.noActionBar.Login">
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
@@ -320,87 +350,117 @@
             </intent-filter>
         </activity>
 
-        <service android:name=".services.OperationsService" />
-        <service android:name=".files.services.FileDownloader" />
-        <service android:name="com.nextcloud.client.files.downloader.FileTransferService" />
-        <service android:name=".files.services.FileUploader" />
-        <service android:name="com.nextcloud.client.media.PlayerService"/>
+        <service
+            android:name=".services.OperationsService"
+            android:exported="false" />
+        <service
+            android:name=".files.services.FileDownloader"
+            android:exported="false" />
+        <service
+            android:name="com.nextcloud.client.files.downloader.FileTransferService"
+            android:exported="false" />
+        <service
+            android:name=".files.services.FileUploader"
+            android:exported="false" />
+        <service
+            android:name="com.nextcloud.client.media.PlayerService"
+            android:exported="false" />
 
         <activity
             android:name=".ui.activity.PassCodeActivity"
+            android:exported="false"
             android:launchMode="singleTask" />
         <activity
             android:name=".ui.activity.RequestCredentialsActivity"
+            android:exported="false"
             android:launchMode="singleTask" />
-        <activity android:name=".ui.activity.ConflictsResolveActivity"/>
-        <activity android:name=".ui.activity.ErrorsWhileCopyingHandlerActivity"/>
+        <activity
+            android:name=".ui.activity.ConflictsResolveActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.activity.ErrorsWhileCopyingHandlerActivity"
+            android:exported="false" />
 
-        <activity android:name="com.nextcloud.client.logger.ui.LogsActivity" />
+        <activity
+            android:name="com.nextcloud.client.logger.ui.LogsActivity"
+            android:exported="false" />
 
-        <activity android:name="com.nextcloud.client.errorhandling.ShowErrorActivity"
-            android:theme="@style/Theme.ownCloud.Toolbar"
-            android:process=":crash"
+        <activity
+            android:name="com.nextcloud.client.errorhandling.ShowErrorActivity"
             android:excludeFromRecents="true"
+            android:exported="false"
             android:finishOnTaskLaunch="true"
-            android:launchMode="singleInstance" />
-        <activity android:name=".ui.activity.UploadListActivity" />
+            android:launchMode="singleInstance"
+            android:process=":crash"
+            android:theme="@style/Theme.ownCloud.Toolbar" />
+        <activity
+            android:name=".ui.activity.UploadListActivity"
+            android:exported="false" />
         <activity
             android:name=".ui.trashbin.TrashbinActivity"
-            android:exported="true"
-            android:configChanges="orientation|screenSize|keyboardHidden"/>
-        <activity android:name="com.nextcloud.client.onboarding.WhatsNewActivity"
-                  android:theme="@style/Theme.ownCloud.noActionBar.Login" />
+            android:configChanges="orientation|screenSize|keyboardHidden"
+            android:exported="true" />
+        <activity
+            android:name="com.nextcloud.client.onboarding.WhatsNewActivity"
+            android:theme="@style/Theme.ownCloud.noActionBar.Login" />
         <activity
             android:name="com.nextcloud.client.onboarding.FirstRunActivity"
-            android:theme="@style/Theme.ownCloud.noActionBar.Login"
-            android:configChanges="orientation|screenSize"/>
+            android:configChanges="orientation|screenSize"
+            android:exported="false"
+            android:theme="@style/Theme.ownCloud.noActionBar.Login" />
 
-        <receiver android:name=".files.BootupBroadcastReceiver" >
+        <receiver
+            android:name=".files.BootupBroadcastReceiver"
+            android:exported="true">
             <intent-filter>
                 <action android:name="android.intent.action.BOOT_COMPLETED" />
-                <action android:name="android.intent.action.QUICKBOOT_POWERON"/>
-                <action android:name="com.htc.intent.action.QUICKBOOT_POWERON"/>
-                <action android:name="android.intent.action.MY_PACKAGE_REPLACED"/>
+                <action android:name="android.intent.action.QUICKBOOT_POWERON" />
+                <action android:name="com.htc.intent.action.QUICKBOOT_POWERON" />
+                <action android:name="android.intent.action.MY_PACKAGE_REPLACED" />
             </intent-filter>
         </receiver>
 
-
         <activity
             android:name=".ui.activity.CopyToClipboardActivity"
+            android:exported="false"
             android:icon="@drawable/shared_via_link"
             android:label="@string/copy_link" />
         <activity
             android:name=".ui.activity.FolderPickerActivity"
+            android:exported="false"
             android:label="@string/app_name" />
         <activity
             android:name=".ui.activity.FilePickerActivity"
+            android:exported="false"
             android:label="@string/app_name"
-            android:theme="@style/Theme.ownCloud.Dialog.NoTitle"
             android:launchMode="singleTop"
-            android:windowSoftInputMode="adjustResize"/>
+            android:theme="@style/Theme.ownCloud.Dialog.NoTitle"
+            android:windowSoftInputMode="adjustResize" />
         <activity
             android:name=".ui.activity.ShareActivity"
-            android:label="@string/share_dialog_title"
             android:exported="false"
-            android:theme="@style/Theme.ownCloud.Dialog.NoTitle"
+            android:label="@string/share_dialog_title"
             android:launchMode="singleTop"
-            android:windowSoftInputMode="adjustResize" >
+            android:theme="@style/Theme.ownCloud.Dialog.NoTitle"
+            android:windowSoftInputMode="adjustResize">
             <intent-filter>
                 <action android:name="android.intent.action.SEARCH" />
             </intent-filter>
-            <meta-data android:name="android.app.searchable"
-                       android:resource="@xml/users_and_groups_searchable"/>
+            <meta-data
+                android:name="android.app.searchable"
+                android:resource="@xml/users_and_groups_searchable" />
         </activity>
-        <activity android:name=".ui.activity.ManageSpaceActivity"
-                  android:label="@string/manage_space_title"
-                  android:theme="@style/Theme.ownCloud" />
+        <activity
+            android:name=".ui.activity.ManageSpaceActivity"
+            android:exported="false"
+            android:label="@string/manage_space_title"
+            android:theme="@style/Theme.ownCloud" />
 
 
         <service
             android:name=".services.AccountManagerService"
             android:enabled="true"
-            android:exported="true" >
-        </service>
+            android:exported="false" />
 
         <activity
             android:name=".ui.activity.SsoGrantPermissionActivity"
@@ -409,6 +469,7 @@
 
         <activity
             android:name="com.nextcloud.client.etm.EtmActivity"
+            android:exported="false"
             android:theme="@style/Theme.ownCloud.Toolbar" />
     </application>