Browse Source

feat(download): Show specific error if download fails due to local file creation failure

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Álvaro Brey 2 years ago
parent
commit
0445eb3768

+ 1 - 0
app/src/main/java/com/owncloud/android/files/services/FileDownloader.java

@@ -54,6 +54,7 @@ import com.owncloud.android.lib.common.network.OnDatatransferProgressListener;
 import com.owncloud.android.lib.common.operations.RemoteOperationResult;
 import com.owncloud.android.lib.common.operations.RemoteOperationResult.ResultCode;
 import com.owncloud.android.lib.common.utils.Log_OC;
+import com.owncloud.android.lib.resources.files.CreateLocalFileException;
 import com.owncloud.android.lib.resources.files.FileUtils;
 import com.owncloud.android.operations.DownloadFileOperation;
 import com.owncloud.android.operations.DownloadType;

+ 2 - 1
app/src/main/java/com/owncloud/android/utils/ErrorMessageAdapter.java

@@ -326,7 +326,8 @@ public final class ErrorMessageAdapter {
         } else {
             if (result.getCode() == ResultCode.FILE_NOT_FOUND) {
                 return res.getString(R.string.downloader_download_file_not_found);
-
+            } else if (result.getCode() == ResultCode.CANNOT_CREATE_FILE) {
+                return res.getString(R.string.download_cannot_create_file);
             }
         }
         return null;

+ 1 - 0
app/src/main/res/values/strings.xml

@@ -1075,4 +1075,5 @@
     <string name="document_scan_export_dialog_title">Choose export type</string>
     <string name="document_scan_export_dialog_pdf">PDF file</string>
     <string name="document_scan_export_dialog_images">Multiple images</string>
+    <string name="download_cannot_create_file">Cannot create local file</string>
 </resources>

+ 1 - 1
build.gradle

@@ -8,7 +8,7 @@ buildscript {
         daggerVersion = "2.45"
         markwonVersion = "4.6.2"
         prismVersion = "2.0.0"
-        androidLibraryVersion = "master-SNAPSHOT"
+        androidLibraryVersion = "invalid-path-download-SNAPSHOT"
         mockitoVersion = "4.11.0"
         mockitoKotlinVersion = "4.1.0"
         mockkVersion = "1.13.3"