Fix magic numbers in ssl_validator_layout.xml #12

res/layout/ssl_validator_layout.xml

@@ -39,7 +39,7 @@
 		android:layout_width="wrap_content"
 		android:layout_height="wrap_content"
 		android:layout_gravity="left"
-		android:paddingLeft="8dp"
+		android:paddingLeft="@dimen/standard_half_padding"
 		android:text="@string/ssl_validator_reason_cert_not_trusted"
 		android:textAppearance="?android:attr/textAppearanceSmall"
 		 />
@@ -49,7 +49,7 @@
 		android:layout_width="wrap_content"
 		android:layout_height="wrap_content"
 		android:layout_gravity="left"
-		android:paddingLeft="8dp"
+		android:paddingLeft="@dimen/standard_half_padding"
 		android:text="@string/ssl_validator_reason_cert_expired"
 		android:textAppearance="?android:attr/textAppearanceSmall"
 		 />
@@ -59,7 +59,7 @@
 		android:layout_width="wrap_content"
 		android:layout_height="wrap_content"
 		android:layout_gravity="left"
-		android:paddingLeft="8dp"
+		android:paddingLeft="@dimen/standard_half_padding"
 		android:text="@string/ssl_validator_reason_cert_not_yet_valid"
 		android:textAppearance="?android:attr/textAppearanceSmall"
 		 />
@@ -69,7 +69,7 @@
 		android:layout_width="wrap_content"
 		android:layout_height="wrap_content"
 		android:layout_gravity="left"
-		android:paddingLeft="8dp"
+		android:paddingLeft="@dimen/standard_half_padding"
 		android:text="@string/ssl_validator_reason_hostname_not_verified"
 		android:textAppearance="?android:attr/textAppearanceSmall"
 		 />
@@ -77,9 +77,9 @@
     <ScrollView 
         android:id="@+id/details_scroll"
         android:visibility="gone" 
-    	android:padding="8dp"
+    	android:padding="@dimen/standard_half_padding"
         android:layout_width="wrap_content"
-        android:layout_height="180dp">
+        android:layout_height="@dimen/scroll_view_height">
         
 		<LinearLayout
     		android:id="@+id/details_view"
@@ -92,7 +92,7 @@
         			android:id="@+id/label_subject"
         			android:layout_width="wrap_content"
         			android:layout_height="wrap_content"
-					android:paddingBottom="5dp"
+					android:paddingBottom="@dimen/alternate_half_padding"
         			android:text="@string/ssl_validator_label_subject"
         			android:textAppearance="?android:attr/textAppearanceMedium"
         		/>
@@ -109,7 +109,7 @@
 				    android:id="@+id/value_subject_CN"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -126,7 +126,7 @@
 				    android:id="@+id/value_subject_O"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -143,7 +143,7 @@
 				    android:id="@+id/value_subject_OU"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -160,7 +160,7 @@
 				    android:id="@+id/value_subject_ST"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -177,7 +177,7 @@
 				    android:id="@+id/value_subject_C"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -194,7 +194,7 @@
 				    android:id="@+id/value_subject_L"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -204,7 +204,7 @@
         			android:id="@+id/label_issuer"
         			android:layout_width="wrap_content"
         			android:layout_height="wrap_content"
-					android:paddingBottom="5dp"
+					android:paddingBottom="@dimen/alternate_half_padding"
         			android:text="@string/ssl_validator_label_issuer"
         			android:textAppearance="?android:attr/textAppearanceMedium"
         		/>
@@ -221,7 +221,7 @@
 				    android:id="@+id/value_issuer_CN"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -238,7 +238,7 @@
 				    android:id="@+id/value_issuer_O"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -255,7 +255,7 @@
 				    android:id="@+id/value_issuer_OU"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -272,7 +272,7 @@
 				    android:id="@+id/value_issuer_ST"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -289,7 +289,7 @@
 				    android:id="@+id/value_issuer_C"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -306,7 +306,7 @@
 				    android:id="@+id/value_issuer_L"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -315,7 +315,7 @@
         			android:id="@+id/label_validity"
         			android:layout_width="wrap_content"
         			android:layout_height="wrap_content"
-					android:paddingBottom="5dp"
+					android:paddingBottom="@dimen/alternate_half_padding"
         			android:text="@string/ssl_validator_label_validity"
         			android:textAppearance="?android:attr/textAppearanceMedium"
         		/>
@@ -332,7 +332,7 @@
 				    android:id="@+id/value_validity_from"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -349,7 +349,7 @@
 				    android:id="@+id/value_validity_to"
 				    android:layout_width="wrap_content"
 				    android:layout_height="wrap_content"
-				    android:paddingBottom="5dp"
+				    android:paddingBottom="@dimen/alternate_half_padding"
 				    android:text=""
 				    android:textAppearance="?android:attr/textAppearanceSmall"
 				/>
@@ -359,7 +359,7 @@
         			android:id="@+id/label_signature"
         			android:layout_width="wrap_content"
         			android:layout_height="wrap_content"
-					android:paddingBottom="5dp"
+					android:paddingBottom="@dimen/alternate_half_padding"
         			android:text="@string/ssl_validator_label_signature"
         			android:textAppearance="?android:attr/textAppearanceMedium"
         		/>
@@ -376,7 +376,7 @@
         			android:id="@+id/value_signature_algorithm"
         			android:layout_width="wrap_content"
         			android:layout_height="wrap_content"
-					android:paddingBottom="5dp"
+					android:paddingBottom="@dimen/alternate_half_padding"
         			android:text=""
         			android:textAppearance="?android:attr/textAppearanceSmall"
         		/>
@@ -386,7 +386,7 @@
         			android:id="@+id/value_signature"
         			android:layout_width="wrap_content"
         			android:layout_height="wrap_content"
-					android:paddingBottom="5dp"
+					android:paddingBottom="@dimen/alternate_half_padding"
         			android:text=""
         			android:textAppearance="?android:attr/textAppearanceSmall"
         		/>
@@ -413,7 +413,7 @@
 		<android.support.v7.widget.AppCompatButton
             android:id="@+id/cancel"
 			style="@style/Button.Borderless"
-            android:layout_width="0dp"
+            android:layout_width="@dimen/zero"
             android:layout_height="wrap_content"
             android:layout_weight="1"
             android:text="@string/common_no" />
@@ -421,7 +421,7 @@
 		<android.support.v7.widget.AppCompatButton
             android:id="@+id/details_btn"
 			style="@style/Button.Borderless"
-            android:layout_width="0dp"
+            android:layout_width="@dimen/zero"
             android:layout_height="wrap_content"
             android:layout_weight="2"
             android:text="@string/ssl_validator_btn_details_see" />
@@ -429,7 +429,7 @@
 		<android.support.v7.widget.AppCompatButton
             android:id="@+id/ok"
 			style="@style/Button.Borderless"
-            android:layout_width="0dp"
+            android:layout_width="@dimen/zero"
             android:layout_height="wrap_content"
             android:layout_weight="1"
             android:text="@string/common_yes" />

res/values/dims.xml

@@ -120,4 +120,6 @@
     <dimen name="simple_dialog_list_item_layout_size">48dp</dimen>
 
     <dimen name="ssl_untrusted_cert_layout_padding">20dp</dimen>
+
+    <dimen name="scroll_view_height">180dp</dimen>
 </resources>