according to codacy

src/main/java/com/owncloud/android/datamodel/ExternalLinksProvider.java

@@ -144,7 +144,7 @@ public class ExternalLinksProvider {
                     ProviderMeta.ProviderTableMeta.EXTERNAL_LINKS_ICON_URL));
             String language = cursor.getString(cursor.getColumnIndex(
                     ProviderMeta.ProviderTableMeta.EXTERNAL_LINKS_LANGUAGE));
-            ExternalLinkType type = ExternalLinkType.LINK;
+            ExternalLinkType type;
             switch (cursor.getString(cursor.getColumnIndex(
                     ProviderMeta.ProviderTableMeta.EXTERNAL_LINKS_TYPE))) {
                 case "link":
@@ -156,6 +156,9 @@ public class ExternalLinksProvider {
                 case "quota":
                     type = ExternalLinkType.QUOTA;
                     break;
+                default:
+                    type = ExternalLinkType.UNKNOWN;
+                    break;
             }
             String name = cursor.getString(cursor.getColumnIndex(
                     ProviderMeta.ProviderTableMeta.EXTERNAL_LINKS_NAME));

src/main/java/com/owncloud/android/ui/activity/ExternalSiteWebView.java

@@ -144,6 +144,8 @@ public class ExternalSiteWebView extends FileActivity {
                     startActivity(settingsIntent);
                 }
             }
+            retval = true;
+            break;
 
             default:
                 retval = super.onOptionsItemSelected(item);