فهرست منبع

codacy: consider simply returning the value vs storing it in local variable

AndyScherzinger 6 سال پیش
والد
کامیت
0ae679f3b5

+ 1 - 4
src/main/java/com/owncloud/android/datamodel/SyncedFolderProvider.java

@@ -249,14 +249,11 @@ public class SyncedFolderProvider extends Observable {
      *  @param account whose synced folders should be deleted
      */
     public int deleteSyncFoldersForAccount(Account account) {
-        int result = mContentResolver.delete(
+        return mContentResolver.delete(
                 ProviderMeta.ProviderTableMeta.CONTENT_URI_SYNCED_FOLDERS,
                 ProviderMeta.ProviderTableMeta.SYNCED_FOLDER_ACCOUNT + " = ?",
                 new String[]{String.valueOf(account.name)}
         );
-
-        return result;
-
     }
 
     /**

+ 1 - 2
src/main/java/com/owncloud/android/ui/activity/UserInfoActivity.java

@@ -487,8 +487,7 @@ public class UserInfoActivity extends FileActivity {
         public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
             LayoutInflater inflater = LayoutInflater.from(parent.getContext());
             View view = inflater.inflate(R.layout.user_info_details_table_item, parent, false);
-            ViewHolder holder = new ViewHolder(view);
-            return holder;
+            return new ViewHolder(view);
         }
 
         @Override