浏览代码

Fixing Codacy

alejandro 8 年之前
父节点
当前提交
28b8993f88

+ 1 - 2
src/main/java/com/owncloud/android/ui/activity/ActivitiesListActivity.java

@@ -19,7 +19,6 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-
 package com.owncloud.android.ui.activity;
 
 import android.accounts.Account;
@@ -105,7 +104,7 @@ public class ActivitiesListActivity extends FileActivity implements ActivityList
 
     private ActivityListAdapter adapter;
     private Unbinder unbinder;
-    private OwnCloudClient mClient;
+
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {

+ 11 - 16
src/main/java/com/owncloud/android/ui/adapter/RichObjectAdapter.java

@@ -32,7 +32,6 @@ import com.bumptech.glide.Glide;
 import com.owncloud.android.MainApp;
 import com.owncloud.android.R;
 import com.owncloud.android.datamodel.OCFile;
-import com.owncloud.android.lib.common.OwnCloudClient;
 import com.owncloud.android.lib.resources.activities.models.RichObject;
 import com.owncloud.android.ui.interfaces.ActivityListInterface;
 import com.owncloud.android.utils.MimeTypeUtil;
@@ -46,10 +45,8 @@ import java.util.ArrayList;
 
 public class RichObjectAdapter extends RecyclerView.Adapter<RichObjectAdapter.RichObjectViewHolder> {
 
-    private static final String TAG = RichObjectAdapter.class.getName();
     private final Context mContext;
     private final int px;
-    private OwnCloudClient mClient;
     private ArrayList<RichObject> mValues;
     private final ActivityListInterface mActivityListInterface;
     private Uri mBaseUri;
@@ -60,8 +57,6 @@ public class RichObjectAdapter extends RecyclerView.Adapter<RichObjectAdapter.Ri
         this.mValues = new ArrayList<>();
         this.mActivityListInterface = activityListInterface;
         px=getThumbnailDimension();
-
-
     }
 
 
@@ -125,17 +120,6 @@ public class RichObjectAdapter extends RecyclerView.Adapter<RichObjectAdapter.Ri
     }
 
 
-    static class RichObjectViewHolder extends RecyclerView.ViewHolder {
-
-        ImageView image;
-
-        RichObjectViewHolder(View v) {
-            super(v);
-            image = (ImageView) v.findViewById(R.id.image);
-        }
-
-    }
-
     /**
      * Converts size of file icon from dp to pixel
      * @return int
@@ -147,4 +131,15 @@ public class RichObjectAdapter extends RecyclerView.Adapter<RichObjectAdapter.Ri
         return d.intValue();
     }
 
+    static class RichObjectViewHolder extends RecyclerView.ViewHolder {
+
+        ImageView image;
+
+        RichObjectViewHolder(View v) {
+            super(v);
+            image = (ImageView) v.findViewById(R.id.image);
+        }
+
+    }
+
 }

+ 4 - 6
src/main/java/com/owncloud/android/utils/glide/HttpStreamFetcher.java

@@ -43,8 +43,6 @@ import java.io.InputStream;
 public class HttpStreamFetcher implements DataFetcher<InputStream> {
 
     private static final String TAG = HttpStreamFetcher.class.getName();
-    private OwnCloudClient mClient = null;
-    private Account mAccount = null;
     private final String mURL;
 
     public HttpStreamFetcher(String url) {
@@ -55,10 +53,10 @@ public class HttpStreamFetcher implements DataFetcher<InputStream> {
     @Override
     public InputStream loadData(Priority priority) throws Exception {
 
-        this.mAccount = AccountUtils.getCurrentOwnCloudAccount(MainApp.getAppContext());
+        Account mAccount = AccountUtils.getCurrentOwnCloudAccount(MainApp.getAppContext());
         OwnCloudAccount ocAccount = new OwnCloudAccount(mAccount,
                 MainApp.getAppContext());
-        this.mClient = OwnCloudClientManagerFactory.getDefaultSingleton().
+        OwnCloudClient mClient = OwnCloudClientManagerFactory.getDefaultSingleton().
                 getClientFor(ocAccount, MainApp.getAppContext());
 
         OwnCloudVersion serverOCVersion = AccountUtils.getServerVersion(mAccount);
@@ -88,7 +86,7 @@ public class HttpStreamFetcher implements DataFetcher<InputStream> {
 
     @Override
     public void cleanup() {
-
+        Log_OC.i(TAG,"Cleanup");
     }
 
     @Override
@@ -98,6 +96,6 @@ public class HttpStreamFetcher implements DataFetcher<InputStream> {
 
     @Override
     public void cancel() {
-
+        Log_OC.i(TAG,"Cancel");
     }
 }