Explorar el Código

codacy: This call to Collection.toArray() may be optimizable

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Andy Scherzinger hace 6 años
padre
commit
39e113f251

+ 2 - 2
src/main/java/com/owncloud/android/datamodel/FileDataStorageManager.java

@@ -2140,10 +2140,10 @@ public class FileDataStorageManager {
     public void saveVirtuals(VirtualFolderType type, List<ContentValues> values) {
 
         if (getContentResolver() != null) {
-            getContentResolver().bulkInsert(ProviderTableMeta.CONTENT_URI_VIRTUAL, values.toArray(new ContentValues[values.size()]));
+            getContentResolver().bulkInsert(ProviderTableMeta.CONTENT_URI_VIRTUAL, values.toArray(new ContentValues[0]));
         } else {
             try {
-                getContentProviderClient().bulkInsert(ProviderTableMeta.CONTENT_URI_VIRTUAL, values.toArray(new ContentValues[values.size()]));
+                getContentProviderClient().bulkInsert(ProviderTableMeta.CONTENT_URI_VIRTUAL, values.toArray(new ContentValues[0]));
             } catch (RemoteException e) {
                 Log_OC.e(TAG, FAILED_TO_INSERT_MSG + e.getMessage(), e);
             }

+ 2 - 2
src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java

@@ -62,7 +62,7 @@ public class DataStorageProvider {
 
     public StoragePoint[] getAvailableStoragePoints() {
         if (mCachedStoragePoints.size() != 0) {
-            return mCachedStoragePoints.toArray(new StoragePoint[mCachedStoragePoints.size()]);
+            return mCachedStoragePoints.toArray(new StoragePoint[0]);
         }
 
         List<String> paths = new ArrayList<>();
@@ -126,7 +126,7 @@ public class DataStorageProvider {
             }
         }
 
-        return mCachedStoragePoints.toArray(new StoragePoint[mCachedStoragePoints.size()]);
+        return mCachedStoragePoints.toArray(new StoragePoint[0]);
     }
 
     public String getStorageDescriptionByPath(String path) {

+ 1 - 1
src/main/java/com/owncloud/android/ui/adapter/LocalFileListAdapter.java

@@ -128,7 +128,7 @@ public class LocalFileListAdapter extends RecyclerView.Adapter<RecyclerView.View
 
         Log_OC.d(TAG, "Returning " + result.size() + " selected files");
 
-        return result.toArray(new String[result.size()]);
+        return result.toArray(new String[0]);
     }
 
     @Override

+ 2 - 2
src/main/java/com/owncloud/android/ui/helpers/UriUploader.java

@@ -121,8 +121,8 @@ public class UriUploader {
 
             if (!contentUris.isEmpty()) {
                 /// content: uris will be copied to temporary files before calling {@link FileUploader}
-                copyThenUpload(contentUris.toArray(new Uri[contentUris.size()]),
-                        contentRemotePaths.toArray(new String[contentRemotePaths.size()]));
+                copyThenUpload(contentUris.toArray(new Uri[0]),
+                        contentRemotePaths.toArray(new String[0]));
 
             } else if (schemeFileCounter == 0) {
                 mCode = UriUploaderResultCode.ERROR_NO_FILE_TO_UPLOAD;