improve findbugs scoring

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

src/main/java/com/owncloud/android/operations/CopyFileOperation.java

@@ -31,11 +31,8 @@ import com.owncloud.android.operations.common.SyncOperation;
  */
 public class CopyFileOperation extends SyncOperation {
 
-    //private static final String TAG = MoveFileOperation.class.getSimpleName();
-
-    private String mSrcPath;
-    private String mTargetParentPath;
-    private OCFile mFile;
+    private String srcPath;
+    private String targetParentPath;
 
     /**
      * Constructor
@@ -44,13 +41,11 @@ public class CopyFileOperation extends SyncOperation {
      * @param targetParentPath Path to the folder where the file will be copied into.
      */
     public CopyFileOperation(String srcPath, String targetParentPath) {
-        mSrcPath = srcPath;
-        mTargetParentPath = targetParentPath;
-        if (!mTargetParentPath.endsWith(OCFile.PATH_SEPARATOR)) {
-            mTargetParentPath += OCFile.PATH_SEPARATOR;
+        this.srcPath = srcPath;
+        this.targetParentPath = targetParentPath;
+        if (!this.targetParentPath.endsWith(OCFile.PATH_SEPARATOR)) {
+            this.targetParentPath += OCFile.PATH_SEPARATOR;
         }
-
-        mFile = null;
     }
 
     /**
@@ -61,24 +56,24 @@ public class CopyFileOperation extends SyncOperation {
     @Override
     protected RemoteOperationResult run(OwnCloudClient client) {
         /// 1. check copy validity
-        if (mTargetParentPath.startsWith(mSrcPath)) {
+        if (targetParentPath.startsWith(srcPath)) {
             return new RemoteOperationResult(ResultCode.INVALID_COPY_INTO_DESCENDANT);
         }
-        mFile = getStorageManager().getFileByPath(mSrcPath);
-        if (mFile == null) {
+        OCFile file = getStorageManager().getFileByPath(srcPath);
+        if (file == null) {
             return new RemoteOperationResult(ResultCode.FILE_NOT_FOUND);
         }
 
         /// 2. remote copy
-        String targetPath = mTargetParentPath + mFile.getFileName();
-        if (mFile.isFolder()) {
+        String targetPath = targetParentPath + file.getFileName();
+        if (file.isFolder()) {
             targetPath += OCFile.PATH_SEPARATOR;
         }
-        RemoteOperationResult result = new CopyFileRemoteOperation(mSrcPath, targetPath, false).execute(client);
+        RemoteOperationResult result = new CopyFileRemoteOperation(srcPath, targetPath, false).execute(client);
 
         /// 3. local copy
         if (result.isSuccess()) {
-            getStorageManager().copyLocalFile(mFile, targetPath);
+            getStorageManager().copyLocalFile(file, targetPath);
         }
         // TODO handle ResultCode.PARTIAL_COPY_DONE in client Activity, for the moment
 

src/main/java/com/owncloud/android/operations/MoveFileOperation.java

@@ -28,15 +28,12 @@ import com.owncloud.android.operations.common.SyncOperation;
 
 
 /**
- * Operation mmoving an {@link OCFile} to a different folder.
+ * Operation moving an {@link OCFile} to a different folder.
  */
 public class MoveFileOperation extends SyncOperation {
 
-    //private static final String TAG = MoveFileOperation.class.getSimpleName();
-
-    private String mSrcPath;
-    private String mTargetParentPath;
-    private OCFile mFile;
+    private String srcPath;
+    private String targetParentPath;
 
     /**
      * Constructor
@@ -45,13 +42,11 @@ public class MoveFileOperation extends SyncOperation {
      * @param targetParentPath  Path to the folder where the file will be moved into.
      */
     public MoveFileOperation(String srcPath, String targetParentPath) {
-        mSrcPath = srcPath;
-        mTargetParentPath = targetParentPath;
-        if (!mTargetParentPath.endsWith(OCFile.PATH_SEPARATOR)) {
-            mTargetParentPath += OCFile.PATH_SEPARATOR;
+        this.srcPath = srcPath;
+        this.targetParentPath = targetParentPath;
+        if (!this.targetParentPath.endsWith(OCFile.PATH_SEPARATOR)) {
+            this.targetParentPath += OCFile.PATH_SEPARATOR;
         }
-
-        mFile = null;
     }
 
     /**
@@ -62,29 +57,27 @@ public class MoveFileOperation extends SyncOperation {
     @Override
     protected RemoteOperationResult run(OwnCloudClient client) {
         /// 1. check move validity
-        if (mTargetParentPath.startsWith(mSrcPath)) {
+        if (targetParentPath.startsWith(srcPath)) {
             return new RemoteOperationResult(ResultCode.INVALID_MOVE_INTO_DESCENDANT);
         }
-        mFile = getStorageManager().getFileByPath(mSrcPath);
-        if (mFile == null) {
+        OCFile file = getStorageManager().getFileByPath(srcPath);
+        if (file == null) {
             return new RemoteOperationResult(ResultCode.FILE_NOT_FOUND);
         }
 
         /// 2. remote move
-        String targetPath = mTargetParentPath + mFile.getFileName();
-        if (mFile.isFolder()) {
+        String targetPath = targetParentPath + file.getFileName();
+        if (file.isFolder()) {
             targetPath += OCFile.PATH_SEPARATOR;
         }
-        RemoteOperationResult result = new MoveFileRemoteOperation(mSrcPath, targetPath, false).execute(client);
+        RemoteOperationResult result = new MoveFileRemoteOperation(srcPath, targetPath, false).execute(client);
 
         /// 3. local move
         if (result.isSuccess()) {
-            getStorageManager().moveLocalFile(mFile, targetPath, mTargetParentPath);
+            getStorageManager().moveLocalFile(file, targetPath, targetParentPath);
         }
         // TODO handle ResultCode.PARTIAL_MOVE_DONE in client Activity, for the moment
 
         return result;
     }
-
-
 }

src/main/java/com/owncloud/android/ui/activity/StorageMigration.java

@@ -324,6 +324,11 @@ public class StorageMigration {
                 this.mResId = resId;
             }
 
+            MigrationException(int resId, Throwable t) {
+                super(t);
+                this.mResId = resId;
+            }
+
             private int getResId() { return mResId; }
         }
 
@@ -433,7 +438,7 @@ public class StorageMigration {
                 manager.migrateStoredFiles(mStorageSource, mStorageTarget);
             } catch (Exception e) {
                 Log_OC.e(TAG,e.getMessage(),e);
-                throw new MigrationException(R.string.file_migration_failed_while_updating_index);
+                throw new MigrationException(R.string.file_migration_failed_while_updating_index, e);
             }
         }
 

src/main/java/com/owncloud/android/ui/dialog/SamlWebViewDialog.java

@@ -92,8 +92,8 @@ public class SamlWebViewDialog extends DialogFragment {
             mWebViewClient = new SsoWebViewClient(activity, mHandler, mSsoWebViewClientListener);
 
         } catch (ClassCastException e) {
-            throw new ClassCastException(activity.toString() + " must implement " +
-                    SsoWebViewClientListener.class.getSimpleName());
+            throw new IllegalArgumentException(activity.toString() + " must implement " +
+                    SsoWebViewClientListener.class.getSimpleName(), e);
         }
     }
 

src/main/java/com/owncloud/android/ui/fragment/FileFragment.java

@@ -104,8 +104,8 @@ public class FileFragment extends Fragment {
             mContainerActivity = (ContainerActivity) activity;
 
         } catch (ClassCastException e) {
-            throw new ClassCastException(activity.toString() + " must implement " +
-                    ContainerActivity.class.getSimpleName());
+            throw new IllegalArgumentException(activity.toString() + " must implement " +
+                    ContainerActivity.class.getSimpleName(), e);
         }
     }
 

src/main/java/com/owncloud/android/ui/fragment/LocalFileListFragment.java

@@ -72,8 +72,8 @@ public class LocalFileListFragment extends ExtendedListFragment implements Local
         try {
             mContainerActivity = (ContainerActivity) activity;
         } catch (ClassCastException e) {
-            throw new ClassCastException(activity.toString() + " must implement " +
-                    LocalFileListFragment.ContainerActivity.class.getSimpleName());
+            throw new IllegalArgumentException(activity.toString() + " must implement " +
+                    LocalFileListFragment.ContainerActivity.class.getSimpleName(), e);
         }
     }
 

src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java

@@ -240,15 +240,15 @@ public class OCFileListFragment extends ExtendedListFragment implements
             mContainerActivity = (FileFragment.ContainerActivity) context;
 
         } catch (ClassCastException e) {
-            throw new ClassCastException(context.toString() + " must implement " +
-                    FileFragment.ContainerActivity.class.getSimpleName());
+            throw new IllegalArgumentException(context.toString() + " must implement " +
+                    FileFragment.ContainerActivity.class.getSimpleName(), e);
         }
         try {
             setOnRefreshListener((OnEnforceableRefreshListener) context);
 
         } catch (ClassCastException e) {
-            throw new ClassCastException(context.toString() + " must implement " +
-                    SwipeRefreshLayout.OnRefreshListener.class.getSimpleName());
+            throw new IllegalArgumentException(context.toString() + " must implement " +
+                    SwipeRefreshLayout.OnRefreshListener.class.getSimpleName(), e);
         }
     }
 

src/main/java/com/owncloud/android/ui/fragment/SearchShareesFragment.java

@@ -195,8 +195,8 @@ public class SearchShareesFragment extends Fragment implements ShareUserListAdap
         try {
             mListener = (ShareFragmentListener) activity;
         } catch (ClassCastException e) {
-            throw new ClassCastException(activity.toString()
-                    + " must implement OnFragmentInteractionListener");
+            throw new IllegalArgumentException(activity.toString()
+                    + " must implement OnFragmentInteractionListener", e);
         }
     }
 

src/main/java/com/owncloud/android/ui/fragment/ShareFileFragment.java

@@ -576,7 +576,8 @@ public class ShareFileFragment extends Fragment implements ShareUserListAdapter.
         try {
             mListener = (ShareFragmentListener) activity;
         } catch (ClassCastException e) {
-            throw new ClassCastException(activity.toString() + " must implement OnShareFragmentInteractionListener");
+            throw new IllegalArgumentException(
+                activity.toString() + " must implement OnShareFragmentInteractionListener", e);
         }
     }
 

src/main/java/com/owncloud/android/utils/BitmapUtils.java

@@ -45,6 +45,13 @@ import androidx.exifinterface.media.ExifInterface;
 public final class BitmapUtils {
     public static final String TAG = BitmapUtils.class.getSimpleName();
 
+    private static final int INDEX_RED = 0;
+    private static final int INDEX_GREEN = 1;
+    private static final int INDEX_BLUE = 2;
+    private static final int INDEX_HUE = 0;
+    private static final int INDEX_SATURATION = 1;
+    private static final int INDEX_LUMINATION = 2;
+
     private BitmapUtils() {
         // utility class -> private constructor
     }
@@ -300,22 +307,22 @@ public final class BitmapUtils {
         }
 
         // Reduce values bigger than rgb requirements
-        rgb[0] = rgb[0] % 255;
-        rgb[1] = rgb[1] % 255;
-        rgb[2] = rgb[2] % 255;
+        rgb[INDEX_RED] = rgb[INDEX_RED] % 255;
+        rgb[INDEX_GREEN] = rgb[INDEX_GREEN] % 255;
+        rgb[INDEX_BLUE] = rgb[INDEX_BLUE] % 255;
 
-        double[] hsl = rgbToHsl(rgb[0], rgb[1], rgb[2]);
+        double[] hsl = rgbToHsl(rgb[INDEX_RED], rgb[INDEX_GREEN], rgb[INDEX_BLUE]);
 
         // Classic formula to check the brightness for our eye
         // If too bright, lower the sat
-        double bright = Math.sqrt(0.299 * Math.pow(rgb[0], 2) + 0.587 * Math.pow(rgb[1], 2) + 0.114
-                * Math.pow(rgb[2], 2));
+        double bright = Math.sqrt(0.299 * Math.pow(rgb[INDEX_RED], 2) + 0.587 * Math.pow(rgb[INDEX_GREEN], 2) + 0.114
+                * Math.pow(rgb[INDEX_BLUE], 2));
 
         if (bright >= 200) {
             sat = 60;
         }
 
-        return new int[]{(int) (hsl[0] * 360), sat, lum};
+        return new int[]{(int) (hsl[INDEX_HUE] * 360), sat, lum};
     }
 
     private static double[] rgbToHsl(double rUntrimmed, double gUntrimmed, double bUntrimmed) {
@@ -346,9 +353,9 @@ public final class BitmapUtils {
         }
 
         double[] hsl = new double[]{0.0, 0.0, 0.0};
-        hsl[0] = h;
-        hsl[1] = s;
-        hsl[2] = l;
+        hsl[INDEX_HUE] = h;
+        hsl[INDEX_SATURATION] = s;
+        hsl[INDEX_LUMINATION] = l;
 
         return hsl;
     }