Browse Source

fix lint: Missing accessibility label: where minSdk < 17, you should provide an android:hint

AndyScherzinger 7 years ago
parent
commit
425310abc1

+ 26 - 26
src/main/res/layout-land/account_setup.xml

@@ -174,40 +174,40 @@
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content">
 
-                    <EditText
-                        android:id="@+id/oAuthEntryPoint_1"
-                        android:layout_width="match_parent"
-                        android:layout_height="wrap_content"
-                        android:ems="10"
-                        android:enabled="false"
-                        android:inputType="textUri"
+					<EditText
+						android:id="@+id/oAuthEntryPoint_1"
+						android:layout_width="match_parent"
+						android:layout_height="wrap_content"
+						android:ems="10"
+						android:enabled="false"
+						android:hint="@string/oauth_2_0_auth_end_point_address_hint"
+						android:inputType="textUri"
 						android:maxLines="1"
-                        android:text="@string/oauth2_url_endpoint_auth"
-                        android:textColor="@color/login_text_color"
-                        android:textColorHint="@color/login_text_hint_color"
-                        android:visibility="gone"/>
+						android:text="@string/oauth2_url_endpoint_auth"
+						android:textColor="@color/login_text_color"
+						android:textColorHint="@color/login_text_hint_color"
+						android:visibility="gone" />
 
-                </android.support.design.widget.TextInputLayout>
+				</android.support.design.widget.TextInputLayout>
 
                 <android.support.design.widget.TextInputLayout
                     android:id="@+id/input_layout_oAuthEntryPoint_2"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content">
 
-				<EditText
-					android:id="@+id/oAuthEntryPoint_2"
-					android:layout_width="match_parent"
-					android:layout_height="wrap_content"
-					android:ems="10"
-					android:enabled="false"
-					android:text="@string/oauth2_url_endpoint_access"
-					android:maxLines="1"
-					android:inputType="textUri"
-					android:textColor="@color/login_text_color"
-					android:textColorHint="@color/login_text_hint_color"
-					android:visibility="gone">
-					<requestFocus />
-				</EditText>
+					<EditText
+						android:id="@+id/oAuthEntryPoint_2"
+						android:layout_width="match_parent"
+						android:layout_height="wrap_content"
+						android:ems="10"
+						android:enabled="false"
+						android:hint="@string/oauth_2_0_access_end_point_address_hint"
+						android:inputType="textUri"
+						android:maxLines="1"
+						android:text="@string/oauth2_url_endpoint_access"
+						android:textColor="@color/login_text_color"
+						android:textColorHint="@color/login_text_hint_color"
+						android:visibility="gone" />
 
                 </android.support.design.widget.TextInputLayout>
 

+ 3 - 1
src/main/res/layout/account_setup.xml

@@ -173,6 +173,7 @@
                 android:layout_height="wrap_content"
                 android:ems="10"
                 android:enabled="false"
+                android:hint="@string/oauth_2_0_auth_end_point_address_hint"
                 android:inputType="textUri"
                 android:maxLines="1"
                 android:text="@string/oauth2_url_endpoint_auth"
@@ -193,12 +194,13 @@
                 android:layout_height="wrap_content"
                 android:ems="10"
                 android:enabled="false"
+                android:hint="@string/oauth_2_0_access_end_point_address_hint"
                 android:inputType="textUri"
                 android:maxLines="1"
                 android:text="@string/oauth2_url_endpoint_access"
                 android:textColor="@color/login_text_color"
                 android:textColorHint="@color/login_text_hint_color"
-                android:visibility="gone"/>
+                android:visibility="gone" />
 
         </android.support.design.widget.TextInputLayout>
 

+ 1 - 0
src/main/res/layout/edit_box_dialog.xml

@@ -29,6 +29,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:ems="10"
+        android:hint="@string/hint_name"
         android:inputType="textNoSuggestions|textCapSentences"/>
 
 </LinearLayout>

+ 6 - 5
src/main/res/layout/passcodelock.xml

@@ -24,7 +24,6 @@
     android:orientation="vertical"
     android:padding="@dimen/standard_padding" >
 
-
     <TextView
         android:id="@+id/header"
         android:layout_width="wrap_content"
@@ -56,28 +55,30 @@
             style="@style/PassCodeStyle"
             android:cursorVisible="true"
             android:imeOptions="flagNoExtractUi"
-            ><requestFocus/></EditText>
+            android:hint="@string/hidden_character">
+            <requestFocus/>
+        </EditText>
 
         <EditText
             android:id="@+id/txt1"
             style="@style/PassCodeStyle"
             android:cursorVisible="true"
             android:imeOptions="flagNoExtractUi"
-            />
+            android:hint="@string/hidden_character"/>
 
         <EditText
             android:id="@+id/txt2"
             style="@style/PassCodeStyle"
             android:cursorVisible="true"
             android:imeOptions="flagNoExtractUi"
-            />
+            android:hint="@string/hidden_character"/>
 
         <EditText
             android:id="@+id/txt3"
             style="@style/PassCodeStyle"
             android:cursorVisible="true"
             android:imeOptions="flagNoExtractUi"
-            />
+            android:hint="@string/hidden_character"/>
     </LinearLayout>
 
     <android.support.v7.widget.AppCompatButton

+ 1 - 0
src/main/res/layout/password_dialog.xml

@@ -33,6 +33,7 @@
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:ems="10"
+            android:hint="@string/hint_password"
             android:inputType="textPassword"
             android:layout_margin="@dimen/standard_margin">
         </EditText>

+ 1 - 0
src/main/res/layout/upload_file_dialog.xml

@@ -38,6 +38,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:ems="10"
+        android:hint="@string/hint_name"
         android:inputType="textNoSuggestions|textCapSentences"/>
 
     <TextView

+ 2 - 2
src/main/res/values/oauth2_configuration.xml

@@ -5,8 +5,8 @@
     <string name="oauth2_redirect_uri">owncloud://callback</string>
     
     <!-- values that should be provided by ownCloud server -->
-    <string name="oauth2_url_endpoint_auth">http://oauth2.authorization.server.org/paht/to/endpoint/for/authorization</string>
-    <string name="oauth2_url_endpoint_access">http://oauth2.authorization.server.org/paht/to/endpoint/for/access/token</string>
+    <string name="oauth2_url_endpoint_auth">http://oauth2.authorization.server.org/path/to/endpoint/for/authorization</string>
+    <string name="oauth2_url_endpoint_access">http://oauth2.authorization.server.org/path/to/endpoint/for/access/token</string>
     <string name="oauth2_scope">owncloud</string>
     <string name="oauth2_grant_type">authorization_code</string>	<!-- the only one supported right now -->
     <string name="oauth2_response_type">code</string>				<!-- depends on oauth2_grant_type -->

+ 5 - 0
src/main/res/values/strings.xml

@@ -774,4 +774,9 @@
     <string name="notification_channel_push_name">Push notifications</string>
     <string name="notification_channel_push_description">Show push notifications sent by the server: Mentions in comments, reception of new remote shares, announcements posted by an admin etc.</string>
     <string name="sendbutton_description">Send button icon</string>
+    <string name="oauth_2_0_auth_end_point_address_hint">Auth end point address</string>
+    <string name="oauth_2_0_access_end_point_address_hint">Access end point address</string>
+    <string name="hidden_character" translatable="false">*</string>
+    <string name="hint_name">Name</string>
+    <string name="hint_password">Password</string>
 </resources>