Browse Source

codacy: add break to switch statements

AndyScherzinger 8 years ago
parent
commit
4dd37f2863

+ 1 - 0
src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java

@@ -1460,6 +1460,7 @@ public class AuthenticatorActivity extends AccountAuthenticatorActivity
             default:
                 mServerStatusText = 0;
                 mServerStatusIcon = 0;
+                break;
         }
     }
 

+ 1 - 0
src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java

@@ -520,6 +520,7 @@ public abstract class DrawerActivity extends ToolbarActivity implements DisplayU
                 break;
             default:
                 Log_OC.i(TAG, "Unknown drawer menu item clicked: " + menuItem.getTitle());
+                break;
         }
     }
 

+ 1 - 0
src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java

@@ -777,6 +777,7 @@ public class FileDisplayActivity extends HookActivity
             }
             default:
                 retval = super.onOptionsItemSelected(item);
+                break;
         }
         return retval;
     }

+ 1 - 0
src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.java

@@ -298,6 +298,7 @@ public class FolderPickerActivity extends FileActivity implements FileFragment.C
         }
         default:
             retval = super.onOptionsItemSelected(item);
+            break;
         }
         return retval;
     }

+ 1 - 0
src/main/java/com/owncloud/android/ui/activity/FolderSyncActivity.java

@@ -376,6 +376,7 @@ public class FolderSyncActivity extends FileActivity implements FolderSyncAdapte
 
             default:
                 result = super.onOptionsItemSelected(item);
+                break;
         }
         return result;
     }

+ 1 - 0
src/main/java/com/owncloud/android/ui/activity/LogHistoryActivity.java

@@ -133,6 +133,7 @@ public class LogHistoryActivity extends ToolbarActivity {
                 break;
             default:
                 retval = super.onOptionsItemSelected(item);
+                break;
         }
         return retval;
     }

+ 1 - 0
src/main/java/com/owncloud/android/ui/activity/ManageAccountsActivity.java

@@ -237,6 +237,7 @@ public class ManageAccountsActivity extends FileActivity
                 break;
             default:
                 retval = super.onOptionsItemSelected(item);
+                break;
         }
         return retval;
     }

+ 1 - 0
src/main/java/com/owncloud/android/ui/activity/ManageSpaceActivity.java

@@ -85,6 +85,7 @@ public class ManageSpaceActivity extends AppCompatActivity {
             default:
                 Log_OC.w(TAG, "Unknown menu item triggered");
                 retval =  super.onOptionsItemSelected(item);
+                break;
         }
         return retval;
     }

+ 3 - 1
src/main/java/com/owncloud/android/ui/activity/ParticipateActivity.java

@@ -117,7 +117,7 @@ public class ParticipateActivity extends FileActivity {
 
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
-        boolean retval;
+        boolean retval = true;
         switch (item.getItemId()) {
             case android.R.id.home: {
                 if (isDrawerOpen()) {
@@ -125,10 +125,12 @@ public class ParticipateActivity extends FileActivity {
                 } else {
                     openDrawer();
                 }
+                break;
             }
 
             default:
                 retval = super.onOptionsItemSelected(item);
+                break;
         }
         return retval;
     }

+ 1 - 0
src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java

@@ -996,6 +996,7 @@ public class ReceiveExternalFilesActivity extends FileActivity
 
             default:
                 retval = super.onOptionsItemSelected(item);
+                break;
         }
         return retval;
     }

+ 1 - 1
src/main/java/com/owncloud/android/ui/activity/UploadFilesActivity.java

@@ -236,10 +236,10 @@ public class UploadFilesActivity extends FileActivity implements
                     item.setIcon(R.drawable.ic_view_list);
                     mFileListFragment.switchToGridView();
                 }
-                return true;
             }
             default:
                 retval = super.onOptionsItemSelected(item);
+                break;
         }
         return retval;
     }

+ 2 - 1
src/main/java/com/owncloud/android/ui/adapter/FileListListAdapter.java

@@ -249,7 +249,7 @@ public class FileListListAdapter extends BaseAdapter {
                     fileSizeV.setVisibility(View.VISIBLE);
                     fileSizeV.setText(DisplayUtils.bytesToHumanReadable(file.getFileLength()));
 
-
+                    break;
                 case GRID_ITEM:
                     // filename
                     fileName = (TextView) view.findViewById(R.id.Filename);
@@ -262,6 +262,7 @@ public class FileListListAdapter extends BaseAdapter {
                         fileName.setVisibility(View.GONE);
                     }
 
+                    break;
                 case GRID_IMAGE:
                     // sharedIcon
                     ImageView sharedIconV = (ImageView) view.findViewById(R.id.sharedIcon);

+ 1 - 0
src/main/java/com/owncloud/android/ui/asynctasks/CopyAndUploadContentUrisTask.java

@@ -255,6 +255,7 @@ public class CopyAndUploadContentUrisTask extends AsyncTask<Object, Void, Result
                         break;
                     default:
                         messageId = R.string.common_error_unknown;
+                        break;
                 }
                 String message = String.format(
                     mAppContext.getString(messageId),

+ 1 - 0
src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java

@@ -334,6 +334,7 @@ public class FileDetailFragment extends FileFragment implements OnClickListener
             }
             default:
                 Log_OC.e(TAG, "Incorrect view clicked!");
+                break;
         }
     }
 

+ 1 - 0
src/main/java/com/owncloud/android/ui/preview/FileDownloadFragment.java

@@ -218,6 +218,7 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene
             }
             default:
                 Log_OC.e(TAG, "Incorrect view clicked!");
+                break;
         }
     }
 

+ 1 - 0
src/main/java/com/owncloud/android/ui/preview/PreviewImageActivity.java

@@ -272,6 +272,7 @@ public class PreviewImageActivity extends FileActivity implements
             break;
         default:
         	returnValue = super.onOptionsItemSelected(item);
+            break;
         }
         
         return returnValue;