codacy: Avoid instantiating new objects inside loops

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

src/main/java/com/owncloud/android/datamodel/FileDataStorageManager.java

@@ -346,10 +346,11 @@ public class FileDataStorageManager {
 
         // prepare operations to remove files in the given folder
         String where = ProviderTableMeta.FILE_ACCOUNT_OWNER + AND + ProviderTableMeta.FILE_PATH + "=?";
-        String[] whereArgs;
+        String[] whereArgs = new String[2];
         for (OCFile file : filesToRemove) {
             if (file.getParentId() == folder.getFileId()) {
-                whereArgs = new String[]{account.name, file.getRemotePath()};
+                whereArgs[0] = account.name;
+                whereArgs[1] = file.getRemotePath();
                 if (file.isFolder()) {
                     operations.add(ContentProviderOperation.newDelete(
                             ContentUris.withAppendedId(ProviderTableMeta.CONTENT_URI_DIR, file.getFileId()))
@@ -1577,9 +1578,10 @@ public class FileDataStorageManager {
             List<OCShare> shares, ArrayList<ContentProviderOperation> operations) {
 
         if (shares != null) {
+            ContentValues cv;
             // prepare operations to insert or update files to save in the given folder
             for (OCShare share : shares) {
-                ContentValues cv = new ContentValues();
+                cv = new ContentValues();
                 cv.put(ProviderTableMeta.OCSHARES_FILE_SOURCE, share.getFileSource());
                 cv.put(ProviderTableMeta.OCSHARES_ITEM_SOURCE, share.getItemSource());
                 cv.put(ProviderTableMeta.OCSHARES_SHARE_TYPE, share.getShareType().getValue());

src/main/java/com/owncloud/android/providers/FileContentProvider.java

@@ -875,6 +875,7 @@ public class FileContentProvider extends ContentProvider {
             String username;
             String oldAccountName;
             String newAccountName;
+            String[] accountOwner = new String[1];
 
             for (Account account : accounts) {
                 // build both old and new account name
@@ -888,10 +889,11 @@ public class FileContentProvider extends ContentProvider {
                 try {
                     ContentValues cv = new ContentValues();
                     cv.put(ProviderTableMeta.FILE_ACCOUNT_OWNER, newAccountName);
+                    accountOwner[0] = oldAccountName;
                     int num = db.update(ProviderTableMeta.FILE_TABLE_NAME,
                                         cv,
                                         ProviderTableMeta.FILE_ACCOUNT_OWNER + "=?",
-                                        new String[]{oldAccountName});
+                                        accountOwner);
 
                     Log_OC.d(SQL, "Updated account in database: old name == " + oldAccountName +
                         ", new name == " + newAccountName + " (" + num + " rows updated )");
@@ -944,6 +946,8 @@ public class FileContentProvider extends ContentProvider {
                 File newAccountFolder = new File(newAccountPath);
                 oldAccountFolder.renameTo(newAccountFolder);
 
+                String[] storagePath = new String[1];
+
                 // update database
                 do {
                     // Update database
@@ -955,10 +959,11 @@ public class FileContentProvider extends ContentProvider {
 
                     ContentValues cv = new ContentValues();
                     cv.put(ProviderTableMeta.FILE_STORAGE_PATH, newPath);
+                    storagePath[0] = oldPath;
                     db.update(ProviderTableMeta.FILE_TABLE_NAME,
                               cv,
                               ProviderTableMeta.FILE_STORAGE_PATH + "=?",
-                              new String[]{oldPath});
+                              storagePath);
 
                     Log_OC.v(SQL, "Updated path of downloaded file: old file name == " + oldPath +
                         ", new file name == " + newPath);

src/main/java/com/owncloud/android/ui/adapter/NotificationListAdapter.java

@@ -133,7 +133,10 @@ public class NotificationListAdapter extends RecyclerView.Adapter<NotificationLi
 
         Resources resources = notificationsActivity.getResources();
         NotificationExecuteActionTask task = new NotificationExecuteActionTask(client, holder, notificationsActivity);
-
+        LinearLayout.LayoutParams params = new LinearLayout.LayoutParams(LinearLayout.LayoutParams.WRAP_CONTENT,
+            ViewGroup.LayoutParams.WRAP_CONTENT);
+        params.setMargins(20, 0, 20, 0);
+        
         for (Action action : notification.getActions()) {
             button = new MaterialButton(notificationsActivity);
 
@@ -156,9 +159,6 @@ public class NotificationListAdapter extends RecyclerView.Adapter<NotificationLi
             button.setText(action.label);
             button.setCornerRadiusResource(R.dimen.button_corner_radius);
 
-            LinearLayout.LayoutParams params = new LinearLayout.LayoutParams(LinearLayout.LayoutParams.WRAP_CONTENT,
-                                                                             ViewGroup.LayoutParams.WRAP_CONTENT);
-            params.setMargins(20, 0, 20, 0);
             button.setLayoutParams(params);
             button.setGravity(Gravity.CENTER);