Browse Source

codacy: utils classes are to be final with private constructor

AndyScherzinger 6 years ago
parent
commit
65df2e82b3

+ 4 - 1
src/generic/java/com/owncloud/android/utils/PushUtils.java

@@ -28,9 +28,12 @@ import com.owncloud.android.db.PreferenceManager;
 
 
 import java.security.Key;
 import java.security.Key;
 
 
-public class PushUtils {
+public final class PushUtils {
     public static final String KEY_PUSH = "push";
     public static final String KEY_PUSH = "push";
 
 
+    private PushUtils() {
+    }
+
     public static void pushRegistrationToServer() {
     public static void pushRegistrationToServer() {
         // do nothing
         // do nothing
     }
     }

+ 4 - 1
src/gplay/java/com/owncloud/android/utils/PushUtils.java

@@ -71,7 +71,7 @@ import java.security.spec.PKCS8EncodedKeySpec;
 import java.security.spec.X509EncodedKeySpec;
 import java.security.spec.X509EncodedKeySpec;
 import java.util.Locale;
 import java.util.Locale;
 
 
-public class PushUtils {
+public final class PushUtils {
 
 
     public static final String KEY_PUSH = "push";
     public static final String KEY_PUSH = "push";
     private static final String TAG = "PushUtils";
     private static final String TAG = "PushUtils";
@@ -81,6 +81,9 @@ public class PushUtils {
     private static final String KEYPAIR_PUB_EXTENSION = ".pub";
     private static final String KEYPAIR_PUB_EXTENSION = ".pub";
     private static ArbitraryDataProvider arbitraryDataProvider;
     private static ArbitraryDataProvider arbitraryDataProvider;
 
 
+    private PushUtils() {
+    }
+
     public static String generateSHA512Hash(String pushToken) {
     public static String generateSHA512Hash(String pushToken) {
         MessageDigest messageDigest = null;
         MessageDigest messageDigest = null;
         try {
         try {

+ 4 - 1
src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java

@@ -78,7 +78,7 @@ import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 /**
 /**
  * Manager for concurrent access to thumbnails cache.
  * Manager for concurrent access to thumbnails cache.
  */
  */
-public class ThumbnailsCacheManager {
+public final class ThumbnailsCacheManager {
 
 
     public static final String PREFIX_RESIZED_IMAGE = "r";
     public static final String PREFIX_RESIZED_IMAGE = "r";
     public static final String PREFIX_THUMBNAIL = "t";
     public static final String PREFIX_THUMBNAIL = "t";
@@ -103,6 +103,9 @@ public class ThumbnailsCacheManager {
 
 
     public static final Bitmap mDefaultVideo = BitmapFactory.decodeResource(MainApp.getAppContext().getResources(),
     public static final Bitmap mDefaultVideo = BitmapFactory.decodeResource(MainApp.getAppContext().getResources(),
             R.drawable.file_movie);
             R.drawable.file_movie);
+
+    private ThumbnailsCacheManager() {
+    }
     
     
     public static class InitDiskCacheTask extends AsyncTask<File, Void, Void> {
     public static class InitDiskCacheTask extends AsyncTask<File, Void, Void> {
         @Override
         @Override

+ 4 - 1
src/versionDev/java/com/owncloud/android/utils/PushUtils.java

@@ -28,9 +28,12 @@ import com.owncloud.android.db.PreferenceManager;
 
 
 import java.security.Key;
 import java.security.Key;
 
 
-public class PushUtils {
+public final class PushUtils {
     public static final String KEY_PUSH = "push";
     public static final String KEY_PUSH = "push";
 
 
+    private PushUtils() {
+    }
+
     public static void pushRegistrationToServer() {
     public static void pushRegistrationToServer() {
         // do nothing
         // do nothing
     }
     }