浏览代码

Remove obsolete TODOs

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Álvaro Brey 2 年之前
父节点
当前提交
7456354774

+ 1 - 2
app/build.gradle

@@ -222,8 +222,7 @@ dependencies {
         exclude group: 'org.ogce', module: 'xpp3' // unused in Android and brings wrong Junit version
     }
 
-    compileOnly 'org.jbundle.util.osgi.wrapped:org.jbundle.util.osgi.wrapped.org.apache.http.client:4.1.2'
-    // remove after entire switch to lib v2
+    compileOnly 'org.jbundle.util.osgi.wrapped:org.jbundle.util.osgi.wrapped.org.apache.http.client:4.1.2' // remove after entire switch to lib v2
     implementation "commons-httpclient:commons-httpclient:3.1@jar" // remove after entire switch to lib v2
     implementation 'org.apache.jackrabbit:jackrabbit-webdav:2.13.5' // remove after entire switch to lib v2
     implementation 'androidx.constraintlayout:constraintlayout:2.1.4'

+ 0 - 1
app/src/main/java/com/nextcloud/client/account/UserAccountManagerImpl.java

@@ -145,7 +145,6 @@ public class UserAccountManagerImpl implements UserAccountManager {
     @Override
     @Nullable
     public Account getCurrentAccount() {
-        Log_OC.d(TAG, "getCurrentAccount"); // TODO debug only, remove
         Account[] ocAccounts = getAccounts();
         Account defaultAccount = null;
 

+ 0 - 1
app/src/main/java/com/owncloud/android/ui/ThemeableSwitchPreference.java

@@ -36,7 +36,6 @@ import javax.inject.Inject;
 /**
  * Themeable switch preference TODO Migrate to androidx
  */
-// TODO use ViewThemeUtils to theme SwitchPreference directly and remove this class
 public class ThemeableSwitchPreference extends SwitchPreference {
     @Inject
     ViewThemeUtils viewThemeUtils;

+ 0 - 1
app/src/main/java/com/owncloud/android/utils/theme/FilesSpecificViewThemeUtils.kt

@@ -81,7 +81,6 @@ class FilesSpecificViewThemeUtils @Inject constructor(
             avatar.setPadding(padding, padding, padding, padding)
         }
 
-        // TODO figure out why circle and email use grey background instead of primary
         when (type) {
             ShareType.GROUP -> {
                 createAvatarBase(R.drawable.ic_group)

+ 0 - 2
app/src/main/java/com/owncloud/android/utils/theme/MaterialSchemesProviderImpl.kt

@@ -34,8 +34,6 @@ import com.owncloud.android.lib.resources.status.OCCapability
 import java.util.concurrent.ConcurrentHashMap
 import javax.inject.Inject
 
-// TODO think about assisted inject to pass user instead of fetching it from userAccountManager,
-//  thus making it more efficient, or cache the user, IDK
 internal class MaterialSchemesProviderImpl @Inject constructor(
     private val logger: Logger,
     private val context: Context,