فهرست منبع

fixed codacy warnings

AndyScherzinger 8 سال پیش
والد
کامیت
786f00fa9a

+ 2 - 3
src/com/owncloud/android/features/FeatureList.java

@@ -37,8 +37,7 @@ import java.util.regex.Pattern;
  * @author Bartosz Przybylski
  */
 public class FeatureList {
-    static final private boolean SHOW_ON_FIRST_RUN = true;
-    static final private boolean SHOW_ON_UPGRADE = false;
+    private static final boolean SHOW_ON_FIRST_RUN = true;
 
     private static final String VERSION_1_0_0 = "1.0.0";
     private static final String BETA_VERSION_0 = "0";
@@ -153,7 +152,7 @@ public class FeatureList {
                 };
     }
 
-    static int versionCodeFromString(String version) {
+    private static int versionCodeFromString(String version) {
         String v[] = version.split(Pattern.quote("."));
         if (v.length != 3) {
             Log_OC.e("FeatureList", "Version string is incorrect " + version);

+ 4 - 11
src/com/owncloud/android/ui/activity/WhatsNewActivity.java

@@ -167,24 +167,15 @@ public class WhatsNewActivity extends FragmentActivity implements ViewPager.OnPa
                 );
     }
 
-    @Override
-    public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels) {
-    }
-
     @Override
     public void onPageSelected(int position) {
         mProgress.animateToStep(position+1);
         updateNextButtonIfNeeded();
     }
 
-    @Override
-    public void onPageScrollStateChanged(int state) {
-
-    }
-
     private final class FeaturesViewAdapter extends FragmentPagerAdapter {
 
-        FeatureItem[] mFeatures;
+        private FeatureItem[] mFeatures;
 
         public FeaturesViewAdapter(FragmentManager fm, FeatureItem[]features) {
             super(fm);
@@ -221,7 +212,9 @@ public class WhatsNewActivity extends FragmentActivity implements ViewPager.OnPa
 
         @Nullable
         @Override
-        public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
+        public View onCreateView(LayoutInflater inflater,
+                                 @Nullable ViewGroup container,
+                                 @Nullable Bundle savedInstanceState) {
             View v = inflater.inflate(R.layout.whats_new_element, container, false);
 
             ImageView iv = (ImageView)v.findViewById(R.id.whatsNewImage);