Merge pull request #7045 from nextcloud/codacy

Codacy

src/main/java/com/nextcloud/android/sso/aidl/ParcelFileDescriptorUtil.java

@@ -20,7 +20,6 @@
 package com.nextcloud.android.sso.aidl;
 
 import android.os.ParcelFileDescriptor;
-import android.util.Log;
 
 import com.owncloud.android.lib.common.utils.Log_OC;
 

src/main/java/com/nextcloud/client/integrations/deck/DeckApiImpl.java

@@ -33,8 +33,6 @@ import androidx.annotation.NonNull;
 
 public class DeckApiImpl implements DeckApi {
 
-    private static final String TAG = DeckApiImpl.class.getSimpleName();
-
     static final String APP_NAME = "deck";
     static final String[] DECK_APP_PACKAGES = new String[] {
         "it.niedermann.nextcloud.deck",

src/main/java/com/owncloud/android/datamodel/FileDataStorageManager.java

@@ -75,7 +75,6 @@ public class FileDataStorageManager {
     private static final String TAG = FileDataStorageManager.class.getSimpleName();
 
     private static final String AND = " = ? AND ";
-    private static final String FAILED_TO_UPDATE_MSG = "Fail to update file to database ";
     private static final String FAILED_TO_INSERT_MSG = "Fail to insert insert file to database ";
     private static final String SENDING_TO_FILECONTENTPROVIDER_MSG = "Sending %d operations to FileContentProvider";
     private static final String EXCEPTION_MSG = "Exception in batch of operations ";

src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java

@@ -481,7 +481,6 @@ public final class ThumbnailsCacheManager {
         @Override
         protected Bitmap doInBackground(ThumbnailGenerationTaskObject... params) {
             Bitmap thumbnail = null;
-            boolean isError = false;
             try {
                 if (mAccount != null) {
                     OwnCloudAccount ocAccount = new OwnCloudAccount(

src/main/java/com/owncloud/android/ui/activity/UploadFilesActivity.java

@@ -529,7 +529,7 @@ public class UploadFilesActivity extends DrawerActivity implements LocalFileList
         } else {
             mBehaviourSpinner.setSelection(1);
             textView.setText(new StringBuilder().append(getString(R.string.uploader_upload_files_behaviour))
-                                 .append(" ")
+                                 .append(' ')
                                  .append(getString(R.string.uploader_upload_files_behaviour_not_writable))
                                  .toString());
         }

src/main/java/com/owncloud/android/ui/adapter/UploaderAdapter.java

@@ -1,4 +1,4 @@
-/**
+/*
  *   ownCloud Android client application
  *
  *   @author Tobias Kaminsky
@@ -20,7 +20,6 @@
 
 package com.owncloud.android.ui.adapter;
 
-import android.accounts.Account;
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.drawable.Drawable;

src/main/java/com/owncloud/android/ui/preview/FileDownloadFragment.java

@@ -1,4 +1,4 @@
-/**
+/*
  *   ownCloud Android client application
  *
  *   @author David A. Velasco
@@ -19,7 +19,6 @@
  */
 package com.owncloud.android.ui.preview;
 
-import android.accounts.Account;
 import android.os.Bundle;
 import android.view.LayoutInflater;
 import android.view.View;

src/main/java/com/owncloud/android/utils/MimeTypeUtil.java

@@ -18,7 +18,6 @@
 
 package com.owncloud.android.utils;
 
-import android.accounts.Account;
 import android.content.Context;
 import android.graphics.drawable.Drawable;
 import android.net.Uri;