Merge pull request #9666 from nextcloud/fix/favorites-selection-breaking

FileOperationsHelper: fix aliasing when toggling favorite files

src/main/java/com/owncloud/android/ui/helpers/FileOperationsHelper.java

@@ -882,16 +882,14 @@ public class FileOperationsHelper {
     }
 
     public void toggleFavoriteFiles(Collection<OCFile> files, boolean shouldBeFavorite) {
-        List<OCFile> alreadyRightStateList = new ArrayList<>();
+        List<OCFile> toToggle = new ArrayList<>();
         for (OCFile file : files) {
-            if (file.isFavorite() == shouldBeFavorite) {
-                alreadyRightStateList.add(file);
+            if (file.isFavorite() != shouldBeFavorite) {
+                toToggle.add(file);
             }
         }
 
-        files.removeAll(alreadyRightStateList);
-
-        for (OCFile file : files) {
+        for (OCFile file : toToggle) {
             toggleFavoriteFile(file, shouldBeFavorite);
         }
     }