Merge pull request #4196 from nextcloud/codacy

Codacy

src/main/java/com/nextcloud/android/sso/InputStreamBinder.java

@@ -311,7 +311,7 @@ public class InputStreamBinder extends IInputStreamService.Stub {
             }
             throw new IllegalStateException(EXCEPTION_HTTP_REQUEST_FAILED,
                                             new IllegalStateException(String.valueOf(status),
-                                                                      new Throwable(total.toString())));
+                                                                      new IllegalStateException(total.toString())));
         }
     }
 

src/main/java/com/nextcloud/client/di/AppModule.java

@@ -30,8 +30,6 @@ import com.nextcloud.client.account.CurrentAccountProvider;
 import com.nextcloud.client.account.UserAccountManager;
 import com.nextcloud.client.account.UserAccountManagerImpl;
 import com.nextcloud.client.device.DeviceInfo;
-import com.nextcloud.client.preferences.AppPreferences;
-import com.nextcloud.client.preferences.AppPreferencesImpl;
 import com.owncloud.android.datamodel.ArbitraryDataProvider;
 import com.owncloud.android.datamodel.UploadsStorageManager;
 import com.owncloud.android.ui.activities.data.activities.ActivitiesRepository;

src/main/java/com/nextcloud/client/di/InjectorNotFoundException.java

@@ -21,6 +21,8 @@
 package com.nextcloud.client.di;
 
 class InjectorNotFoundException extends RuntimeException {
+    private static final long serialVersionUID = 2026042918255104421L;
+
     InjectorNotFoundException(Object object, Throwable cause) {
         super(
             String.format(

src/main/java/com/owncloud/android/datastorage/UniqueStorageList.java

@@ -30,6 +30,8 @@ import java.util.Vector;
  * @author Bartosz Przybylski
  */
 public class UniqueStorageList extends Vector<StoragePoint> {
+    private static final long serialVersionUID = -6504937852826767050L;
+
     @Override
     public boolean add(StoragePoint sp) {
         try {

src/main/java/com/owncloud/android/operations/CreateShareWithShareeOperation.java

@@ -42,8 +42,6 @@ import lombok.Getter;
  */
 public class CreateShareWithShareeOperation extends SyncOperation {
 
-    protected FileDataStorageManager mStorageManager;
-
     @Getter private String path;
     private String shareeName;
     private ShareType shareType;

src/main/java/com/owncloud/android/operations/RemoteOperationFailedException.java

@@ -4,6 +4,8 @@ package com.owncloud.android.operations;
  * RuntimeException for throwing errors of remote operation calls.
  */
 public class RemoteOperationFailedException extends RuntimeException {
+    private static final long serialVersionUID = 5429778514835938713L;
+
     /**
      * Constructs a new runtime exception with the specified detail message and
      * cause.

src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java

@@ -2653,9 +2653,6 @@ public class FileDisplayActivity extends FileActivity
             return;
         }
 
-        AccountManager am = AccountManager.get(this);
-        String userId = am.getUserData(getAccount(), AccountUtils.Constants.KEY_USER_ID);
-
         FileDataStorageManager storageManager = getStorageManager();
 
         if (storageManager == null) {

src/main/java/com/owncloud/android/ui/activity/StorageMigration.java

@@ -317,6 +317,7 @@ public class StorageMigration {
 
     static private class FileMigrationTask extends FileMigrationTaskBase {
         private class MigrationException extends Exception {
+            private static final long serialVersionUID = -4575848188034992066L;
             private int mResId;
 
             MigrationException(int resId) {

src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.java

@@ -31,7 +31,6 @@ import android.view.MenuItem;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.ImageView;
-import android.widget.LinearLayout;
 import android.widget.ProgressBar;
 import android.widget.RelativeLayout;
 import android.widget.TextView;