浏览代码

improve spotbugs score

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Andy Scherzinger 4 年之前
父节点
当前提交
8cfd9aa8c7

+ 2 - 1
src/main/java/com/owncloud/android/ui/adapter/StoragePathAdapter.java

@@ -77,7 +77,8 @@ public class StoragePathAdapter extends RecyclerView.Adapter<StoragePathAdapter.
 
         public StoragePathViewHolder(StoragePathItemBinding binding) {
             super(binding.getRoot());
-            binding.getRoot().setOnClickListener(this);
+            this.binding = binding;
+            this.binding.getRoot().setOnClickListener(this);
         }
 
         @Override

+ 1 - 3
src/main/java/com/owncloud/android/ui/dialog/MultipleAccountsDialog.java

@@ -54,7 +54,6 @@ import androidx.fragment.app.DialogFragment;
 import androidx.recyclerview.widget.LinearLayoutManager;
 
 public class MultipleAccountsDialog extends DialogFragment implements Injectable, UserListAdapter.ClickListener {
-    private MultipleAccountsBinding binding;
 
     @Inject UserAccountManager accountManager;
 
@@ -68,7 +67,7 @@ public class MultipleAccountsDialog extends DialogFragment implements Injectable
 
         // Inflate the layout for the dialog
         LayoutInflater inflater = activity.getLayoutInflater();
-        binding = MultipleAccountsBinding.inflate(inflater, null, false);
+        MultipleAccountsBinding binding = MultipleAccountsBinding.inflate(inflater, null, false);
 
         final ReceiveExternalFilesActivity parent = (ReceiveExternalFilesActivity) getActivity();
         AlertDialog.Builder builder = new AlertDialog.Builder(parent);
@@ -129,7 +128,6 @@ public class MultipleAccountsDialog extends DialogFragment implements Injectable
 
     @Override
     public void onDestroyView() {
-        binding = null;
         super.onDestroyView();
     }
 }