Browse Source

Corrects "Choose" button colour in FolderPickerActivity. Removes un-used import from NotificationListAdapter.

MaterialButtons.
SearchView highlight text colour.
First run activity, outlined button colour.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Daniel Bailey 6 years ago
parent
commit
8d0ff8fecc
39 changed files with 123 additions and 105 deletions
  1. 3 4
      src/main/java/com/nextcloud/client/onboarding/FirstRunActivity.java
  2. 2 0
      src/main/java/com/nextcloud/client/preferences/AppPreferences.java
  3. 1 1
      src/main/java/com/nextcloud/client/preferences/AppPreferencesImpl.java
  4. 1 1
      src/main/java/com/owncloud/android/MainApp.java
  5. 1 1
      src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java
  6. 1 1
      src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java
  7. 1 1
      src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java
  8. 6 4
      src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.java
  9. 1 1
      src/main/java/com/owncloud/android/ui/activity/RichDocumentsWebView.java
  10. 2 4
      src/main/java/com/owncloud/android/ui/activity/SettingsActivity.java
  11. 4 3
      src/main/java/com/owncloud/android/ui/activity/UploadFilesActivity.java
  12. 1 1
      src/main/java/com/owncloud/android/ui/activity/UserInfoActivity.java
  13. 1 1
      src/main/java/com/owncloud/android/ui/adapter/LocalFileListAdapter.java
  14. 2 3
      src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java
  15. 1 1
      src/main/java/com/owncloud/android/ui/adapter/TrashbinListAdapter.java
  16. 2 2
      src/main/java/com/owncloud/android/ui/adapter/UploadListAdapter.java
  17. 7 0
      src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.java
  18. 4 0
      src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java
  19. 2 2
      src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.java
  20. 1 1
      src/main/res/drawable/list_selector.xml
  21. 2 1
      src/main/res/layout/accounts_layout.xml
  22. 1 1
      src/main/res/layout/activity_list_item.xml
  23. 1 1
      src/main/res/layout/activity_list_layout.xml
  24. 4 4
      src/main/res/layout/community_layout.xml
  25. 1 1
      src/main/res/layout/contactlist_fragment.xml
  26. 2 1
      src/main/res/layout/contacts_backup_fragment.xml
  27. 1 1
      src/main/res/layout/drawer.xml
  28. 2 2
      src/main/res/layout/file_details_fragment.xml
  29. 1 1
      src/main/res/layout/file_list_actions_bottom_sheet_fragment.xml
  30. 1 1
      src/main/res/layout/files.xml
  31. 1 1
      src/main/res/layout/generic_explanation.xml
  32. 6 6
      src/main/res/layout/sorting_order_fragment.xml
  33. 1 1
      src/main/res/layout/storage_path_item.xml
  34. 1 1
      src/main/res/layout/toolbar_standard.xml
  35. 2 1
      src/main/res/layout/user_info_layout.xml
  36. 8 5
      src/main/res/values-night/colors.xml
  37. 1 1
      src/main/res/values-v21/styles.xml
  38. 6 2
      src/main/res/values/colors.xml
  39. 37 41
      src/main/res/values/styles.xml

+ 3 - 4
src/main/java/com/nextcloud/client/onboarding/FirstRunActivity.java

@@ -28,7 +28,6 @@ import android.accounts.Account;
 import android.accounts.AccountManager;
 import android.content.Intent;
 import android.content.res.Configuration;
-import android.graphics.Color;
 import android.net.Uri;
 import android.os.Bundle;
 import android.view.View;
@@ -81,8 +80,8 @@ public class FirstRunActivity extends BaseActivity implements ViewPager.OnPageCh
         setSlideshowSize(getResources().getConfiguration().orientation == Configuration.ORIENTATION_LANDSCAPE);
 
         Button loginButton = findViewById(R.id.login);
-        loginButton.setBackgroundColor(Color.WHITE);
-        loginButton.setTextColor(getResources().getColor(R.color.primary));
+        loginButton.setBackgroundColor(getResources().getColor(R.color.bg_default));
+        loginButton.setTextColor(getResources().getColor(R.color.fg_default));
 
         loginButton.setOnClickListener(v -> {
             if (getIntent().getBooleanExtra(EXTRA_ALLOW_CLOSE, false)) {
@@ -95,7 +94,7 @@ public class FirstRunActivity extends BaseActivity implements ViewPager.OnPageCh
         });
 
         Button providerButton = findViewById(R.id.signup);
-        providerButton.setBackgroundColor(getResources().getColor(R.color.primary_dark));
+        providerButton.setBackgroundColor(getResources().getColor(R.color.primary));
         providerButton.setTextColor(getResources().getColor(R.color.login_text_color));
         providerButton.setVisibility(isProviderOrOwnInstallationVisible ? View.VISIBLE : View.GONE);
         providerButton.setOnClickListener(v -> {

+ 2 - 0
src/main/java/com/nextcloud/client/preferences/AppPreferences.java

@@ -239,6 +239,8 @@ public interface AppPreferences {
      */
     int getUploaderBehaviour();
 
+    boolean isDarkThemeEnabled();
+
     /**
      * Saves the uploader behavior which the user has set last.
      *

+ 1 - 1
src/main/java/com/nextcloud/client/preferences/AppPreferencesImpl.java

@@ -343,7 +343,7 @@ public final class AppPreferencesImpl implements AppPreferences {
     }
 
     @Override
-    public boolean getTheme() {
+    public boolean isDarkThemeEnabled() {
         return preferences.getBoolean(PREF__DARK_THEME, false);
     }
 

+ 1 - 1
src/main/java/com/owncloud/android/MainApp.java

@@ -243,7 +243,7 @@ public class MainApp extends MultiDexApplication implements HasAndroidInjector {
     @SuppressFBWarnings("ST")
     @Override
     public void onCreate() {
-        setAppTheme(preferences.getTheme());
+        setAppTheme(preferences.isDarkThemeEnabled());
         super.onCreate();
 
         insertConscrypt();

+ 1 - 1
src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java

@@ -407,7 +407,7 @@ public class AuthenticatorActivity extends AccountAuthenticatorActivity
             new Handler().postDelayed(() -> DisplayUtils.createSnackbar(mLoginWebView,
                                                                         R.string.fallback_weblogin_text,
                                                                         Snackbar.LENGTH_INDEFINITE)
-                .setActionTextColor(getResources().getColor(R.color.white))
+                .setActionTextColor(getResources().getColor(R.color.fg_inverse))
                 .setAction(R.string.fallback_weblogin_back, v -> {
                     mLoginWebView.setVisibility(View.INVISIBLE);
                     webViewLoginMethod = false;

+ 1 - 1
src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java

@@ -1173,7 +1173,7 @@ public final class ThumbnailsCacheManager {
         Bitmap resultBitmap = Bitmap.createBitmap(pxW, pxH, Bitmap.Config.ARGB_8888);
         Canvas c = new Canvas(resultBitmap);
 
-        c.drawColor(MainApp.getAppContext().getResources().getColor(R.color.background_color));
+        c.drawColor(MainApp.getAppContext().getResources().getColor(R.color.bg_default));
         c.drawBitmap(bitmap, 0, 0, null);
 
         return resultBitmap;

+ 1 - 1
src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java

@@ -1266,7 +1266,7 @@ public abstract class DrawerActivity extends ToolbarActivity
     @Override
     protected void onResume() {
         super.onResume();
-        getDelegate().setLocalNightMode(preferences.getTheme() ?
+        getDelegate().setLocalNightMode(preferences.isDarkThemeEnabled() ?
                                         AppCompatDelegate.MODE_NIGHT_YES : AppCompatDelegate.MODE_NIGHT_NO);
         getDelegate().applyDayNight();
         setDrawerMenuItemChecked(mCheckedMenuItem);

+ 6 - 4
src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.java

@@ -25,6 +25,7 @@ import android.content.BroadcastReceiver;
 import android.content.Context;
 import android.content.Intent;
 import android.content.IntentFilter;
+import android.content.res.ColorStateList;
 import android.content.res.Resources.NotFoundException;
 import android.graphics.PorterDuff;
 import android.graphics.drawable.Drawable;
@@ -37,10 +38,10 @@ import android.view.MenuInflater;
 import android.view.MenuItem;
 import android.view.View;
 import android.view.View.OnClickListener;
-import android.widget.Button;
 
 import com.nextcloud.client.di.Injectable;
 import com.nextcloud.client.preferences.AppPreferences;
+import com.google.android.material.button.MaterialButton;
 import com.owncloud.android.R;
 import com.owncloud.android.datamodel.OCFile;
 import com.owncloud.android.lib.common.operations.RemoteOperation;
@@ -90,8 +91,8 @@ public class FolderPickerActivity extends FileActivity implements FileFragment.C
     private boolean mSearchOnlyFolders;
     private boolean mDoNotEnterEncryptedFolder;
 
-    protected Button mCancelBtn;
-    protected Button mChooseBtn;
+    protected MaterialButton mCancelBtn;
+    protected MaterialButton mChooseBtn;
     private String caption;
     @Inject AppPreferences preferences;
 
@@ -405,7 +406,8 @@ public class FolderPickerActivity extends FileActivity implements FileFragment.C
         mChooseBtn = findViewById(R.id.folder_picker_btn_choose);
 
         if (mChooseBtn != null) {
-            mChooseBtn.getBackground().setColorFilter(ThemeUtils.primaryColor(this, true), PorterDuff.Mode.SRC_ATOP);
+            mChooseBtn.setBackgroundTintMode(PorterDuff.Mode.SRC_ATOP);
+            mChooseBtn.setBackgroundTintList(ColorStateList.valueOf(ThemeUtils.primaryColor(this, true)));
             mChooseBtn.setOnClickListener(this);
         }
 

+ 1 - 1
src/main/java/com/owncloud/android/ui/activity/RichDocumentsWebView.java

@@ -250,7 +250,7 @@ public class RichDocumentsWebView extends ExternalSiteWebView {
                 }
 
                 if ("image/png".equalsIgnoreCase(file.getMimeType())) {
-                    thumbnailView.setBackgroundColor(getResources().getColor(R.color.background_color));
+                    thumbnailView.setBackgroundColor(getResources().getColor(R.color.bg_default));
                 }
             } else {
                 thumbnailView.setImageDrawable(MimeTypeUtil.getFileTypeIcon(file.getMimeType(), file.getFileName(),

+ 2 - 4
src/main/java/com/owncloud/android/ui/activity/SettingsActivity.java

@@ -694,10 +694,8 @@ public class SettingsActivity extends PreferenceActivity
         loadStoragePath();
 
         SwitchPreference themePref = (SwitchPreference) findPreference(getString(R.string.prefs_key_theme));
-        SharedPreferences appPrefs = PreferenceManager.getDefaultSharedPreferences(getApplicationContext());
 
-        themePref.setSummary(appPrefs.getBoolean(com.owncloud.android.db.PreferenceManager.PREF__DARK_THEME,
-                            false) ?
+        themePref.setSummary(preferences.isDarkThemeEnabled() ?
                             getString(R.string.prefs_value_theme_dark) : getString(R.string.prefs_value_theme_light));
         themePref.setOnPreferenceChangeListener((preference, newValue) -> {
             MainApp.setAppTheme((Boolean) newValue);
@@ -741,7 +739,7 @@ public class SettingsActivity extends PreferenceActivity
         Window window = getWindow();
         if (window != null) {
             window.getDecorView().setBackgroundDrawable(new ColorDrawable(ResourcesCompat
-                    .getColor(getResources(), R.color.background_color, null)));
+                    .getColor(getResources(), R.color.bg_default, null)));
 
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
                 window.setStatusBarColor(ThemeUtils.primaryColor(this));

+ 4 - 3
src/main/java/com/owncloud/android/ui/activity/UploadFilesActivity.java

@@ -25,6 +25,7 @@ import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.content.Intent;
 import android.content.res.ColorStateList;
+import android.graphics.PorterDuff;
 import android.graphics.drawable.Drawable;
 import android.os.Bundle;
 import android.os.Environment;
@@ -34,7 +35,6 @@ import android.view.View;
 import android.view.View.OnClickListener;
 import android.view.ViewGroup;
 import android.widget.ArrayAdapter;
-import android.widget.Button;
 import android.widget.EditText;
 import android.widget.ImageView;
 import android.widget.Spinner;
@@ -91,7 +91,7 @@ public class UploadFilesActivity extends FileActivity implements
     private boolean mSelectAll;
     private boolean mLocalFolderPickerMode;
     private LocalFileListFragment mFileListFragment;
-    protected Button mUploadBtn;
+    protected MaterialButton mUploadBtn;
     private Spinner mBehaviourSpinner;
     private Account mAccountOnCreation;
     private DialogFragment mCurrentDialog;
@@ -177,7 +177,8 @@ public class UploadFilesActivity extends FileActivity implements
         mCancelButton.setOnClickListener(this);
 
         mUploadBtn = findViewById(R.id.upload_files_btn_upload);
-        mUploadBtn.setBackgroundColor(ThemeUtils.primaryColor(this,true));
+        mUploadBtn.setBackgroundTintMode(PorterDuff.Mode.SRC_ATOP);
+        mUploadBtn.setBackgroundTintList(ColorStateList.valueOf(ThemeUtils.primaryColor(this, true)));
         mUploadBtn.setOnClickListener(this);
 
         int localBehaviour = preferences.getUploaderBehaviour();

+ 1 - 1
src/main/java/com/owncloud/android/ui/activity/UserInfoActivity.java

@@ -26,7 +26,7 @@
 package com.owncloud.android.ui.activity;
 
 import android.accounts.Account;
-import android.app.AlertDialog;
+import androidx.appcompat.app.AlertDialog;
 import android.app.Dialog;
 import android.graphics.PorterDuff;
 import android.graphics.drawable.ColorDrawable;

+ 1 - 1
src/main/java/com/owncloud/android/ui/adapter/LocalFileListAdapter.java

@@ -155,7 +155,7 @@ public class LocalFileListAdapter extends RecyclerView.Adapter<RecyclerView.View
                     gridViewHolder.checkbox.setImageDrawable(ThemeUtils.tintDrawable(R.drawable.ic_checkbox_marked,
                             ThemeUtils.primaryColor(mContext)));
                 } else {
-                    gridViewHolder.itemLayout.setBackgroundColor(mContext.getResources().getColor(R.color.background_color));
+                    gridViewHolder.itemLayout.setBackgroundColor(mContext.getResources().getColor(R.color.bg_default));
                     gridViewHolder.checkbox.setImageResource(R.drawable.ic_checkbox_blank_outline);
                 }
 

+ 2 - 3
src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java

@@ -30,7 +30,6 @@ import android.content.ContentValues;
 import android.content.Context;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
-import android.graphics.Color;
 import android.graphics.PorterDuff;
 import android.graphics.drawable.Drawable;
 import android.os.Handler;
@@ -330,7 +329,7 @@ public class OCFileListAdapter extends RecyclerView.Adapter<RecyclerView.ViewHol
                 gridViewHolder.checkbox.setImageDrawable(ThemeUtils.tintDrawable(R.drawable.ic_checkbox_marked,
                                                                                  ThemeUtils.primaryColor(mContext)));
             } else {
-                gridViewHolder.itemLayout.setBackgroundColor(mContext.getResources().getColor(R.color.background_color));
+                gridViewHolder.itemLayout.setBackgroundColor(mContext.getResources().getColor(R.color.bg_default));
                 gridViewHolder.checkbox.setImageResource(R.drawable.ic_checkbox_blank_outline);
             }
 
@@ -598,7 +597,7 @@ public class OCFileListAdapter extends RecyclerView.Adapter<RecyclerView.ViewHol
                 }
 
                 if ("image/png".equalsIgnoreCase(file.getMimeType())) {
-                    thumbnailView.setBackgroundColor(mContext.getResources().getColor(R.color.background_color));
+                    thumbnailView.setBackgroundColor(mContext.getResources().getColor(R.color.bg_default));
                 }
             } else {
                 thumbnailView.setImageDrawable(MimeTypeUtil.getFileTypeIcon(file.getMimeType(),

+ 1 - 1
src/main/java/com/owncloud/android/ui/adapter/TrashbinListAdapter.java

@@ -253,7 +253,7 @@ public class TrashbinListAdapter extends RecyclerView.Adapter<RecyclerView.ViewH
                 }
 
                 if ("image/png".equalsIgnoreCase(file.getMimeType())) {
-                    thumbnailView.setBackgroundColor(context.getResources().getColor(R.color.background_color));
+                    thumbnailView.setBackgroundColor(context.getResources().getColor(R.color.bg_default));
                 }
             } else {
                 thumbnailView.setImageDrawable(MimeTypeUtil.getFileTypeIcon(file.getMimeType(), file.getFileName(),

+ 2 - 2
src/main/java/com/owncloud/android/ui/adapter/UploadListAdapter.java

@@ -416,7 +416,7 @@ public class UploadListAdapter extends SectionedRecyclerViewAdapter<SectionedVie
 
             if ("image/png".equals(item.getMimeType())) {
                 itemViewHolder.thumbnail.setBackgroundColor(parentActivity.getResources()
-                        .getColor(R.color.background_color));
+                        .getColor(R.color.bg_default));
             }
 
 
@@ -451,7 +451,7 @@ public class UploadListAdapter extends SectionedRecyclerViewAdapter<SectionedVie
 
             if ("image/png".equalsIgnoreCase(item.getMimeType())) {
                 itemViewHolder.thumbnail.setBackgroundColor(parentActivity.getResources()
-                        .getColor(R.color.background_color));
+                        .getColor(R.color.bg_default));
             }
         } else {
             itemViewHolder.thumbnail.setImageDrawable(MimeTypeUtil.getFileTypeIcon(item.getMimeType(), fileName,

+ 7 - 0
src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.java

@@ -194,6 +194,13 @@ public class ExtendedListFragment extends Fragment implements
         searchView.setOnCloseListener(this);
         ThemeUtils.themeSearchView(searchView, true, requireContext());
 
+
+        SearchView.SearchAutoComplete theTextArea = (SearchView.SearchAutoComplete) searchView.findViewById(R.id.search_src_text);
+        theTextArea.setHighlightColor(ThemeUtils.primaryAccentColor(getContext()));
+
+//        EditText searchText = searchView.findViewById(R.id.searchView);
+//        searchText.setHighlightColor(ThemeUtils.primaryColor(getContext(), true));
+
         final Handler handler = new Handler();
 
         DisplayMetrics displaymetrics = new DisplayMetrics();

+ 4 - 0
src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java

@@ -449,7 +449,11 @@ public class ContactsBackupFragment extends FileFragment implements DatePickerDi
                 }
             });
 
+            datePickerDialog.setTitle("");
             datePickerDialog.show();
+            // TODO How do we deal with primary colours that are too light or dark
+            datePickerDialog.getButton(DatePickerDialog.BUTTON_NEGATIVE).setTextColor(ThemeUtils.primaryColor(getContext()));
+            datePickerDialog.getButton(DatePickerDialog.BUTTON_POSITIVE).setTextColor(ThemeUtils.primaryColor(getContext()));
         } else {
             DisplayUtils.showSnackMessage(getView().findViewById(R.id.contacts_linear_layout),
                     R.string.contacts_preferences_something_strange_happened);

+ 2 - 2
src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.java

@@ -617,7 +617,7 @@ public class PreviewImageFragment extends FileFragment implements Injectable {
     private LayerDrawable generateCheckerboardLayeredDrawable(LoadImage result, Bitmap bitmap) {
         Resources r = getResources();
         Drawable[] layers = new Drawable[2];
-        layers[0] = r.getDrawable(R.color.background_color);
+        layers[0] = r.getDrawable(R.color.bg_default);
         Drawable bitmapDrawable;
 
         if (MIME_TYPE_PNG.equalsIgnoreCase(result.ocFile.getMimeType())) {
@@ -766,7 +766,7 @@ public class PreviewImageFragment extends FileFragment implements Injectable {
                 Drawable layerOne;
 
                 if (previewImageActivity.isSystemUIVisible()) {
-                    layerOne = getResources().getDrawable(R.color.background_color);
+                    layerOne = getResources().getDrawable(R.color.bg_default);
                 } else {
                     layerOne = getResources().getDrawable(R.drawable.backrepeat);
                 }

+ 1 - 1
src/main/res/drawable/list_selector.xml

@@ -22,6 +22,6 @@
 
     <item android:drawable="@color/owncloud_blue_bright" android:state_pressed="true"/>
     <item android:drawable="@color/owncloud_blue_bright" android:state_focused="true"/>
-    <item android:drawable="@color/background_color" />
+    <item android:drawable="@color/bg_default" />
 
 </selector>

+ 2 - 1
src/main/res/layout/accounts_layout.xml

@@ -24,7 +24,8 @@
 	xmlns:android="http://schemas.android.com/apk/res/android"
 	android:layout_width="fill_parent"
 	android:layout_height="fill_parent"
-	android:orientation="vertical">
+	android:orientation="vertical"
+    android:background="@color/bg_default">
 
 	<include
 		layout="@layout/toolbar_standard"/>

+ 1 - 1
src/main/res/layout/activity_list_item.xml

@@ -26,7 +26,7 @@
     android:paddingRight="@dimen/standard_padding"
     android:paddingBottom="@dimen/standard_padding"
     android:paddingLeft="@dimen/standard_padding"
-    android:background="@color/background_color">
+    android:background="@color/bg_default">
 
     <ImageView
         android:id="@+id/activity_icon"

+ 1 - 1
src/main/res/layout/activity_list_layout.xml

@@ -57,7 +57,7 @@
                     android:scrollbarStyle="outsideOverlay"
                     android:scrollbars="vertical"
                     android:visibility="visible"
-                    android:background="@color/background_color" />
+                    android:background="@color/bg_default" />
 
             </androidx.swiperefreshlayout.widget.SwipeRefreshLayout>
 

+ 4 - 4
src/main/res/layout/community_layout.xml

@@ -140,7 +140,7 @@
                         android:id="@+id/community_release_candidate_fdroid"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
-                        android:background="@color/background_color"
+                        android:background="@color/bg_default"
                         android:onClick="onGetRCFDroidClick"
                         android:padding="@dimen/zero"
                         android:src="@drawable/fdroid"
@@ -150,7 +150,7 @@
                         android:id="@+id/community_release_candidate_playstore"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
-                        android:background="@color/background_color"
+                        android:background="@color/bg_default"
                         android:onClick="onGetRCPlayStoreClick"
                         android:padding="@dimen/zero"
                         android:src="@drawable/playstore"
@@ -181,7 +181,7 @@
                     android:id="@+id/community_beta_fdroid"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:background="@color/background_color"
+                    android:background="@color/bg_default"
                     android:onClick="onGetBetaFDroidClick"
                     android:padding="@dimen/zero"
                     android:src="@drawable/fdroid"
@@ -191,7 +191,7 @@
                     android:id="@+id/community_beta_apk"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:background="@color/background_color"
+                    android:background="@color/bg_default"
                     android:onClick="onGetBetaApkClick"
                     android:padding="@dimen/zero"
                     android:src="@drawable/apk"

+ 1 - 1
src/main/res/layout/contactlist_fragment.xml

@@ -39,7 +39,7 @@
             android:id="@+id/contactlist_restore_selected_container"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:background="@color/background_color"
+            android:background="@color/bg_default"
             android:orientation="vertical"
             android:visibility="gone">
 

+ 2 - 1
src/main/res/layout/contacts_backup_fragment.xml

@@ -22,7 +22,8 @@
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:id="@+id/contacts_linear_layout"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="match_parent"
+    android:background="@color/bg_default">
 
     <LinearLayout
         android:layout_width="match_parent"

+ 1 - 1
src/main/res/layout/drawer.xml

@@ -37,7 +37,7 @@
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_gravity="bottom"
-            android:background="@color/background_color"
+            android:background="@color/bg_default"
             android:clickable="false"
             android:orientation="vertical"
             android:paddingLeft="@dimen/standard_padding"

+ 2 - 2
src/main/res/layout/file_details_fragment.xml

@@ -134,7 +134,7 @@
                     android:id="@+id/overflow_menu"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:background="@color/background_color"
+                    android:background="@color/bg_default"
                     android:contentDescription="@string/overflow_menu"
                     android:src="@drawable/ic_dots_vertical" />
             </LinearLayout>
@@ -193,7 +193,7 @@
                 android:id="@+id/tab_layout"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:background="@color/background_color"
+                android:background="@color/bg_default"
                 app:tabGravity="center"
                 app:tabMode="fixed"
                 app:tabTextColor="@color/textColor"

+ 1 - 1
src/main/res/layout/file_list_actions_bottom_sheet_fragment.xml

@@ -21,7 +21,7 @@
               android:layout_width="match_parent"
               android:layout_height="wrap_content"
               android:orientation="vertical"
-              android:background="@color/background_color">
+              android:background="@color/bg_default">
 
     <TextView
         android:id="@+id/add_to_cloud"

+ 1 - 1
src/main/res/layout/files.xml

@@ -37,7 +37,7 @@
         <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="match_parent"
-            android:background="@color/background_color"
+            android:background="@color/bg_default"
             android:baselineAligned="false"
             android:orientation="horizontal"
             android:id="@+id/ListLayout"

+ 1 - 1
src/main/res/layout/generic_explanation.xml

@@ -19,7 +19,7 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    android:background="@color/background_color"
+    android:background="@color/bg_default"
     android:id="@+id/explanation"
     android:orientation="vertical">
 

+ 6 - 6
src/main/res/layout/sorting_order_fragment.xml

@@ -53,7 +53,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_gravity="center_vertical"
-                    android:background="@color/background_color"
+                    android:background="@color/bg_default"
                     android:paddingBottom="@dimen/standard_half_padding"
                     android:paddingLeft="@dimen/standard_padding"
                     android:paddingStart="@dimen/standard_padding"
@@ -92,7 +92,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_gravity="center_vertical"
-                    android:background="@color/background_color"
+                    android:background="@color/bg_default"
                     android:paddingBottom="@dimen/standard_half_padding"
                     android:paddingLeft="@dimen/standard_padding"
                     android:paddingStart="@dimen/standard_padding"
@@ -132,7 +132,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_gravity="center_vertical"
-                    android:background="@color/background_color"
+                    android:background="@color/bg_default"
                     android:paddingBottom="@dimen/standard_half_padding"
                     android:paddingLeft="@dimen/standard_padding"
                     android:paddingStart="@dimen/standard_padding"
@@ -171,7 +171,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_gravity="center_vertical"
-                    android:background="@color/background_color"
+                    android:background="@color/bg_default"
                     android:paddingBottom="@dimen/standard_half_padding"
                     android:paddingLeft="@dimen/standard_padding"
                     android:paddingStart="@dimen/standard_padding"
@@ -212,7 +212,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_gravity="center_vertical"
-                    android:background="@color/background_color"
+                    android:background="@color/bg_default"
                     android:paddingBottom="@dimen/standard_half_padding"
                     android:paddingLeft="@dimen/standard_padding"
                     android:paddingStart="@dimen/standard_padding"
@@ -251,7 +251,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_gravity="center_vertical"
-                    android:background="@color/background_color"
+                    android:background="@color/bg_default"
                     android:paddingBottom="@dimen/standard_half_padding"
                     android:paddingLeft="@dimen/standard_padding"
                     android:paddingStart="@dimen/standard_padding"

+ 1 - 1
src/main/res/layout/storage_path_item.xml

@@ -50,7 +50,7 @@
         android:ellipsize="end"
         android:gravity="center_vertical"
         android:singleLine="true"
-        android:textColor="@color/textColor"
+        android:textColor="@color/fg_default"
         android:textSize="@dimen/file_details_username_text_size"
         tools:text="DCIM" />
 </LinearLayout>

+ 1 - 1
src/main/res/layout/toolbar_standard.xml

@@ -24,7 +24,7 @@
                                             android:id="@+id/appbar"
                                             android:layout_width="match_parent"
                                             android:layout_height="wrap_content"
-                                            android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar">
+                                            android:theme="@style/ThemeOverlay.MaterialComponents.Dark.ActionBar">
 
     <RelativeLayout
         android:layout_width="match_parent"

+ 2 - 1
src/main/res/layout/user_info_layout.xml

@@ -22,7 +22,8 @@
                                                  xmlns:app="http://schemas.android.com/apk/res-auto"
                                                  xmlns:card_view="http://schemas.android.com/apk/res-auto"
                                                  android:layout_width="match_parent"
-                                                 android:layout_height="match_parent">
+                                                 android:layout_height="match_parent"
+                                                 android:background="@color/bg_default">
 
     <include
         layout="@layout/toolbar_user_information"/>

+ 8 - 5
src/main/res/values-night/colors.xml

@@ -36,8 +36,9 @@
 
     <!-- Colors -->
     <color name="standard_grey">#757575</color>
-    <!--<color name="elementFallbackColor">#555555</color>-->
+    <color name="elementFallbackColor">#555555</color>
     <color name="grey_200">#EEEEEE</color>
+    <color name="actionbar_shadow">#222222</color>
 
     <!-- standard material color definitions -->
 
@@ -53,7 +54,7 @@
     <color name="login_text_hint_color">#7fC0E3</color>
     <color name="login_btn_tint">#ffffff</color>
     <color name="login_asset">#ffffff</color>
-    <color name="background_color">#222222</color>
+    <color name="bg_default">#222222</color>
     <color name="background_color_inverse">#000000</color>
     <color name="primary_button_background_color">@color/color_accent</color>
     <color name="primary_button_text_color">#000000</color>
@@ -71,13 +72,15 @@
     <color name="color_dark_transparent">#40162233</color>
 
     <!-- Multiselect backgrounds -->
-    <color name="action_mode_background">#D6D7D7</color>
+    <color name="action_mode_background">#757575</color>
     <color name="action_mode_status_bar_background">#ECECEC</color>
-    <color name="selected_item_background">#616161</color>
+    <color name="selected_item_background">#757575</color>
 
     <!--<color name="background_material_light">#555555</color>-->
     <color name="drawer_menu_icon">#ffffff</color>
     <color name="date_picker_header_text">#616161</color>
-    <color name="date_picker_header_bg">#111111</color>
+    <color name="bg_fallback_highlight">#737373</color>
+    <color name="switchpref_track">#4DFFFFFF</color>
 
+    <color name="bg_fallback_activated">#525252</color>
 </resources>

+ 1 - 1
src/main/res/values-v21/styles.xml

@@ -32,6 +32,6 @@
 
     <style name="Theme.ownCloud.Toolbar.Drawer">
         <item name="android:statusBarColor">@android:color/transparent</item>
-        <item name="android:colorBackground">@color/background_color</item>
+        <item name="android:colorBackground">@color/bg_default</item>
     </style>
 </resources>

+ 6 - 2
src/main/res/values/colors.xml

@@ -57,8 +57,9 @@
     <color name="login_text_color">#ffffff</color>
     <color name="login_text_hint_color">#7fC0E3</color>
     <color name="login_btn_tint">#ffffff</color>
+    <color name="login_btn_stroke">#ffffff</color>
     <color name="login_asset">#ffffff</color>
-    <color name="background_color">#FFFFFF</color>
+    <color name="bg_default">#FFFFFF</color>
     <color name="background_color_inverse">#000000</color>
     <color name="primary_button_background_color">@color/color_accent</color>
     <color name="primary_button_text_color">#ffffff</color>
@@ -83,10 +84,13 @@
     <!--<color name="background_material_light">#ef4</color>-->
     <color name="drawer_menu_icon">#757575</color>
     <color name="date_picker_header_text">#ffffff</color>
-    <color name="date_picker_header_bg">#757575</color>
+    <color name="bg_fallback_highlight">#616161</color>
+    <color name="switchpref_track">#4D000000</color>
 
     <!-- Excluded from future app dark theme -->
     <color name="themed_fg">#FFFFFF</color>
     <color name="themed_fg_inverse">#000000</color>
 
+    <color name="bg_fallback_activated">#737373</color>
+
 </resources>

+ 37 - 41
src/main/res/values/styles.xml

@@ -23,21 +23,15 @@
 	<style name="Theme.ownCloud" parent="Theme.MaterialComponents.DayNight.DarkActionBar">
     	<item name="android:actionBarStyle">@style/Theme.ownCloud.Widget.ActionBar</item>
     	<item name="actionBarStyle">@style/Theme.ownCloud.Widget.ActionBar</item>
-		<item name="actionModeBackground">@color/action_mode_background</item>
-		<!--<item name="actionBarPopupTheme">@style/ThemeOverlay.AppCompat.Light</item>-->
-		<item name="actionBarPopupTheme">@style/ThemeOverlay.AppTheme.PopupMenu</item>
-        <item name="android:actionBarPopupTheme">@style/ThemeOverlay.AppTheme.PopupMenu</item>
-		<item name="colorPrimary">@color/primary</item>
-		<item name="colorPrimaryDark">@color/primary_dark</item>
-		<item name="colorAccent">@color/color_accent</item>
-		<item name="android:alertDialogTheme">@style/Theme.ownCloud.Dialog</item>
-		<item name="alertDialogTheme">@style/ownCloud.AlertDialog</item>
-		<item name="android:windowBackground">@color/background_color</item>
-		<item name="searchViewStyle">@style/ownCloud.SearchView</item>
+        <item name="actionModeBackground">@color/action_mode_background</item>
+        <item name="actionBarPopupTheme">@style/ThemeOverlay.AppTheme.PopupMenu</item>
+        <item name="colorPrimary">@color/primary</item>
+        <item name="colorPrimaryDark">@color/primary_dark</item>
+        <item name="colorAccent">@color/color_accent</item>
+        <item name="android:alertDialogTheme">@style/ownCloud.AlertDialog</item>
+        <item name="searchViewStyle">@style/ownCloud.SearchView</item>
         <item name="android:textColor">@color/textColor</item>
         <item name="colorSecondary">@color/textColor</item>
-        <item name="android:colorSecondary">@color/textColor</item>
-        <item name="android:datePickerDialogTheme">@style/FallbackDatePickerDialogTheme</item>
     </style>
 
 	<style name="FallbackThemingTheme" parent="Theme.MaterialComponents.DayNight.DarkActionBar">
@@ -46,37 +40,34 @@
 		<item name="colorAccent">#757575</item>
         <item name="android:textAllCaps">false</item>
         <item name="android:textColor">@color/textColor</item>
-        <item name="colorSecondary">@color/textColor</item>
-        <item name="android:colorSecondary">@color/textColor</item>
+        <item name="android:alertDialogTheme">@style/FallbackTheming.Dialog</item>
+        <item name="dialogTheme">@style/FallbackTheming.Dialog</item>
+        <item name="android:windowBackground">@color/bg_default</item>
         <item name="android:datePickerDialogTheme">@style/FallbackDatePickerDialogTheme</item>
     </style>
 
-	<style name="FallbackDatePickerDialogTheme" parent="Theme.MaterialComponents.DayNight.Dialog">
-		<item name="colorPrimary">#424242</item>
-		<item name="colorPrimaryDark">#212121</item>
-        <item name="android:colorAccent">@color/date_picker_header_bg</item>
-        <item name="colorAccent">@color/date_picker_header_bg</item>
+	<style name="FallbackDatePickerDialogTheme" parent="Theme.MaterialComponents.DayNight.Dialog.Alert">
+        <!-- TODO change these reference names -->
         <item name="android:textAllCaps">false</item>
-        <item name="android:windowBackground">@color/background_color</item>
-        <item name="android:textColor">@color/textColor</item>
+        <item name="android:windowBackground">@color/bg_default</item>
+        <item name="android:textColor">@color/textColor_inverse</item>
         <item name="android:datePickerStyle">@style/DatePickerStyle</item>
-        <!--&lt;!&ndash; TODO change these references &ndash;&gt;-->
-        <item name="colorControlHighlight">@color/date_picker_header_bg</item>
-        <item name="colorControlActivated">@color/textColor</item>
+        <item name="colorControlHighlight">@color/bg_fallback_highlight</item>
+        <item name="colorControlActivated">@color/bg_fallback_highlight</item>
     </style>
 
-    <style name="DatePickerStyle" parent="Theme.MaterialComponents.DayNight.Dialog">
-        <item name="android:headerBackground">@color/date_picker_header_bg</item>
+    <style name="DatePickerStyle" parent="">
+        <item name="android:headerBackground">@color/bg_fallback_highlight</item>
+        <!-- TODO for < API21 -->
         <item name="android:datePickerMode">calendar</item>
     </style>
 
-    <style name="FallbackTheming.Dialog" parent="Theme.MaterialComponents.DayNight.Dialog.Alert">
+    <style name="FallbackTheming.Dialog" parent="Theme.MaterialComponents.DayNight.Dialog">
 		<item name="colorPrimary">#424242</item>
 		<item name="colorPrimaryDark">#212121</item>
 		<item name="colorAccent">#757575</item>
 		<item name="windowNoTitle">false</item>
-		<item name="buttonBarButtonStyle">@style/Theme.ownCloud.Dialog.ButtonBar.Button</item>
-		<item name="buttonBarStyle">@style/Theme.ownCloud.Dialog.ButtonBar</item>
+        <item name="android:windowBackground">@color/bg_default</item>
 	</style>
 
 	<!-- separate action bar style for activities without an action bar -->
@@ -88,7 +79,7 @@
 		<item name="colorAccent">@color/color_accent</item>
 		<item name="android:alertDialogTheme">@style/Theme.ownCloud.Dialog</item>
 		<item name="alertDialogTheme">@style/ownCloud.AlertDialog</item>
-		<item name="android:windowBackground">@color/background_color</item>
+		<item name="android:windowBackground">@color/bg_default</item>
 		<item name="searchViewStyle">@style/ownCloud.SearchView</item>
 		<item name="windowActionModeOverlay">true</item>
     </style>
@@ -111,7 +102,7 @@
 		<item name="android:textColorPrimary">@color/primary</item>
 		<item name="searchViewStyle">@style/ownCloud.SearchView</item>
         <item name="android:textAllCaps">false</item>
-        <item name="android:colorBackground">@color/background_color</item>
+        <item name="android:windowBackground">@color/bg_default</item>
     </style>
 
 	<style name="ownCloud.Dialog" parent="Theme.MaterialComponents.DayNight.Dialog">
@@ -153,7 +144,7 @@
         <item name="colorAccent">@color/transparent</item>
         <item name="android:textColor">@color/textColor</item>
         <item name="android:textAllCaps">false</item>
-        <item name="strokeColor">@color/textColor</item>
+        <item name="strokeColor">@color/login_btn_stroke</item>
     </style>
 
 	<style name="Button.Primary" parent="Button">
@@ -232,9 +223,7 @@
 	<style name="Theme.ownCloud.Dialog" parent="@style/Theme.MaterialComponents.DayNight.Dialog.Alert">
 		<item name="windowNoTitle">false</item>
 		<item name="colorAccent">@color/color_accent</item>
-		<item name="buttonBarButtonStyle">@style/Theme.ownCloud.Dialog.ButtonBar.Button</item>
-		<item name="buttonBarStyle">@style/Theme.ownCloud.Dialog.ButtonBar</item>
-        <item name="android:windowBackground">@color/background_color</item>
+        <item name="android:windowBackground">@color/bg_default</item>
     </style>
 
 	<style name="Theme.ownCloud.Dialog.NoTitle" parent="@style/Theme.ownCloud.Dialog">
@@ -250,6 +239,8 @@
 	<style name="NavigationView_ItemTextAppearance">
 		<item name="android:ellipsize">end</item>
 		<item name="android:listDivider">@color/transparent</item>
+
+        <!-- TODO are these two necessary -->
 		<item name="android:textColor">@color/textColor</item>
 		<item name="android:color">@color/textColor</item>
 	</style>
@@ -275,6 +266,7 @@
 		<!-- setting a fixed width as follows results in narrow buttons with line breaks, but of course this is not a solution -->
 		<!-- <item name="android:width">100dp</item> -->
         <item name="android:textAllCaps">false</item>
+        <item name="backgroundTint">@color/bg_default</item>
 	</style>
 
     <style name="PassCodeStyle">
@@ -303,12 +295,16 @@
 	<style name="NextcloudTextAppearanceMedium" parent="@style/TextAppearance.AppCompat.Medium">
 	</style>
 
-	<style name="TextInputLayout" parent="Widget.MaterialComponents.TextInputLayout.OutlinedBox">
+    <style name="TextInputLayout" parent="Base.Widget.MaterialComponents.TextInputEditText"></style>
+
+    <style name="Nextcloud.TextInputLayout.Login" parent="Widget.MaterialComponents.TextInputLayout.FilledBox">
+        <item name="boxBackgroundColor">@color/primary</item>
+        <item name="android:textColorHint">@color/fg_inverse</item>
 	</style>
-	<style name="EditText" parent="Theme.MaterialComponents.DayNight">
+
+	<style name="Nextcloud.EditText.Login" parent="ThemeOverlay.MaterialComponents.TextInputEditText">
+        <item name="colorControlNormal">@color/login_text_color</item>
 		<item name="colorControlActivated">@color/login_text_color</item>
-		<item name="colorControlNormal">@color/login_text_color</item>
-		<item name="android:textColorHint">@color/login_text_color</item>
 	</style>
 
 	<style name="AppTabTextAppearance" parent="@style/TextAppearance.Design.Tab">
@@ -319,7 +315,7 @@
 
     <style name="ThemeOverlay.AppTheme.PopupMenu" parent="ThemeOverlay.MaterialComponents.Dark">
         <!-- popup menu background - NEVER "android:background" !!! in themes -->
-        <item name="android:colorBackground">@color/background_color</item>
+        <item name="android:colorBackground">@color/bg_default</item>
         <!-- popup menu item text color -->
         <item name="android:textColorPrimary">@color/textColor</item>
     </style>