浏览代码

Fix magic numbers in media_control.xml #12

Divay Prakash 8 年之前
父节点
当前提交
8dcbd21473
共有 2 个文件被更改,包括 13 次插入11 次删除
  1. 11 11
      res/layout/media_control.xml
  2. 2 0
      res/values/dims.xml

+ 11 - 11
res/layout/media_control.xml

@@ -27,7 +27,7 @@
         android:layout_width="match_parent"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_height="wrap_content"
         android:gravity="center"
         android:gravity="center"
-        android:paddingTop="4dp"
+        android:paddingTop="@dimen/standard_quarter_padding"
         android:orientation="horizontal"
         android:orientation="horizontal"
         >
         >
 
 
@@ -56,35 +56,35 @@
 
 
         <TextView 
         <TextView 
             android:id="@+id/currentTimeText"
             android:id="@+id/currentTimeText"
-            android:textSize="14sp"
+            android:textSize="@dimen/two_line_secondary_text_size"
             android:textStyle="bold"
             android:textStyle="bold"
-            android:paddingTop="4dp"
-            android:paddingStart="4dp"
+            android:paddingTop="@dimen/standard_quarter_padding"
+            android:paddingStart="@dimen/standard_quarter_padding"
             android:layout_gravity="center_horizontal"
             android:layout_gravity="center_horizontal"
             android:layout_width="wrap_content"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_height="wrap_content"
-            android:paddingEnd="4dp"
+            android:paddingEnd="@dimen/standard_quarter_padding"
             android:text="@string/placeholder_media_time"
             android:text="@string/placeholder_media_time"
             />
             />
 
 
         <SeekBar
         <SeekBar
             android:id="@+id/progressBar"
             android:id="@+id/progressBar"
             style="?android:attr/progressBarStyleHorizontal"
             style="?android:attr/progressBarStyleHorizontal"
-            android:layout_width="0dp"
+            android:layout_width="@dimen/zero"
             android:layout_weight="1"
             android:layout_weight="1"
-            android:layout_height="32dp"
+            android:layout_height="@dimen/seek_bar_height"
             android:layout_alignParentStart="true"
             android:layout_alignParentStart="true"
             android:layout_alignParentEnd="true" />
             android:layout_alignParentEnd="true" />
 
 
         <TextView android:id="@+id/totalTimeText"
         <TextView android:id="@+id/totalTimeText"
-            android:textSize="14sp"
+            android:textSize="@dimen/two_line_secondary_text_size"
             android:textStyle="bold"
             android:textStyle="bold"
-            android:paddingTop="4dp"
-            android:paddingEnd="4dp"
+            android:paddingTop="@dimen/standard_quarter_padding"
+            android:paddingEnd="@dimen/standard_quarter_padding"
             android:layout_gravity="center_horizontal"
             android:layout_gravity="center_horizontal"
             android:layout_width="wrap_content"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_height="wrap_content"
-            android:paddingStart="4dp"
+            android:paddingStart="@dimen/standard_quarter_padding"
             android:text="@string/placeholder_media_time"
             android:text="@string/placeholder_media_time"
             />
             />
         
         

+ 2 - 0
res/values/dims.xml

@@ -99,4 +99,6 @@
 
 
     <dimen name="listrow_group_text_size">16dp</dimen>
     <dimen name="listrow_group_text_size">16dp</dimen>
     <dimen name="log_item_text_size">22dp</dimen>
     <dimen name="log_item_text_size">22dp</dimen>
+
+    <dimen name="seek_bar_height">32dp</dimen>
 </resources>
 </resources>