Browse Source

Fixed wrong onOptionsItemSelected implementations

David A. Velasco 8 years ago
parent
commit
936c182c3a

+ 3 - 3
src/com/owncloud/android/ui/activity/LogHistoryActivity.java

@@ -115,15 +115,15 @@ public class LogHistoryActivity extends AppCompatActivity {
 
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
-        super.onOptionsItemSelected(item);
+        boolean retval = true;
         switch (item.getItemId()) {
             case android.R.id.home:
                 finish();
                 break;
             default:
-                return false;
+                retval = super.onOptionsItemSelected(item);
         }
-        return true;
+        return retval;
     }
 
 

+ 4 - 3
src/com/owncloud/android/ui/activity/ManageSpaceActivity.java

@@ -68,15 +68,16 @@ public class ManageSpaceActivity extends AppCompatActivity {
 
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
-        super.onOptionsItemSelected(item);
+        boolean retval = true;
         switch (item.getItemId()) {
             case android.R.id.home:
                 finish();
-                return true;
+                break;
             default:
                 Log_OC.w(TAG, "Unknown menu item triggered");
-                return false;
+                retval =  super.onOptionsItemSelected(item);
         }
+        return retval;
     }
 
     /**

+ 1 - 1
src/com/owncloud/android/ui/fragment/FileDetailFragment.java

@@ -293,7 +293,7 @@ public class FileDetailFragment extends FileFragment implements OnClickListener
                 return true;
             }
             default:
-                return false;
+                return super.onOptionsItemSelected(item);
         }
     }
 

+ 1 - 1
src/com/owncloud/android/ui/preview/PreviewImageFragment.java

@@ -319,7 +319,7 @@ public class PreviewImageFragment extends FileFragment {
                 return true;
             }
             default:
-                return false;
+                return super.onOptionsItemSelected(item);
         }
     }
 

+ 1 - 1
src/com/owncloud/android/ui/preview/PreviewMediaFragment.java

@@ -382,7 +382,7 @@ public class PreviewMediaFragment extends FileFragment implements
                 return true;
             }
             default:
-                return false;
+                return super.onOptionsItemSelected(item);
         }
     }
 

+ 1 - 1
src/com/owncloud/android/ui/preview/PreviewTextFragment.java

@@ -358,7 +358,7 @@ public class PreviewTextFragment extends FileFragment {
             }
 
             default:
-                return false;
+                return super.onOptionsItemSelected(item);
         }
     }