Explorar el Código

codacy: using varargs for methods and constructors which take an array the last parameter

AndyScherzinger hace 6 años
padre
commit
98ebd9b8c8

+ 1 - 1
src/main/java/com/owncloud/android/datamodel/UploadsStorageManager.java

@@ -275,7 +275,7 @@ public class UploadsStorageManager extends Observable {
         return getUploads(null, null);
     }
 
-    private OCUpload[] getUploads(@Nullable String selection, @Nullable String[] selectionArgs) {
+    private OCUpload[] getUploads(@Nullable String selection, @Nullable String... selectionArgs) {
         OCUpload[] list;
 
         Cursor c = getDB().query(

+ 2 - 2
src/main/java/com/owncloud/android/providers/FileContentProvider.java

@@ -109,7 +109,7 @@ public class FileContentProvider extends ContentProvider {
         return count;
     }
 
-    private int delete(SQLiteDatabase db, Uri uri, String where, String[] whereArgs) {
+    private int delete(SQLiteDatabase db, Uri uri, String where, String... whereArgs) {
         if (isCallerNotAllowed()) {
             return -1;
         }
@@ -659,7 +659,7 @@ public class FileContentProvider extends ContentProvider {
             Uri uri,
             ContentValues values,
             String selection,
-            String[] selectionArgs
+            String... selectionArgs
     ) {
         switch (mUriMatcher.match(uri)) {
             case DIRECTORY:

+ 1 - 1
src/main/java/com/owncloud/android/ui/activity/StorageMigration.java

@@ -269,7 +269,7 @@ public class StorageMigration {
             }
         }
 
-        protected void restoreAccountsSyncStatus(boolean oldSync[]) {
+        protected void restoreAccountsSyncStatus(boolean... oldSync) {
             // If we don't have the old sync statuses, then
             // probably migration failed even before saving states,
             // which is weird and should be investigated.

+ 1 - 1
src/main/java/com/owncloud/android/ui/activity/SyncedFoldersActivity.java

@@ -423,7 +423,7 @@ public class SyncedFoldersActivity extends FileActivity implements SyncedFolderA
         return files;
     }
 
-    private List<String> getDisplayFilePathList(File[] files) {
+    private List<String> getDisplayFilePathList(File... files) {
         List<String> filePaths = null;
 
         if (files != null && files.length > 0) {

+ 1 - 1
src/main/java/com/owncloud/android/ui/adapter/UploadListAdapter.java

@@ -605,7 +605,7 @@ public class UploadListAdapter extends SectionedRecyclerViewAdapter<SectionedVie
             return items[position];
         }
 
-        public void setItems(OCUpload[] items) {
+        public void setItems(OCUpload... items) {
             this.items = items;
         }
 

+ 1 - 1
src/main/java/com/owncloud/android/ui/dialog/ShareLinkToDialog.java

@@ -65,7 +65,7 @@ public class ShareLinkToDialog  extends DialogFragment {
     private ActivityAdapter mAdapter;
     private Intent mIntent;
     
-    public static ShareLinkToDialog newInstance(Intent intent, String[] packagesToExclude) {
+    public static ShareLinkToDialog newInstance(Intent intent, String... packagesToExclude) {
         ShareLinkToDialog f = new ShareLinkToDialog();
         Bundle args = new Bundle();
         args.putParcelable(ARG_INTENT, intent);

+ 1 - 1
src/main/java/com/owncloud/android/ui/helpers/FileOperationsHelper.java

@@ -343,7 +343,7 @@ public class FileOperationsHelper {
         return openFileWithIntent;
     }
 
-    private Uri getFileUri(OCFile file, String[] officeExtensions) {
+    private Uri getFileUri(OCFile file, String... officeExtensions) {
         if (file.getFileName().contains(".") &&
                 Arrays.asList(officeExtensions).contains(file.getFileName().substring(file.getFileName().
                         lastIndexOf(".") + 1, file.getFileName().length())) &&

+ 1 - 1
src/main/java/com/owncloud/android/ui/helpers/UriUploader.java

@@ -177,7 +177,7 @@ public class UriUploader {
      * @param sourceUris        Array of content:// URIs to the files to upload
      * @param remotePaths       Array of absolute paths to set to the uploaded files
      */
-    private void copyThenUpload(Uri[] sourceUris, String[] remotePaths) {
+    private void copyThenUpload(Uri[] sourceUris, String... remotePaths) {
         if (mShowWaitingDialog) {
             mActivity.showLoadingDialog(mActivity.getResources().
                     getString(R.string.wait_for_tmp_copy_from_private_storage));

+ 1 - 1
src/main/java/com/owncloud/android/utils/UriUtils.java

@@ -57,7 +57,7 @@ public class UriUtils {
      * @param selectionArgs (Optional) Selection arguments used in the query.
      * @return The value of the _data column, which is typically a file path.
      */
-    public static String getDataColumn(Context context, Uri uri, String selection, String[] selectionArgs) {
+    public static String getDataColumn(Context context, Uri uri, String selection, String... selectionArgs) {
 
         Cursor cursor = null;
         final String column = "_data";

+ 1 - 1
src/main/java/org/nextcloud/providers/cursors/FileCursor.java

@@ -37,7 +37,7 @@ public class FileCursor extends MatrixCursor {
             Document.COLUMN_FLAGS, Document.COLUMN_LAST_MODIFIED
     };
 
-    public FileCursor(String[] projection) {
+    public FileCursor(String... projection) {
         super(projection != null ? projection : DEFAULT_DOCUMENT_PROJECTION);
     }
 

+ 1 - 1
src/main/java/org/nextcloud/providers/cursors/RootCursor.java

@@ -41,7 +41,7 @@ public class RootCursor extends MatrixCursor {
             Root.COLUMN_FLAGS
     };
 
-    public RootCursor(String[] projection) {
+    public RootCursor(String... projection) {
         super(projection != null ? projection : DEFAULT_ROOT_PROJECTION);
     }