Przeglądaj źródła

codacy: String.indexOf(char) is faster than String.indexOf(String).

AndyScherzinger 6 lat temu
rodzic
commit
a4eafbf757

+ 2 - 2
src/main/java/com/owncloud/android/datamodel/MediaProvider.java

@@ -119,9 +119,9 @@ public final class MediaProvider {
                                 MediaStore.MediaColumns.DATA));
 
                         // check if valid path
-                        if (filePath != null && filePath.lastIndexOf("/") > 0) {
+                        if (filePath != null && filePath.lastIndexOf('/') > 0) {
                             mediaFolder.filePaths.add(filePath);
-                            mediaFolder.absolutePath = filePath.substring(0, filePath.lastIndexOf("/"));
+                            mediaFolder.absolutePath = filePath.substring(0, filePath.lastIndexOf('/'));
                         }
                     }
                     cursorImages.close();

+ 1 - 1
src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java

@@ -528,7 +528,7 @@ public class ReceiveExternalFilesActivity extends FileActivity
             String filename = mFilenameBase.get(selectPos) + mFilenameSuffix.get(selectPos);
             inputText.setText(filename);
             int selectionStart = 0;
-            int extensionStart = filename.lastIndexOf(".");
+            int extensionStart = filename.lastIndexOf('.');
             int selectionEnd = extensionStart >= 0 ? extensionStart : filename.length();
             if (selectionEnd >= 0) {
                 inputText.setSelection(

+ 3 - 3
src/main/java/com/owncloud/android/ui/adapter/ActivityListAdapter.java

@@ -299,10 +299,10 @@ public class ActivityListAdapter extends RecyclerView.Adapter<RecyclerView.ViewH
         String text = richElement.getRichSubject();
         SpannableStringBuilder ssb = new SpannableStringBuilder(text);
 
-        int idx1 = text.indexOf("{");
+        int idx1 = text.indexOf('{');
         int idx2;
         while (idx1 != -1) {
-            idx2 = text.indexOf("}", idx1) + 1;
+            idx2 = text.indexOf('}', idx1) + 1;
             final String clickString = text.substring(idx1 + 1, idx2 - 1);
             final RichObject richObject = searchObjectByName(richElement.getRichObjectList(), clickString);
             if (richObject != null) {
@@ -324,7 +324,7 @@ public class ActivityListAdapter extends RecyclerView.Adapter<RecyclerView.ViewH
                 ssb.setSpan(new StyleSpan(android.graphics.Typeface.BOLD), idx1, idx2, 0);
                 ssb.setSpan(new ForegroundColorSpan(Color.BLACK), idx1, idx2, Spannable.SPAN_EXCLUSIVE_EXCLUSIVE);
             }
-            idx1 = text.indexOf("{", idx2);
+            idx1 = text.indexOf('{', idx2);
         }
 
         return ssb;