Browse Source

minor code cleanups due to code review

AndyScherzinger 7 years ago
parent
commit
a9100e5d8e

+ 2 - 11
src/main/java/com/owncloud/android/datamodel/OCFile.java

@@ -243,7 +243,7 @@ public class OCFile implements Parcelable, Comparable<OCFile> {
      *
      * @return true if it is
      */
-    public boolean existsOnDevice() {
+    private boolean existsOnDevice() {
         if (mLocalPath != null && mLocalPath.length() > 0) {
             File file = new File(mLocalPath);
             return (file.exists());
@@ -510,15 +510,6 @@ public class OCFile implements Parcelable, Comparable<OCFile> {
         return (parentPath.endsWith("/")) ? parentPath : (parentPath + "/");
     }
 
-    /**
-     * Check, if this file needs updating
-     *
-     * @return
-     */
-    public boolean needsUpdatingWhileSaving() {
-        return mNeedsUpdating;
-    }
-
     public boolean needsUpdateThumbnail() {
         return mNeedsUpdateThumbnail;
     }
@@ -688,7 +679,7 @@ public class OCFile implements Parcelable, Comparable<OCFile> {
         return (permissions != null && permissions.contains(PERMISSION_SHARED_WITH_ME));
     }
 
-    public boolean canReshare(){
+    public boolean canReshare() {
         String permissions = getPermissions();
         return permissions != null && permissions.contains(PERMISSION_CAN_RESHARE);
     }

+ 2 - 1
src/main/java/com/owncloud/android/ui/fragment/EditShareFragment.java

@@ -153,6 +153,7 @@ public class EditShareFragment extends Fragment {
     }
 
     /**
+     * <p>
      * Get known server capabilities from DB
      * <p/>
      * Depends on the parent Activity provides a {@link com.owncloud.android.datamodel.FileDataStorageManager}
@@ -168,7 +169,7 @@ public class EditShareFragment extends Fragment {
     }
 
     /**
-     * Updates the UI with the current permissions in the edited {@OCShare}
+     * Updates the UI with the current permissions in the edited {@link OCShare}
      *
      * @param editShareView     Root view in the fragment.
      */