Преглед на файлове

Merge pull request #5822 from nextcloud/conflictToast

Fix crash while showing ConflictDialog
Tobias Kaminsky преди 5 години
родител
ревизия
ade73c3e57

+ 2 - 3
src/main/java/com/owncloud/android/ui/activity/ConflictsResolveActivity.java

@@ -46,8 +46,7 @@ import androidx.fragment.app.FragmentTransaction;
 
 
 
 
 /**
 /**
- * Wrapper activity which will be launched if keep-in-sync file will be modified by external
- * application.
+ * Wrapper activity which will be launched if keep-in-sync file will be modified by external application.
  */
  */
 public class ConflictsResolveActivity extends FileActivity implements OnConflictDecisionMadeListener {
 public class ConflictsResolveActivity extends FileActivity implements OnConflictDecisionMadeListener {
     /**
     /**
@@ -226,7 +225,7 @@ public class ConflictsResolveActivity extends FileActivity implements OnConflict
     }
     }
 
 
     private void showErrorAndFinish() {
     private void showErrorAndFinish() {
-        Toast.makeText(this, R.string.conflict_dialog_error, Toast.LENGTH_LONG).show();
+        runOnUiThread(() -> Toast.makeText(this, R.string.conflict_dialog_error, Toast.LENGTH_LONG).show());
         finish();
         finish();
     }
     }
 
 

+ 7 - 4
src/main/java/com/owncloud/android/ui/preview/PreviewTextFileFragment.java

@@ -214,13 +214,16 @@ public class PreviewTextFileFragment extends PreviewTextFragment {
 
 
             if (textView != null) {
             if (textView != null) {
                 mOriginalText = stringWriter.toString();
                 mOriginalText = stringWriter.toString();
-                mSearchView.setOnQueryTextListener(PreviewTextFileFragment.this);
-
                 setText(textView, mOriginalText, getFile(), requireActivity());
                 setText(textView, mOriginalText, getFile(), requireActivity());
 
 
-                if (mSearchOpen) {
-                    mSearchView.setQuery(mSearchQuery, true);
+                if (mSearchView != null) {
+                    mSearchView.setOnQueryTextListener(PreviewTextFileFragment.this);
+
+                    if (mSearchOpen) {
+                        mSearchView.setQuery(mSearchQuery, true);
+                    }
                 }
                 }
+
                 textView.setVisibility(View.VISIBLE);
                 textView.setVisibility(View.VISIBLE);
             }
             }