Changes due to Codacy

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java

@@ -296,7 +296,7 @@ public class AuthenticatorActivity extends AccountAuthenticatorActivity
             mIsFirstAuthAttempt = savedInstanceState.getBoolean(KEY_AUTH_IS_FIRST_ATTEMPT_TAG);
         }
 
-        String webloginUrl;
+        String webloginUrl = null;
         boolean showLegacyLogin;
         if (getIntent().getBooleanExtra(EXTRA_USE_PROVIDER_AS_WEBLOGIN, false)) {
             webViewLoginMethod = true;
@@ -304,7 +304,6 @@ public class AuthenticatorActivity extends AccountAuthenticatorActivity
             showLegacyLogin = false;
         } else {
             webViewLoginMethod = !TextUtils.isEmpty(getResources().getString(R.string.webview_login_url));
-            webloginUrl = null;
             showLegacyLogin = true;
         }
 

src/main/java/com/owncloud/android/ui/activity/FirstRunActivity.java

@@ -57,8 +57,6 @@ public class FirstRunActivity extends BaseActivity implements ViewPager.OnPageCh
     public static final String EXTRA_ALLOW_CLOSE = "ALLOW_CLOSE";
     public static final int FIRST_RUN_RESULT_CODE = 199;
 
-    private static final String TAG = FirstRunActivity.class.getSimpleName();
-
     private ProgressIndicator mProgress;
 
     @Override

src/main/java/com/owncloud/android/ui/activity/WhatsNewActivity.java

@@ -159,7 +159,7 @@ public class WhatsNewActivity extends FragmentActivity implements ViewPager.OnPa
     }
 
     static private boolean shouldShow(Context context) {
-        return !(context instanceof PassCodeActivity) && (getWhatsNew(context).length > 0);
+        return !(context instanceof PassCodeActivity) && getWhatsNew(context).length > 0;
     }
 
     @Override
@@ -189,9 +189,9 @@ public class WhatsNewActivity extends FragmentActivity implements ViewPager.OnPa
 
         if (!isFirstRun(context) && MainApp.getVersionCode() >= itemVersionCode
                 && lastSeenVersionCode < itemVersionCode) {
-            return new FeatureItem[]{(new FeatureItem(R.drawable.whats_new_device_credentials,
+            return new FeatureItem[]{new FeatureItem(R.drawable.whats_new_device_credentials,
                     R.string.whats_new_device_credentials_title, R.string.whats_new_device_credentials_content,
-                    false, false))};
+                    false, false)};
         } else {
             return new FeatureItem[0];
         }

src/main/java/com/owncloud/android/ui/adapter/FeaturesViewAdapter.java

@@ -11,7 +11,7 @@ public class FeaturesViewAdapter extends FragmentPagerAdapter {
 
     private FeatureItem[] mFeatures;
 
-    public FeaturesViewAdapter(FragmentManager fm, FeatureItem[] features) {
+    public FeaturesViewAdapter(FragmentManager fm, FeatureItem... features) {
         super(fm);
         mFeatures = features;
     }
@@ -25,4 +25,4 @@ public class FeaturesViewAdapter extends FragmentPagerAdapter {
     public int getCount() {
         return mFeatures.length;
     }
-}
+}

src/main/java/com/owncloud/android/ui/adapter/FeaturesWebViewAdapter.java

@@ -9,7 +9,7 @@ import com.owncloud.android.ui.fragment.FeatureWebFragment;
 public class FeaturesWebViewAdapter extends FragmentPagerAdapter {
     private String[] mWebUrls;
 
-    public FeaturesWebViewAdapter(FragmentManager fm, String[] webUrls) {
+    public FeaturesWebViewAdapter(FragmentManager fm, String... webUrls) {
         super(fm);
         mWebUrls = webUrls;
     }
@@ -23,4 +23,4 @@ public class FeaturesWebViewAdapter extends FragmentPagerAdapter {
     public int getCount() {
         return mWebUrls.length;
     }
-}
+}