Fix magic numbers in grid_image.xml #12

res/layout/grid_image.xml

@@ -33,8 +33,8 @@
             android:id="@+id/thumbnail"
             android:layout_width="match_parent"
             android:layout_height="match_parent"
-            android:paddingLeft="10dp"
-            android:paddingRight="10dp"
+            android:paddingLeft="@dimen/alternate_padding"
+            android:paddingRight="@dimen/alternate_padding"
             android:scaleType="centerCrop"
             android:src="@drawable/ic_menu_archive"/>
 
@@ -43,7 +43,7 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="top|right"
-            android:layout_margin="4dp"
+            android:layout_margin="@dimen/standard_quarter_margin"
             android:src="@drawable/shared_via_link" />
 
         <ImageView
@@ -51,18 +51,18 @@
             android:layout_width="@dimen/file_icon_size"
             android:layout_height="@dimen/file_icon_size"
             android:layout_gravity="bottom|right"
-            android:layout_marginTop="4dp"
-            android:layout_marginBottom="4dp"
-            android:layout_marginRight="4dp"
+            android:layout_marginTop="@dimen/standard_quarter_margin"
+            android:layout_marginBottom="@dimen/standard_quarter_margin"
+            android:layout_marginRight="@dimen/standard_quarter_margin"
             android:src="@drawable/ic_synced" />
 
         <ImageView
             android:id="@+id/favoriteIcon"
-            android:layout_width="15dp"
-            android:layout_height="15dp"
+            android:layout_width="@dimen/favorite_icon_size"
+            android:layout_height="@dimen/favorite_icon_size"
             android:layout_gravity="bottom|right"
-            android:layout_marginBottom="4dp"
-            android:layout_marginRight="4dp"
+            android:layout_marginBottom="@dimen/standard_quarter_margin"
+            android:layout_marginRight="@dimen/standard_quarter_margin"
             android:src="@drawable/ic_available_offline" />
 
         <ImageView
@@ -70,8 +70,8 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="center_vertical|top"
-            android:layout_marginLeft="4dp"
-            android:layout_marginRight="4dp"
+            android:layout_marginLeft="@dimen/standard_quarter_margin"
+            android:layout_marginRight="@dimen/standard_quarter_margin"
             android:gravity=""
             android:src="@android:drawable/checkbox_off_background" />
     </FrameLayout>

res/values/dims.xml

@@ -40,6 +40,7 @@
     <dimen name="standard_quarter_padding">4dp</dimen>
     <dimen name="standard_margin">16dp</dimen>
     <dimen name="standard_half_margin">8dp</dimen>
+    <dimen name="standard_quarter_margin">4dp</dimen>
     <dimen name="min_list_item_size">56dp</dimen>
     <dimen name="standard_list_item_size">72dp</dimen>
 
@@ -87,4 +88,6 @@
     <dimen name="file_download_fragment_display_text_margin">40dp</dimen>
 
     <dimen name="files_drawer_width">240dp</dimen>
+
+    <dimen name="favorite_icon_size">15dp</dimen>
 </resources>