remove not used videos drawer entry (#9708)

* remove not used videos drawer entry

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

* Remove unused resource

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

Co-authored-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

src/main/java/com/owncloud/android/utils/DrawerMenuUtil.java

@@ -43,7 +43,7 @@ public final class DrawerMenuUtil {
                                              User user,
                                              Resources resources) {
         if (user.isAnonymous()) {
-            filterMenuItems(menu, R.id.nav_gallery, R.id.nav_favorites, R.id.nav_videos);
+            filterMenuItems(menu, R.id.nav_gallery, R.id.nav_favorites);
         }
 
         if (!resources.getBoolean(R.bool.recently_added_enabled)) {
@@ -53,10 +53,6 @@ public final class DrawerMenuUtil {
         if (!resources.getBoolean(R.bool.recently_modified_enabled)) {
             menu.removeItem(R.id.nav_recently_modified);
         }
-
-        if (!resources.getBoolean(R.bool.videos_enabled)) {
-            menu.removeItem(R.id.nav_videos);
-        }
     }
 
     public static void filterTrashbinMenuItem(Menu menu, @Nullable OCCapability capability) {

src/main/res/drawable/nav_videos.xml

@@ -1,25 +0,0 @@
-<!--
-  Nextcloud Android client application
-
-  Copyright (C) 2020 Nextcloud.
-
-  This program is free software; you can redistribute it and/or
-  modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
-  License as published by the Free Software Foundation; either
-  version 3 of the License, or any later version.
-
-  This program is distributed in the hope that it will be useful,
-  but WITHOUT ANY WARRANTY; without even the implied warranty of
-  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-  GNU AFFERO GENERAL PUBLIC LICENSE for more details.
-
-  You should have received a copy of the GNU Affero General Public
-  License along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-  Icon provided by Android Material Library in Apache License 2.0
--->
-<vector android:height="24dp" android:tint="#757575"
-    android:viewportHeight="24.0" android:viewportWidth="24.0"
-    android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android">
-    <path android:fillColor="#FF000000" android:pathData="M21,3L3,3c-1.11,0 -2,0.89 -2,2v12c0,1.1 0.89,2 2,2h5v2h8v-2h5c1.1,0 1.99,-0.9 1.99,-2L23,5c0,-1.11 -0.9,-2 -2,-2zM21,17L3,17L3,5h18v12zM16,11l-7,4L9,7z"/>
-</vector>

src/main/res/menu/partial_drawer_entries.xml

@@ -43,12 +43,6 @@
             android:id="@+id/nav_gallery"
             android:icon="@drawable/nav_photos"
             android:title="@string/drawer_item_gallery" />
-        <item
-            android:id="@+id/nav_videos"
-            android:icon="@drawable/nav_videos"
-            android:orderInCategory="0"
-            android:title="@string/drawer_item_videos"
-            android:visible="false"/>
         <item
             android:id="@+id/nav_shared"
             android:orderInCategory="0"

src/main/res/values/setup.xml

@@ -56,7 +56,6 @@
     <bool name="recently_added_enabled">false</bool>
     <bool name="recently_modified_enabled">false</bool>
     <bool name="shared_enabled">true</bool>
-    <bool name="videos_enabled">false</bool>
     <bool name="show_drawer_logout">false</bool>
 
     <!-- Help, imprint and feedback, and other things -->

src/main/res/values/strings.xml

@@ -25,7 +25,6 @@
     <string name="drawer_item_recently_added">Recently added</string>
     <string name="drawer_item_recently_modified">Recently modified</string>
     <string name="drawer_item_shared">Shared</string>
-    <string name="drawer_item_videos">Videos</string>
     <string name="drawer_item_uploads_list">Uploads</string>
     <string name="drawer_item_activities">Activities</string>
     <string name="drawer_item_notifications">Notifications</string>