瀏覽代碼

spotbugs: remove redundant nullcheck of doubleCheck

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Andy Scherzinger 3 年之前
父節點
當前提交
c2a6e587e8
共有 1 個文件被更改,包括 3 次插入5 次删除
  1. 3 5
      src/main/java/com/owncloud/android/providers/FileContentProvider.java

+ 3 - 5
src/main/java/com/owncloud/android/providers/FileContentProvider.java

@@ -276,12 +276,10 @@ public class FileContentProvider extends ContentProvider {
                 String[] whereArgs = {remotePath, accountName};
 
                 Cursor doubleCheck = query(db, uri, projection, where, whereArgs, null);
-                // ugly patch; serious refactorization is needed to reduce work in
+                // ugly patch; serious refactoring is needed to reduce work in
                 // FileDataStorageManager and bring it to FileContentProvider
-                if (doubleCheck == null || !doubleCheck.moveToFirst()) {
-                    if (doubleCheck != null) {
-                        doubleCheck.close();
-                    }
+                if (!doubleCheck.moveToFirst()) {
+                    doubleCheck.close();
                     long rowId = db.insert(ProviderTableMeta.FILE_TABLE_NAME, null, values);
                     if (rowId > 0) {
                         return ContentUris.withAppendedId(ProviderTableMeta.CONTENT_URI_FILE, rowId);