Browse Source

Fix code analytics

Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk 11 months ago
parent
commit
c52ee55adc

+ 1 - 0
app/src/main/java/com/nextcloud/client/assistant/repository/AssistantMockRepository.kt

@@ -31,6 +31,7 @@ class AssistantMockRepository(private val giveEmptyTasks: Boolean = false) : Ass
         return RemoteOperationResult<Void>(RemoteOperationResult.ResultCode.OK)
         return RemoteOperationResult<Void>(RemoteOperationResult.ResultCode.OK)
     }
     }
 
 
+    @Suppress("LongMethod")
     override fun getTaskList(appId: String): RemoteOperationResult<TaskList> {
     override fun getTaskList(appId: String): RemoteOperationResult<TaskList> {
         val taskList = if (giveEmptyTasks) {
         val taskList = if (giveEmptyTasks) {
             TaskList(listOf())
             TaskList(listOf())

+ 1 - 0
app/src/main/java/com/nextcloud/utils/extensions/OCCapabilityExtensions.kt

@@ -21,6 +21,7 @@ fun OCCapability.forbiddenFilenameExtension(): List<String> = jsonToList(forbidd
 
 
 fun OCCapability.forbiddenFilenameBaseNames(): List<String> = jsonToList(forbiddenFilenameBaseNames)
 fun OCCapability.forbiddenFilenameBaseNames(): List<String> = jsonToList(forbiddenFilenameBaseNames)
 
 
+@Suppress("ReturnCount")
 private fun jsonToList(json: String?): List<String> {
 private fun jsonToList(json: String?): List<String> {
     if (json == null) return emptyList()
     if (json == null) return emptyList()
 
 

+ 2 - 1
app/src/main/java/com/nextcloud/utils/fileNameValidator/FileNameValidator.kt

@@ -25,7 +25,8 @@ object FileNameValidator {
      * Checks the validity of a file name.
      * Checks the validity of a file name.
      *
      *
      * @param filename The name of the file to validate.
      * @param filename The name of the file to validate.
-     * @param capability The capabilities affecting the validation criteria such as forbiddenFilenames, forbiddenCharacters.
+     * @param capability The capabilities affecting the validation criteria
+     * such as forbiddenFilenames, forbiddenCharacters.
      * @param context The context used for retrieving error messages.
      * @param context The context used for retrieving error messages.
      * @param existedFileNames Set of existing file names to avoid duplicates.
      * @param existedFileNames Set of existing file names to avoid duplicates.
      * @return An error message if the filename is invalid, null otherwise.
      * @return An error message if the filename is invalid, null otherwise.

+ 4 - 1
app/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt

@@ -456,7 +456,10 @@ open class FolderPickerActivity :
 
 
         targetFilePaths?.let { filePaths ->
         targetFilePaths?.let { filePaths ->
             if (!isFolderAndFilePathsValid(filePaths)) {
             if (!isFolderAndFilePathsValid(filePaths)) {
-                DisplayUtils.showSnackMessage(this, R.string.file_name_validator_error_contains_reserved_names_or_invalid_characters)
+                DisplayUtils.showSnackMessage(
+                    this,
+                    R.string.file_name_validator_error_contains_reserved_names_or_invalid_characters
+                )
                 Handler(Looper.getMainLooper()).postDelayed({
                 Handler(Looper.getMainLooper()).postDelayed({
                     setResult(RESULT_CANCELED, resultData)
                     setResult(RESULT_CANCELED, resultData)
                     finish()
                     finish()

+ 6 - 4
app/src/main/java/com/owncloud/android/ui/dialog/ChooseRichDocumentsTemplateDialogFragment.kt

@@ -306,10 +306,12 @@ class ChooseRichDocumentsTemplateDialogFragment :
             requireContext(),
             requireContext(),
             fileNames
             fileNames
         )
         )
-        val isExtension = (selectedTemplate == null || !name.equals(
-            DOT + selectedTemplate.extension,
-            ignoreCase = true
-        ))
+        val isExtension = (
+            selectedTemplate == null || !name.equals(
+                DOT + selectedTemplate.extension,
+                ignoreCase = true
+            )
+            )
         val isEnable = isExtension && errorMessage == null
         val isEnable = isExtension && errorMessage == null
 
 
         positiveButton?.let {
         positiveButton?.let {

+ 2 - 1
app/src/main/java/com/owncloud/android/ui/dialog/CreateFolderDialogFragment.kt

@@ -163,7 +163,8 @@ class CreateFolderDialogFragment : DialogFragment(), DialogInterface.OnClickList
             val newFolderName = (getDialog()?.findViewById<View>(R.id.user_input) as TextView)
             val newFolderName = (getDialog()?.findViewById<View>(R.id.user_input) as TextView)
                 .text.toString().trim { it <= ' ' }
                 .text.toString().trim { it <= ' ' }
 
 
-            val errorMessage: String? = FileNameValidator.checkFileName(newFolderName, getOCCapability(), requireContext())
+            val errorMessage: String? =
+                FileNameValidator.checkFileName(newFolderName, getOCCapability(), requireContext())
 
 
             if (errorMessage != null) {
             if (errorMessage != null) {
                 DisplayUtils.showSnackMessage(requireActivity(), errorMessage)
                 DisplayUtils.showSnackMessage(requireActivity(), errorMessage)

+ 8 - 5
app/src/main/java/com/owncloud/android/ui/helpers/UriUploader.kt

@@ -78,11 +78,14 @@ class UriUploader(
                     .map { it as Uri }
                     .map { it as Uri }
                     .map { Pair(it, getRemotePathForUri(it)) }
                     .map { Pair(it, getRemotePathForUri(it)) }
                     .filter { (_, filename) ->
                     .filter { (_, filename) ->
-                        val isValid = (FileNameValidator.checkFileName(
-                            filename.removePrefix("/"),
-                            mActivity.capabilities,
-                            mActivity, null
-                        ) == null)
+                        val isValid = (
+                            FileNameValidator.checkFileName(
+                                filename.removePrefix("/"),
+                                mActivity.capabilities,
+                                mActivity,
+                                null
+                            ) == null
+                            )
                         if (!isValid && !isInvalidPathMessageDisplayed) {
                         if (!isValid && !isInvalidPathMessageDisplayed) {
                             isInvalidPathMessageDisplayed = true
                             isInvalidPathMessageDisplayed = true
                             DisplayUtils.showSnackMessage(
                             DisplayUtils.showSnackMessage(