Bläddra i källkod

codacy: avoid using Literals in Conditional Statements

AndyScherzinger 6 år sedan
förälder
incheckning
c839a5b83e

+ 3 - 1
src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java

@@ -2081,6 +2081,8 @@ public class AuthenticatorActivity extends AccountAuthenticatorActivity
 
     private abstract static class RightDrawableOnTouchListener implements OnTouchListener {
 
+        private static final int RIGHT_DRAWABLE_COMPOUND_DRAWABLES_LENGTH = 2;
+
         private int fuzz = 75;
 
         /**
@@ -2091,7 +2093,7 @@ public class AuthenticatorActivity extends AccountAuthenticatorActivity
             Drawable rightDrawable = null;
             if (view instanceof TextView) {
                 Drawable[] drawables = ((TextView) view).getCompoundDrawables();
-                if (drawables.length > 2) {
+                if (drawables.length > RIGHT_DRAWABLE_COMPOUND_DRAWABLES_LENGTH) {
                     rightDrawable = drawables[2];
                 }
             }

+ 4 - 1
src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java

@@ -644,6 +644,9 @@ public final class ThumbnailsCacheManager {
     }
 
     public static class MediaThumbnailGenerationTask extends AsyncTask<Object, Void, Bitmap> {
+
+        private static final int IMAGE_KEY_PARAMS_LENGTH = 2;
+
         private enum Type {IMAGE, VIDEO}
         private final WeakReference<ImageView> mImageViewReference;
         private File mFile;
@@ -663,7 +666,7 @@ public final class ThumbnailsCacheManager {
             try {
                 if (params[0] instanceof File) {
                     mFile = (File) params[0];
-                    if (params.length == 2) {
+                    if (params.length == IMAGE_KEY_PARAMS_LENGTH) {
                         mImageKey = (String) params[1];
                     }
 

+ 5 - 4
src/main/java/com/owncloud/android/datamodel/UploadsStorageManager.java

@@ -45,13 +45,14 @@ import java.util.Observable;
  * information for each file.
  */
 public class UploadsStorageManager extends Observable {
+    private static final String TAG = UploadsStorageManager.class.getSimpleName();
 
     private static final String AND = " AND ";
-    static private final String TAG = UploadsStorageManager.class.getSimpleName();
+    private static final int SINGLE_RESULT = 1;
+
     private ContentResolver mContentResolver;
     private Context mContext;
 
-
     public UploadsStorageManager(ContentResolver contentResolver, Context context) {
         if (contentResolver == null) {
             throw new IllegalArgumentException("Cannot create an instance with a NULL contentResolver");
@@ -123,7 +124,7 @@ public class UploadsStorageManager extends Observable {
         );
 
         Log_OC.d(TAG, "updateUpload returns with: " + result + " for file: " + ocUpload.getLocalPath());
-        if (result != 1) {
+        if (result != SINGLE_RESULT) {
             Log_OC.e(TAG, "Failed to update item " + ocUpload.getLocalPath() + " into upload db.");
         } else {
             notifyObserversNow();
@@ -189,7 +190,7 @@ public class UploadsStorageManager extends Observable {
         );
 
         if (c != null) {
-            if (c.getCount() != 1) {
+            if (c.getCount() != SINGLE_RESULT) {
                 Log_OC.e(TAG, c.getCount() + " items for id=" + id
                         + " available in UploadDb. Expected 1. Failed to update upload db.");
             } else {

+ 6 - 4
src/main/java/com/owncloud/android/operations/OAuth2GetAccessToken.java

@@ -37,9 +37,11 @@ import java.util.Map;
 
 
 public class OAuth2GetAccessToken extends RemoteOperation {
-    
     private static final String TAG = OAuth2GetAccessToken.class.getSimpleName();
-    
+
+    private static final int KEY_INDEX = 0;
+    private static final int VALUE_INDEX = 1;
+
     private String mClientId;
     private String mRedirectUri;
     private String mGrantType;
@@ -149,9 +151,9 @@ public class OAuth2GetAccessToken extends RemoteOperation {
             String[] part = pairs[i].split("=");
             while (part.length > j) {
                 String p = part[j];
-                if (j == 0) {
+                if (j == KEY_INDEX) {
                     key = p;
-                } else if (j == 1) {
+                } else if (j == VALUE_INDEX) {
                     value = p;
                     mOAuth2ParsedAuthorizationResponse.put(key, value);
                 }

+ 3 - 2
src/main/java/com/owncloud/android/operations/UnshareOperation.java

@@ -43,7 +43,8 @@ import java.util.List;
 public class UnshareOperation extends SyncOperation {
 
     private static final String TAG = UnshareOperation.class.getSimpleName();
-    
+    private static final int SINGLY_SHARED = 1;
+
     private String mRemotePath;
     private ShareType mShareType;
     private String mShareWith;
@@ -83,7 +84,7 @@ public class UnshareOperation extends SyncOperation {
                     List <OCShare> sharesWith = getStorageManager().
                             getSharesWithForAFile(mRemotePath,
                             getStorageManager().getAccount().name);
-                    if (sharesWith.size() == 1) {
+                    if (sharesWith.size() == SINGLY_SHARED) {
                         file.setShareWithSharee(false);
                     }
                 }

+ 14 - 12
src/main/java/com/owncloud/android/providers/FileContentProvider.java

@@ -86,6 +86,9 @@ public class FileContentProvider extends ContentProvider {
     private static final String ADD_COLUMN = " ADD COLUMN ";
     private static final String REMOVE_COLUMN = " REMOVE COLUMN ";
     private static final String UPGRADE_VERSION_MSG = "OUT of the ADD in onUpgrade; oldVersion == %d, newVersion == %d";
+    private static final int SINGLE_PATH_SEGMENT = 1;
+    public static final int ARBITRARY_DATA_TABLE_INTRODUCTION_VERSION = 20;
+
     private DataBaseHelper mDbHelper;
     private Context mContext;
     private UriMatcher mUriMatcher;
@@ -501,67 +504,66 @@ public class FileContentProvider extends ContentProvider {
             case ROOT_DIRECTORY:
                 break;
             case DIRECTORY:
-                String folderId = uri.getPathSegments().get(1);
                 sqlQuery.appendWhere(ProviderTableMeta.FILE_PARENT + "="
-                        + folderId);
+                        + uri.getPathSegments().get(1));
                 break;
             case SINGLE_FILE:
-                if (uri.getPathSegments().size() > 1) {
+                if (uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
                     sqlQuery.appendWhere(ProviderTableMeta._ID + "="
                             + uri.getPathSegments().get(1));
                 }
                 break;
             case SHARES:
                 sqlQuery.setTables(ProviderTableMeta.OCSHARES_TABLE_NAME);
-                if (uri.getPathSegments().size() > 1) {
+                if (uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
                     sqlQuery.appendWhere(ProviderTableMeta._ID + "="
                             + uri.getPathSegments().get(1));
                 }
                 break;
             case CAPABILITIES:
                 sqlQuery.setTables(ProviderTableMeta.CAPABILITIES_TABLE_NAME);
-                if (uri.getPathSegments().size() > 1) {
+                if (uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
                     sqlQuery.appendWhere(ProviderTableMeta._ID + "="
                             + uri.getPathSegments().get(1));
                 }
                 break;
             case UPLOADS:
                 sqlQuery.setTables(ProviderTableMeta.UPLOADS_TABLE_NAME);
-                if (uri.getPathSegments().size() > 1) {
+                if (uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
                     sqlQuery.appendWhere(ProviderTableMeta._ID + "="
                             + uri.getPathSegments().get(1));
                 }
                 break;
             case SYNCED_FOLDERS:
                 sqlQuery.setTables(ProviderTableMeta.SYNCED_FOLDERS_TABLE_NAME);
-                if (uri.getPathSegments().size() > 1) {
+                if (uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
                     sqlQuery.appendWhere(ProviderTableMeta._ID + "="
                             + uri.getPathSegments().get(1));
                 }
                 break;
             case EXTERNAL_LINKS:
                 sqlQuery.setTables(ProviderTableMeta.EXTERNAL_LINKS_TABLE_NAME);
-                if (uri.getPathSegments().size() > 1) {
+                if (uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
                     sqlQuery.appendWhere(ProviderTableMeta._ID + "="
                             + uri.getPathSegments().get(1));
                 }
                 break;
             case ARBITRARY_DATA:
                 sqlQuery.setTables(ProviderTableMeta.ARBITRARY_DATA_TABLE_NAME);
-                if (uri.getPathSegments().size() > 1) {
+                if (uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
                     sqlQuery.appendWhere(ProviderTableMeta._ID + "="
                             + uri.getPathSegments().get(1));
                 }
                 break;
             case VIRTUAL:
                 sqlQuery.setTables(ProviderTableMeta.VIRTUAL_TABLE_NAME);
-                if (uri.getPathSegments().size() > 1) {
+                if (uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
                     sqlQuery.appendWhere(ProviderTableMeta._ID + "=" + uri.getPathSegments().get(1));
                 }
                 break;
             case FILESYSTEM:
                 sqlQuery.setTables(ProviderTableMeta.FILESYSTEM_TABLE_NAME);
-                if (uri.getPathSegments().size() > 1) {
+                if (uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
                     sqlQuery.appendWhere(ProviderTableMeta._ID + "="
                             + uri.getPathSegments().get(1));
                 }
@@ -1629,7 +1631,7 @@ public class FileContentProvider extends ContentProvider {
                         db.execSQL(ALTER_TABLE + ProviderTableMeta.FILE_TABLE_NAME +
                                 ADD_COLUMN + ProviderTableMeta.FILE_ENCRYPTED_NAME + " TEXT ");
                     }
-                    if (oldVersion > 20) {
+                    if (oldVersion > ARBITRARY_DATA_TABLE_INTRODUCTION_VERSION) {
                         if (!checkIfColumnExists(db, ProviderTableMeta.CAPABILITIES_TABLE_NAME,
                                 ProviderTableMeta.CAPABILITIES_END_TO_END_ENCRYPTION)) {
                             db.execSQL(ALTER_TABLE + ProviderTableMeta.CAPABILITIES_TABLE_NAME +

+ 7 - 5
src/main/java/com/owncloud/android/ui/activity/ManageAccountsActivity.java

@@ -74,15 +74,17 @@ import java.util.Set;
 public class ManageAccountsActivity extends FileActivity
         implements AccountListAdapter.AccountListAdapterListener, AccountManagerCallback<Boolean>, ComponentsGetter {
     private static final String TAG = ManageAccountsActivity.class.getSimpleName();
+
     public static final String KEY_ACCOUNT_LIST_CHANGED = "ACCOUNT_LIST_CHANGED";
     public static final String KEY_CURRENT_ACCOUNT_CHANGED = "CURRENT_ACCOUNT_CHANGED";
-
     public static final String PENDING_FOR_REMOVAL = "PENDING_FOR_REMOVAL";
 
     private static final String KEY_DISPLAY_NAME = "DISPLAY_NAME";
 
     private static final int KEY_USER_INFO_REQUEST_CODE = 13;
     private static final int KEY_DELETE_CODE = 101;
+    private static final int SINGLE_ACCOUNT = 1;
+    private static final int MIN_MULTI_ACCOUNT_SIZE = 2;
 
     private ListView mListView;
     private final Handler mHandler = new Handler();
@@ -90,8 +92,8 @@ public class ManageAccountsActivity extends FileActivity
     private AccountListAdapter mAccountListAdapter;
     private ServiceConnection mDownloadServiceConnection;
     private ServiceConnection mUploadServiceConnection;
-    Set<String> mOriginalAccounts;
-    String mOriginalCurrentAccount;
+    private Set<String> mOriginalAccounts;
+    private String mOriginalCurrentAccount;
     private Drawable mTintedCheck;
 
     private ArbitraryDataProvider arbitraryDataProvider;
@@ -347,7 +349,7 @@ public class ManageAccountsActivity extends FileActivity
             }
 
             List<AccountListItem> accountListItemArray = getAccountListItems();
-            if (accountListItemArray.size() > 1) {
+            if (accountListItemArray.size() > SINGLE_ACCOUNT) {
                 mAccountListAdapter = new AccountListAdapter(this, accountListItemArray, mTintedCheck);
                 mListView.setAdapter(mAccountListAdapter);
             } else {
@@ -452,7 +454,7 @@ public class ManageAccountsActivity extends FileActivity
         }
 
         // only one to be (deleted) account remaining
-        if (accounts.length < 2) {
+        if (accounts.length < MIN_MULTI_ACCOUNT_SIZE) {
             Intent resultIntent = new Intent();
             resultIntent.putExtra(KEY_ACCOUNT_LIST_CHANGED, true);
             resultIntent.putExtra(KEY_CURRENT_ACCOUNT_CHANGED, true);

+ 6 - 5
src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java

@@ -332,6 +332,8 @@ public class ReceiveExternalFilesActivity extends FileActivity
 
         private static final int CATEGORY_URL = 1;
         private static final int CATEGORY_MAPS_URL = 2;
+        private static final int EXTRA_TEXT_LENGTH = 3;
+        private static final int SINGLE_SPINNER_ENTRY = 1;
 
         private List<String> mFilenameBase;
         private List<String> mFilenameSuffix;
@@ -430,9 +432,8 @@ public class ReceiveExternalFilesActivity extends FileActivity
 
             final Spinner spinner = view.findViewById(R.id.file_type);
             setupSpinner(adapter, selectPos, userInput, spinner);
-            if (adapter.getCount() == 1) {
-                TextView label = view.findViewById(R.id.label_file_type);
-                label.setVisibility(View.GONE);
+            if (adapter.getCount() == SINGLE_SPINNER_ENTRY) {
+                view.findViewById(R.id.label_file_type).setVisibility(View.GONE);
                 spinner.setVisibility(View.GONE);
             }
             mSpinner = spinner;
@@ -538,7 +539,7 @@ public class ReceiveExternalFilesActivity extends FileActivity
 
         private boolean isIntentFromGoogleMap(String subjectText, String extraText) {
             String texts[] = extraText.split("\n");
-            if (texts.length != 3) {
+            if (texts.length != EXTRA_TEXT_LENGTH) {
                 return false;
             }
 
@@ -629,7 +630,7 @@ public class ReceiveExternalFilesActivity extends FileActivity
 
     @Override
     public void onBackPressed() {
-        if (mParents.size() <= 1) {
+        if (mParents.size() <= SINGLE_PARENT) {
             super.onBackPressed();
         } else {
             mParents.pop();

+ 3 - 2
src/main/java/com/owncloud/android/ui/activity/UploadFilesActivity.java

@@ -1,4 +1,4 @@
-/**
+/*
  *   ownCloud Android client application
  *
  *   @author David A. Velasco
@@ -82,6 +82,7 @@ public class UploadFilesActivity extends FileActivity implements
         OnClickListener, ConfirmationDialogFragmentListener, SortingOrderDialogFragment.OnSortingOrderListener {
 
     private static final String SORT_ORDER_DIALOG_TAG = "SORT_ORDER_DIALOG";
+    private static final int SINGLE_DIR = 1;
 
     private ArrayAdapter<String> mDirectories;
     private File mCurrentDir;
@@ -333,7 +334,7 @@ public class UploadFilesActivity extends FileActivity implements
             mSearchView.onActionViewCollapsed();
             setDrawerIndicatorEnabled(isDrawerIndicatorAvailable());
         } else {
-            if (mDirectories.getCount() <= 1) {
+            if (mDirectories.getCount() <= SINGLE_DIR) {
                 finish();
                 return;
             }

+ 3 - 3
src/main/java/com/owncloud/android/ui/dialog/RemoveFilesDialogFragment.java

@@ -42,10 +42,10 @@ import java.util.Collection;
 public class RemoveFilesDialogFragment extends ConfirmationDialogFragment implements
         ConfirmationDialogFragmentListener {
 
-    private Collection<OCFile> mTargetFiles;
-
+    private static final int SINGLE_SELECTION = 1;
     private static final String ARG_TARGET_FILES = "TARGET_FILES";
 
+    private Collection<OCFile> mTargetFiles;
     private ActionMode actionMode;
 
     /**
@@ -81,7 +81,7 @@ public class RemoveFilesDialogFragment extends ConfirmationDialogFragment implem
             containsFavorite |= file.isAvailableOffline();
         }
 
-        if (files.size() == 1) {
+        if (files.size() == SINGLE_SELECTION) {
             // choose message for a single file
             OCFile file = files.get(0);
 

+ 3 - 1
src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java

@@ -152,6 +152,8 @@ public class OCFileListFragment extends ExtendedListFragment implements
 
     private static final String DIALOG_CREATE_FOLDER = "DIALOG_CREATE_FOLDER";
 
+    private static final int SINGLE_SELECTION = 1;
+
     private FileFragment.ContainerActivity mContainerActivity;
 
     private OCFile mFile;
@@ -894,7 +896,7 @@ public class OCFileListFragment extends ExtendedListFragment implements
             return false;
         }
 
-        if (checkedFiles.size() == 1) {
+        if (checkedFiles.size() == SINGLE_SELECTION) {
             /// action only possible on a single file
             OCFile singleFile = checkedFiles.iterator().next();
             switch (menuId) {

+ 6 - 3
src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java

@@ -109,9 +109,10 @@ public class ContactListFragment extends FileFragment {
 
     public static final String FILE_NAME = "FILE_NAME";
     public static final String ACCOUNT = "ACCOUNT";
-
     public static final String CHECKED_ITEMS_ARRAY_KEY = "CHECKED_ITEMS";
 
+    private static final int SINGLE_ACCOUNT = 1;
+
     @BindView(R.id.contactlist_recyclerview)
     public RecyclerView recyclerView;
 
@@ -416,7 +417,7 @@ public class ContactListFragment extends FileFragment {
             }
         }
 
-        if (accounts.size() == 1) {
+        if (accounts.size() == SINGLE_ACCOUNT) {
             importContacts(accounts.get(0));
         } else {
             ArrayAdapter adapter = new ArrayAdapter<>(getContext(), android.R.layout.simple_list_item_1, accounts);
@@ -565,6 +566,8 @@ public class ContactListFragment extends FileFragment {
 }
 
 class ContactListAdapter extends RecyclerView.Adapter<ContactListFragment.ContactItemViewHolder> {
+    private static final int SINGLE_SELECTION = 1;
+
     private List<VCard> vCards;
     private Set<Integer> checkedVCards;
 
@@ -704,7 +707,7 @@ class ContactListAdapter extends RecyclerView.Adapter<ContactListFragment.Contac
             if (!checkedVCards.contains(verifiedPosition)) {
                 checkedVCards.add(verifiedPosition);
             }
-            if (checkedVCards.size() == 1) {
+            if (checkedVCards.size() == SINGLE_SELECTION) {
                 EventBus.getDefault().post(new VCardToggleEvent(true));
             }
         } else {

+ 3 - 2
src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.java

@@ -412,6 +412,7 @@ public class PreviewImageFragment extends FileFragment {
 
 
     private class LoadBitmapTask extends AsyncTask<OCFile, Void, LoadImage> {
+        private static final int PARAMS_LENGTH = 1;
 
         /**
          * Weak reference to the target {@link ImageView} where the bitmap will be loaded into.
@@ -422,7 +423,7 @@ public class PreviewImageFragment extends FileFragment {
         private final WeakReference<PhotoView> mImageViewRef;
 
         /**
-         * Error message to show when a load fails
+         * Error message to show when a load fails.
          */
         private int mErrorMessageId;
 
@@ -440,7 +441,7 @@ public class PreviewImageFragment extends FileFragment {
         protected LoadImage doInBackground(OCFile... params) {
             Process.setThreadPriority(Process.THREAD_PRIORITY_BACKGROUND + Process.THREAD_PRIORITY_MORE_FAVORABLE);
 
-            if (params.length != 1) {
+            if (params.length != PARAMS_LENGTH) {
                 return null;
             }
 

+ 2 - 2
src/main/java/com/owncloud/android/ui/preview/PreviewMediaFragment.java

@@ -95,6 +95,7 @@ public class PreviewMediaFragment extends FileFragment implements
     public static final String EXTRA_ACCOUNT = "ACCOUNT";
     private static final String EXTRA_PLAY_POSITION = "PLAY_POSITION";
     private static final String EXTRA_PLAYING = "PLAYING";
+    private static final double MIN_DENSITY_RATIO = 24.0;
 
     private Account mAccount;
     private ImageView mImagePreview;
@@ -666,7 +667,7 @@ public class PreviewMediaFragment extends FileFragment implements
     public boolean onTouch(View v, MotionEvent event) {
         if (event.getAction() == MotionEvent.ACTION_DOWN && v.equals(mVideoPreview)) {
             // added a margin on the left to avoid interfering with gesture to open navigation drawer
-            if (event.getX() / Resources.getSystem().getDisplayMetrics().density > 24.0) {
+            if (event.getX() / Resources.getSystem().getDisplayMetrics().density > MIN_DENSITY_RATIO) {
                 startFullScreenVideo();
             }
             return true;
@@ -674,7 +675,6 @@ public class PreviewMediaFragment extends FileFragment implements
         return false;
     }
 
-
     private void startFullScreenVideo() {
         Intent i = new Intent(getActivity(), PreviewVideoActivity.class);
         i.putExtra(FileActivity.EXTRA_ACCOUNT, mAccount);

+ 4 - 2
src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.java

@@ -193,6 +193,7 @@ public class    PreviewTextFragment extends FileFragment {
      * Reads the file to preview and shows its contents. Too critical to be anonymous.
      */
     private class TextLoadAsyncTask extends AsyncTask<Object, Void, StringWriter> {
+        private static final int PARAMS_LENGTH = 1;
         private final WeakReference<TextView> mTextViewReference;
 
         private TextLoadAsyncTask(WeakReference<TextView> textView) {
@@ -206,8 +207,9 @@ public class    PreviewTextFragment extends FileFragment {
 
         @Override
         protected StringWriter doInBackground(java.lang.Object... params) {
-            if (params.length != 1) {
-                throw new IllegalArgumentException("The parameter to " + TextLoadAsyncTask.class.getName() + " must be (1) the file location");
+            if (params.length != PARAMS_LENGTH) {
+                throw new IllegalArgumentException("The parameter to " + TextLoadAsyncTask.class.getName()
+                        + " must be (1) the file location");
             }
             String location = (String) params[0];
 

+ 3 - 2
src/main/java/com/owncloud/android/utils/ConnectivityUtils.java

@@ -39,6 +39,7 @@ import com.owncloud.android.lib.common.OwnCloudClientFactory;
 import com.owncloud.android.lib.common.utils.Log_OC;
 import com.owncloud.android.lib.resources.status.OwnCloudVersion;
 
+import org.apache.commons.httpclient.HttpStatus;
 import org.apache.commons.httpclient.methods.GetMethod;
 import org.json.JSONObject;
 
@@ -73,10 +74,10 @@ public final class ConnectivityUtils {
                     int status = client.executeMethod(get);
 
                     if (serverVersion.compareTo(OwnCloudVersion.nextcloud_13) > 0) {
-                        return !(status == 204 &&
+                        return !(status == HttpStatus.SC_NO_CONTENT &&
                                 (get.getResponseContentLength() == -1 || get.getResponseContentLength() == 0));
                     } else {
-                        if (status == 200) {
+                        if (status == HttpStatus.SC_OK) {
                             try {
                                 // try parsing json to verify response
                                 // check if json contains maintenance and it should be false

+ 8 - 4
src/main/java/com/owncloud/android/utils/DisplayUtils.java

@@ -113,6 +113,10 @@ public final class DisplayUtils {
     private static final String HTTP_PROTOCOL = "http://";
     private static final String HTTPS_PROTOCOL = "https://";
     private static final String TWITTER_HANDLE_PREFIX = "@";
+    private static final int MIMETYPE_PARTS_COUNT = 2;
+    private static final int BYTE_SIZE_DIVIDER = 1024;
+    private static final double BYTE_SIZE_DIVIDER_DOUBLE = 1024.;
+    private static final int DATE_TIME_PARTS_SIZE = 2;
 
     private static Map<String, String> mimeType2HumanReadable;
 
@@ -152,8 +156,8 @@ public final class DisplayUtils {
         } else {
             double result = bytes;
             int suffixIndex = 0;
-            while (result > 1024 && suffixIndex < sizeSuffixes.length) {
-                result /= 1024.;
+            while (result > BYTE_SIZE_DIVIDER && suffixIndex < sizeSuffixes.length) {
+                result /= BYTE_SIZE_DIVIDER_DOUBLE;
                 suffixIndex++;
             }
 
@@ -173,7 +177,7 @@ public final class DisplayUtils {
         if (mimeType2HumanReadable.containsKey(mimetype)) {
             return mimeType2HumanReadable.get(mimetype);
         }
-        if (mimetype.split("/").length >= 2) {
+        if (mimetype.split("/").length >= MIMETYPE_PARTS_COUNT) {
             return mimetype.split("/")[1].toUpperCase(Locale.getDefault()) + " file";
         }
         return MIME_TYPE_UNKNOWN;
@@ -351,7 +355,7 @@ public final class DisplayUtils {
         }
 
         String[] parts = dateString.toString().split(",");
-        if (parts.length == 2) {
+        if (parts.length == DATE_TIME_PARTS_SIZE) {
             if (parts[1].contains(":") && !parts[0].contains(":")) {
                 return parts[0];
             } else if (parts[0].contains(":") && !parts[1].contains(":")) {