Merge pull request #6346 from nextcloud/urf

fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD

scripts/analysis/findbugs-results.txt

@@ -1 +1 @@
-361
+357

src/main/java/com/owncloud/android/services/OperationsService.java

@@ -108,8 +108,6 @@ public class OperationsService extends Service {
     public static final String EXTRA_SHARE_NOTE = "SHARE_NOTE";
     public static final String EXTRA_IN_BACKGROUND = "IN_BACKGROUND";
 
-    public static final String EXTRA_COOKIE = "COOKIE";
-
     public static final String ACTION_CREATE_SHARE_VIA_LINK = "CREATE_SHARE_VIA_LINK";
     public static final String ACTION_CREATE_SHARE_WITH_SHAREE = "CREATE_SHARE_WITH_SHAREE";
     public static final String ACTION_UNSHARE = "UNSHARE";
@@ -127,9 +125,6 @@ public class OperationsService extends Service {
     public static final String ACTION_CHECK_CURRENT_CREDENTIALS = "CHECK_CURRENT_CREDENTIALS";
     public static final String ACTION_RESTORE_VERSION = "RESTORE_VERSION";
 
-    public static final String ACTION_OPERATION_ADDED = OperationsService.class.getName() + ".OPERATION_ADDED";
-    public static final String ACTION_OPERATION_FINISHED = OperationsService.class.getName() + ".OPERATION_FINISHED";
-
     private ServiceHandler mOperationsHandler;
     private OperationsServiceBinder mOperationsBinder;
 
@@ -143,12 +138,10 @@ public class OperationsService extends Service {
     private static class Target {
         public Uri mServerUrl;
         public Account mAccount;
-        public String mCookie;
 
-        public Target(Account account, Uri serverUrl, String cookie) {
+        public Target(Account account, Uri serverUrl) {
             mAccount = account;
             mServerUrl = serverUrl;
-            mCookie = cookie;
         }
     }
 
@@ -522,12 +515,7 @@ public class OperationsService extends Service {
             } else {
                 Account account = operationIntent.getParcelableExtra(EXTRA_ACCOUNT);
                 String serverUrl = operationIntent.getStringExtra(EXTRA_SERVER_URL);
-                String cookie = operationIntent.getStringExtra(EXTRA_COOKIE);
-                target = new Target(
-                    account,
-                        (serverUrl == null) ? null : Uri.parse(serverUrl),
-                        cookie
-                );
+                target = new Target(account, (serverUrl == null) ? null : Uri.parse(serverUrl));
 
                 String action = operationIntent.getAction();
                 String remotePath;

src/main/java/com/owncloud/android/ui/adapter/ActivityAndVersionListAdapter.java

@@ -169,8 +169,6 @@ public class ActivityAndVersionListAdapter extends ActivityListAdapter {
     }
 
     protected class VersionViewHolder extends RecyclerView.ViewHolder {
-        @BindView(R.id.thumbnail)
-        public ImageView thumbnail;
         @BindView(R.id.size)
         public TextView size;
         @BindView(R.id.time)

src/main/java/com/owncloud/android/ui/adapter/SyncedFolderAdapter.java

@@ -26,7 +26,6 @@ import android.view.LayoutInflater;
 import android.view.MenuItem;
 import android.view.View;
 import android.view.ViewGroup;
-import android.widget.FrameLayout;
 import android.widget.ImageButton;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
@@ -421,9 +420,6 @@ public class SyncedFolderAdapter extends SectionedRecyclerViewAdapter<SectionedV
     }
 
     static class FooterViewHolder extends SectionedViewHolder {
-        @BindView(R.id.footer_container)
-        public LinearLayout mainFooterContainer;
-
         @BindView(R.id.footer_text)
         public TextView title;
 
@@ -440,9 +436,6 @@ public class SyncedFolderAdapter extends SectionedRecyclerViewAdapter<SectionedV
     }
 
     static class MainViewHolder extends SectionedViewHolder {
-        @BindView(R.id.grid_item_container)
-        public FrameLayout item_container;
-
         @BindView(R.id.thumbnail)
         public ImageView image;