Browse Source

Fix magic numbers in popup.xml #12

Divay Prakash 8 years ago
parent
commit
ce9df17acc
2 changed files with 7 additions and 4 deletions
  1. 4 4
      res/layout/popup.xml
  2. 3 0
      res/values/dims.xml

+ 4 - 4
res/layout/popup.xml

@@ -25,11 +25,11 @@
       
   <ScrollView 
     android:id="@+id/scroller"
-    android:layout_marginTop="16dip"
+    android:layout_marginTop="@dimen/standard_margin_independent"
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
       android:background="@drawable/popup"
-      android:fadingEdgeLength="5dip"
+      android:fadingEdgeLength="@dimen/alternate_half_padding_independent"
       android:scrollbars="none">
         
       <LinearLayout
@@ -38,7 +38,7 @@
           android:layout_width="wrap_content"
           android:layout_height="wrap_content"
           android:layout_weight="1"
-          android:padding="10dip"/>
+          android:padding="@dimen/alternate_padding_independent"/>
        
   </ScrollView >
   
@@ -52,7 +52,7 @@
         android:id="@+id/arrow_down"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginTop="-4dip"
+        android:layout_marginTop="@dimen/standard_quarter_margin_negative_independent"
         android:src="@drawable/arrow_down" android:layout_below="@+id/scroller"/>
 
 </RelativeLayout>

+ 3 - 0
res/values/dims.xml

@@ -104,4 +104,7 @@
     <dimen name="seek_bar_height">32dp</dimen>
     <dimen name="notification_with_progress_bar_layout">12dp</dimen>
     <dimen name="notification_with_progress_bar_layout_height">64dp</dimen>
+
+    <dimen name="standard_margin_independent">16dip</dimen>
+    <dimen name="standard_quarter_margin_negative_independent">-4dip</dimen>
 </resources>