浏览代码

Merge pull request #3789 from nextcloud/try-with-resources-in-download-file-operation

operations: properly close FileOutputStream.
Andy Scherzinger 6 年之前
父节点
当前提交
d4c008188a

+ 1 - 1
scripts/analysis/findbugs-results.txt

@@ -1 +1 @@
-474
+473

+ 3 - 2
src/main/java/com/owncloud/android/operations/DownloadFileOperation.java

@@ -203,8 +203,9 @@ public class DownloadFileOperation extends RemoteOperation {
                 try {
                     byte[] decryptedBytes = EncryptionUtils.decryptFile(tmpFile, key, iv, authenticationTag);
 
-                    FileOutputStream fileOutputStream = new FileOutputStream(tmpFile);
-                    fileOutputStream.write(decryptedBytes);
+                    try (FileOutputStream fileOutputStream = new FileOutputStream(tmpFile)) {
+                        fileOutputStream.write(decryptedBytes);
+                    }
                 } catch (Exception e) {
                     return new RemoteOperationResult(e);
                 }