Browse Source

codacy: avoid using Literals in Conditional Statements

AndyScherzinger 6 years ago
parent
commit
d5008116db

+ 4 - 2
src/main/java/com/owncloud/android/ui/activities/data/activities/ActivitiesServiceApiImpl.java

@@ -1,4 +1,4 @@
-/**
+/*
  *   Nextcloud Android client application
  *
  *   Copyright (C) 2018 Edvard Holst
@@ -34,6 +34,8 @@ import com.owncloud.android.lib.common.operations.RemoteOperationResult;
 import com.owncloud.android.lib.common.utils.Log_OC;
 import com.owncloud.android.lib.resources.activities.GetRemoteActivitiesOperation;
 
+import org.apache.commons.httpclient.HttpStatus;
+
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
@@ -94,7 +96,7 @@ public class ActivitiesServiceApiImpl implements ActivitiesServiceApi {
                     Log_OC.d(TAG, result.getLogMessage());
                     // show error
                     errorMessage = result.getLogMessage();
-                    if (result.getHttpCode() == 304) {
+                    if (result.getHttpCode() == HttpStatus.SC_NOT_MODIFIED) {
                         errorMessage = context.getString(R.string.file_list_empty_headline_server_search);
                     }
                     return false;

+ 3 - 1
src/main/java/com/owncloud/android/ui/fragment/FileDetailActivitiesFragment.java

@@ -69,6 +69,8 @@ import com.owncloud.android.ui.interfaces.ActivityListInterface;
 import com.owncloud.android.ui.interfaces.VersionListInterface;
 import com.owncloud.android.utils.ThemeUtils;
 
+import org.apache.commons.httpclient.HttpStatus;
+
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
@@ -332,7 +334,7 @@ public class FileDetailActivitiesFragment extends Fragment implements ActivityLi
                     Log_OC.d(TAG, result.getLogMessage());
                     // show error
                     String logMessage = result.getLogMessage();
-                    if (result.getHttpCode() == 304) {
+                    if (result.getHttpCode() == HttpStatus.SC_NOT_MODIFIED) {
                         logMessage = noResultsMessage;
                     }
                     final String finalLogMessage = logMessage;