فهرست منبع

Javascript enabled for WebViews is fine

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Andy Scherzinger 4 سال پیش
والد
کامیت
d52fbb3790

+ 1 - 0
src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java

@@ -347,6 +347,7 @@ public class AuthenticatorActivity extends AccountAuthenticatorActivity
             Build.MANUFACTURER.substring(1).toLowerCase(Locale.getDefault()) + " " + Build.MODEL + " (Android)";
     }
 
+    @SuppressFBWarnings("ANDROID_WEB_VIEW_JAVASCRIPT")
     @SuppressLint("SetJavaScriptEnabled")
     private void initWebViewLogin(String baseURL, boolean useGenericUserAgent) {
         mLoginWebView.setVisibility(View.GONE);

+ 2 - 0
src/main/java/com/owncloud/android/ui/activity/ExternalSiteWebView.java

@@ -44,6 +44,7 @@ import java.io.InputStream;
 
 import androidx.appcompat.app.ActionBar;
 import androidx.drawerlayout.widget.DrawerLayout;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 /**
  * This activity shows an URL as a web view
@@ -149,6 +150,7 @@ public class ExternalSiteWebView extends FileActivity {
         webview.loadUrl(url);
     }
 
+    @SuppressFBWarnings("ANDROID_WEB_VIEW_JAVASCRIPT")
     @SuppressLint("SetJavaScriptEnabled")
     private void setupWebSettings(WebSettings webSettings) {
         // enable zoom

+ 2 - 0
src/main/java/com/owncloud/android/ui/activity/RichDocumentsEditorWebView.java

@@ -65,6 +65,7 @@ import androidx.annotation.NonNull;
 import androidx.annotation.RequiresApi;
 import butterknife.ButterKnife;
 import butterknife.Unbinder;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 /**
  * Opens document for editing via Richdocuments app in a web view
@@ -90,6 +91,7 @@ public class RichDocumentsEditorWebView extends EditorWebView {
     @Inject
     protected ClientFactory clientFactory;
 
+    @SuppressFBWarnings("ANDROID_WEB_VIEW_JAVASCRIPT_INTERFACE")
     @SuppressLint("AddJavascriptInterface") // suppress warning as webview is only used >= Lollipop
     @Override
     protected void onCreate(Bundle savedInstanceState) {

+ 2 - 0
src/main/java/com/owncloud/android/ui/fragment/FeatureWebFragment.java

@@ -14,6 +14,7 @@ import com.owncloud.android.R;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.fragment.app.Fragment;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 public class FeatureWebFragment extends Fragment {
     private String mWebUrl;
@@ -32,6 +33,7 @@ public class FeatureWebFragment extends Fragment {
         mWebUrl = getArguments() != null ? getArguments().getString("url") : null;
     }
 
+    @SuppressFBWarnings("ANDROID_WEB_VIEW_JAVASCRIPT")
     @SuppressLint("SetJavaScriptEnabled")
     @Nullable
     @Override