소스 검색

fix lint for item divider, plus code formatting

AndyScherzinger 6 년 전
부모
커밋
d8c4be0604

+ 3 - 2
src/main/java/com/owncloud/android/ui/decoration/SimpleListItemDividerDecoration.java

@@ -45,9 +45,10 @@ public class SimpleListItemDividerDecoration extends DividerItemDecoration {
      */
     public SimpleListItemDividerDecoration(Context context) {
         super(context, DividerItemDecoration.VERTICAL);
-        final TypedArray a = context.obtainStyledAttributes(ATTRS);
-        divider = a.getDrawable(0);
+        final TypedArray styledAttributes = context.obtainStyledAttributes(ATTRS);
+        divider = styledAttributes.getDrawable(0);
         leftPadding = Math.round(72 * (context.getResources().getDisplayMetrics().xdpi / DisplayMetrics.DENSITY_DEFAULT));
+        styledAttributes.recycle();
     }
 
     @Override

+ 2 - 0
src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java

@@ -362,6 +362,8 @@ public class FileDetailFragment extends FileFragment implements OnClickListener
         if (!getResources().getBoolean(R.bool.large_land_layout)){
             FileMenuFilter.hideMenuItems(menu.findItem(R.id.action_sync_account));
         }
+
+
     }
 
     private boolean optionsItemSelected(MenuItem item) {

+ 1 - 5
src/main/java/com/owncloud/android/ui/fragment/util/FileDetailSharingFragmentHelper.java

@@ -95,13 +95,9 @@ public class FileDetailSharingFragmentHelper {
      */
     public static void setupExpirationDateMenuItem(MenuItem expirationDate, long expirationDateValue, Resources res) {
         if (expirationDateValue > 0) {
-            String formattedDate =
-                    SimpleDateFormat.getDateInstance().format(
-                            new Date(expirationDateValue)
-                    );
             expirationDate.setTitle(res.getString(
                     R.string.share_expiration_date_label,
-                    formattedDate
+                    SimpleDateFormat.getDateInstance().format(new Date(expirationDateValue))
             ));
         } else {
             expirationDate.setTitle(res.getString(